* [TRIVIAL] 16) request_region check, 11-20
@ 2002-08-07 4:23 Rusty Trivial Russell
2002-08-07 11:33 ` Alan Cox
0 siblings, 1 reply; 6+ messages in thread
From: Rusty Trivial Russell @ 2002-08-07 4:23 UTC (permalink / raw)
To: Marcelo Tosatti; +Cc: linux-scsi
From: johnpol@2ka.mipt.ru
(Included in 2.5)
here is one more trivial check.
So please test and apply.
Evgeniy Polyakov ( s0mbre )
--- trivial-2.4.20-pre1/drivers/acorn/scsi/oak.c.orig 2002-08-07 10:58:01.000000000 +1000
+++ trivial-2.4.20-pre1/drivers/acorn/scsi/oak.c 2002-08-07 10:58:01.000000000 +1000
@@ -134,7 +134,8 @@
ecard_claim(ecs[count]);
instance->n_io_port = 255;
- request_region (instance->io_port, instance->n_io_port, "Oak SCSI");
+ if (!request_region (instance->io_port, instance->n_io_port, "Oak SCSI"))
+ break;
if (instance->irq != IRQ_NONE)
if (request_irq(instance->irq, do_oakscsi_intr, SA_INTERRUPT, "Oak SCSI", NULL)) {
--
Don't blame me: the Monkey is driving
^ permalink raw reply [flat|nested] 6+ messages in thread* [TRIVIAL] 16) request_region check, 11-20
@ 2002-12-16 10:49 Rusty Trivial Russell
0 siblings, 0 replies; 6+ messages in thread
From: Rusty Trivial Russell @ 2002-12-16 10:49 UTC (permalink / raw)
To: linux-scsi, rmk
(Included in 2.5)
From: johnpol@2ka.mipt.ru
here is one more trivial check.
So please test and apply.
Evgeniy Polyakov ( s0mbre )
--- trivial-2.4.21-pre1/drivers/acorn/scsi/oak.c.orig 2002-12-16 17:22:38.000000000 +1100
+++ trivial-2.4.21-pre1/drivers/acorn/scsi/oak.c 2002-12-16 17:22:38.000000000 +1100
@@ -134,7 +134,8 @@
ecard_claim(ecs[count]);
instance->n_io_port = 255;
- request_region (instance->io_port, instance->n_io_port, "Oak SCSI");
+ if (!request_region (instance->io_port, instance->n_io_port, "Oak SCSI"))
+ break;
if (instance->irq != IRQ_NONE)
if (request_irq(instance->irq, do_oakscsi_intr, SA_INTERRUPT, "Oak SCSI", NULL)) {
--
Don't blame me: the Monkey is driving
File: johnpol@2ka.mipt.ru: 16) request_region check, 11-20
^ permalink raw reply [flat|nested] 6+ messages in thread* [TRIVIAL] 16) request_region check, 11-20
@ 2003-02-06 3:22 Rusty Trivial Russell
0 siblings, 0 replies; 6+ messages in thread
From: Rusty Trivial Russell @ 2003-02-06 3:22 UTC (permalink / raw)
To: Marcelo Tosatti; +Cc: linux-scsi, rmk
(Included in 2.5)
From: johnpol@2ka.mipt.ru
here is one more trivial check.
So please test and apply.
Evgeniy Polyakov ( s0mbre )
--- trivial-2.4.21-pre4/drivers/acorn/scsi/oak.c.orig 2003-02-06 13:53:54.000000000 +1100
+++ trivial-2.4.21-pre4/drivers/acorn/scsi/oak.c 2003-02-06 13:53:54.000000000 +1100
@@ -134,7 +134,8 @@
ecard_claim(ecs[count]);
instance->n_io_port = 255;
- request_region (instance->io_port, instance->n_io_port, "Oak SCSI");
+ if (!request_region (instance->io_port, instance->n_io_port, "Oak SCSI"))
+ break;
if (instance->irq != IRQ_NONE)
if (request_irq(instance->irq, do_oakscsi_intr, SA_INTERRUPT, "Oak SCSI", NULL)) {
--
Don't blame me: the Monkey is driving
File: johnpol@2ka.mipt.ru: 16) request_region check, 11-20
^ permalink raw reply [flat|nested] 6+ messages in thread* [TRIVIAL] 16) request_region check, 11-20
@ 2003-06-23 7:00 Rusty Trivial Russell
2003-06-27 12:53 ` Alan Cox
0 siblings, 1 reply; 6+ messages in thread
From: Rusty Trivial Russell @ 2003-06-23 7:00 UTC (permalink / raw)
To: Marcelo Tosatti; +Cc: linux-scsi, rmk
(Included in 2.5)
From: johnpol@2ka.mipt.ru
here is one more trivial check.
So please test and apply.
Evgeniy Polyakov ( s0mbre )
--- trivial-2.4.22-pre1/drivers/acorn/scsi/oak.c.orig 2003-06-23 16:39:46.000000000 +1000
+++ trivial-2.4.22-pre1/drivers/acorn/scsi/oak.c 2003-06-23 16:39:46.000000000 +1000
@@ -134,7 +134,8 @@
ecard_claim(ecs[count]);
instance->n_io_port = 255;
- request_region (instance->io_port, instance->n_io_port, "Oak SCSI");
+ if (!request_region (instance->io_port, instance->n_io_port, "Oak SCSI"))
+ break;
if (instance->irq != IRQ_NONE)
if (request_irq(instance->irq, do_oakscsi_intr, SA_INTERRUPT, "Oak SCSI", NULL)) {
--
What is this? http://www.kernel.org/pub/linux/kernel/people/rusty/trivial/
Don't blame me: the Monkey is driving
File: johnpol@2ka.mipt.ru: 16) request_region check, 11-20
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [TRIVIAL] 16) request_region check, 11-20
2003-06-23 7:00 Rusty Trivial Russell
@ 2003-06-27 12:53 ` Alan Cox
0 siblings, 0 replies; 6+ messages in thread
From: Alan Cox @ 2003-06-27 12:53 UTC (permalink / raw)
To: Rusty Trivial Russell; +Cc: Marcelo Tosatti, linux-scsi, rmk
On Llu, 2003-06-23 at 08:00, Rusty Trivial Russell wrote:
> --- trivial-2.4.22-pre1/drivers/acorn/scsi/oak.c.orig 2003-06-23 16:39:46.000000000 +1000
> +++ trivial-2.4.22-pre1/drivers/acorn/scsi/oak.c 2003-06-23 16:39:46.000000000 +1000
> @@ -134,7 +134,8 @@
> ecard_claim(ecs[count]);
>
> instance->n_io_port = 255;
> - request_region (instance->io_port, instance->n_io_port, "Oak SCSI");
> + if (!request_region (instance->io_port, instance->n_io_port, "Oak SCSI"))
> + break;
>
Doesn't clean up the register etc - so clearly wrong. Actually I suspect
what needs doing is to request_region first, then register then _check_
the scsi_register return (it doesnt) and unregister the region.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2003-06-27 12:42 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2002-08-07 4:23 [TRIVIAL] 16) request_region check, 11-20 Rusty Trivial Russell
2002-08-07 11:33 ` Alan Cox
-- strict thread matches above, loose matches on Subject: below --
2002-12-16 10:49 Rusty Trivial Russell
2003-02-06 3:22 Rusty Trivial Russell
2003-06-23 7:00 Rusty Trivial Russell
2003-06-27 12:53 ` Alan Cox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox