[PATCH] unique_id for ide-scsi

[PATCH] unique_id for ide-scsi

[Kurt Garloff]

[-- Attachment #1.1: Type: text/plain, Size: 437 bytes --]

Hi,

most scsi host adapters do fill in their ioport into thos host's 
unique_id field.
ide-scsi does not. The attached patch changes it.

Caveats: It puts the first PATA port there, the SATA port are not
 considered. Are there SATA chips that don't have PATA ports?

Regards,
-- 
Kurt Garloff  <garloff@suse.de>                            Cologne, DE 
SUSE LINUX AG, Nuernberg, DE                          SUSE Labs (Head)

[-- Attachment #1.2: ide-scsi-unique-id.diff --]
[-- Type: text/plain, Size: 349 bytes --]

--- drivers/scsi/ide-scsi.c.orig	2004-01-09 07:59:45.000000000 +0100
+++ drivers/scsi/ide-scsi.c	2004-02-09 16:26:24.033475704 +0100
@@ -967,6 +967,7 @@
 
 	host->max_id = 1;
 	host->max_lun = 1;
+	host->unique_id = drive->hwif->hw.io_ports[0];
 	drive->driver_data = host;
 	idescsi = scsihost_to_idescsi(host);
 	idescsi->drive = drive;

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

Re: [PATCH] unique_id for ide-scsi

[Christoph Hellwig]

On Mon, Feb 09, 2004 at 04:54:40PM +0100, Kurt Garloff wrote:
> Hi,
> 
> most scsi host adapters do fill in their ioport into thos host's 
> unique_id field.
> ide-scsi does not. The attached patch changes it.
> 
> Caveats: It puts the first PATA port there, the SATA port are not
>  considered. Are there SATA chips that don't have PATA ports?

What do you need this for?  I'd prefer to completly nuke unique_id in
2.7.<early>

Re: [PATCH] unique_id for ide-scsi

[Kurt Garloff]

[-- Attachment #1: Type: text/plain, Size: 706 bytes --]

Hi Christoph,

On Mon, Feb 09, 2004 at 04:06:05PM +0000, Christoph Hellwig wrote:
> > Caveats: It puts the first PATA port there, the SATA port are not
> >  considered. Are there SATA chips that don't have PATA ports?
> 
> What do you need this for?  I'd prefer to completly nuke unique_id in
> 2.7.<early>

You have two scsi host adapters of one kind and want to identify the
path to them. For non-enumerated buses (like ISA), the unique_id is 
useful. 

Regards,
-- 
Kurt Garloff                   <kurt@garloff.de>             [Koeln, DE]
Physics:Plasma modeling <garloff@plasimo.phys.tue.nl> [TU Eindhoven, NL]
Linux: SUSE Labs (Head)        <garloff@suse.de>    [SUSE Nuernberg, DE]

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]