Re: 2.6.19-rc5-mm1

Re: 2.6.19-rc5-mm1

[Andrew Morton]

(added linux-scsi.  I think we had one such report against rc4-mm2 as well).

On Thu, 9 Nov 2006 00:55:43 +0100
"C__dric Augonnet" <cedric.augonnet@gmail.com> wrote:

> Hi,
> 
> I am having this oops each time I unplug my USB external hard drive.
> It only appeared on 2.6.19-rc5-mm1, and did not occured on
> 2.6.19-rc4-mm2. I am enclosing my .config and the dmesg output.
> 
> Regards,
> C__dric
> 
> usb 5-4: new high speed USB device using ehci_hcd and address 3
> usb 5-4: new device found, idVendor=067b, idProduct=2507
> usb 5-4: new device strings: Mfr=1, Product=2, SerialNumber=3
> usb 5-4: Product: Mass Storage Device
> usb 5-4: Manufacturer: Prolific Technology Inc.
> usb 5-4: SerialNumber: 0
> usb 5-4: configuration #1 chosen from 1 choice
> usbcore: registered new interface driver libusual
> Initializing USB Mass Storage driver...
> scsi2 : SCSI emulation for USB Mass Storage devices
> usb-storage: device found at 3
> usb-storage: waiting for device to settle before scanning
> usbcore: registered new interface driver usb-storage
> USB Mass Storage support registered.
> scsi 2:0:0:0: Direct-Access     SAMSUNG  SP2514N          VF10 PQ: 0 ANSI: 0
> SCSI device sdb: 488397167 512-byte hdwr sectors (250059 MB)
> sdb: Write Protect is off
> sdb: Mode Sense: 03 00 00 00
> sdb: assuming drive cache: write through
> SCSI device sdb: 488397167 512-byte hdwr sectors (250059 MB)
> sdb: Write Protect is off
> sdb: Mode Sense: 03 00 00 00
> sdb: assuming drive cache: write through
>  sdb: sdb1
> sd 2:0:0:0: Attached scsi disk sdb
> usb-storage: device scan complete
> usb 5-4: USB disconnect, address 3
> BUG: unable to handle kernel paging request at virtual address 00100104
>  printing eip:
> c021c8ef
> *pde = 00000000
> Oops: 0002 [#1]
> last sysfs file: /class/net/lan/carrier
> Modules linked in: nls_iso8859_15 nls_cp850 usb_storage libusual
> radeon drm cpufreq_ondemand thermal fan button processor ac battery
> af_packet vfat fat hdaps pcmcia crc32 irtty_sir sir_dev sr_mod
> nsc_ircc cdrom ipw2200 irda ieee80211 ieee80211_crypt crc_ccitt
> firmware_class snd_intel8x0m snd_intel8x0 snd_ac97_codec snd_ac97_bus
> ehci_hcd snd_pcm_oss snd_mixer_oss snd_pcm snd_timer snd yenta_socket
> rsrc_nonstatic pcmcia_core tg3 rtc uhci_hcd pcspkr i2c_i801 usbcore
> intel_agp agpgart soundcore snd_page_alloc unix
> CPU:    0
> EIP:    0060:[<c021c8ef>]    Not tainted VLI
> EFLAGS: 00010002   (2.6.19-rc5-mm1=porcinet #3)
> EIP is at scsi_device_dev_release_usercontext+0x2f/0xe0
> eax: 00200200   ebx: df970008   ecx: 00100100   edx: df970090
> esi: 00000286   edi: df970000   ebp: dfbe9414   esp: df64bde8
> ds: 007b   es: 007b   ss: 0068
> Process khubd (pid: 1128, ti=df64a000 task=df43fab0 task.ti=df64a000)
> Stack: 00000286 df970264 c03049dc c0304980 dfbe947c c012418b df970090 df9700f8
>        c021ba13 c021c8c0 df970090 df970264 c01ba0d9 df970090 df970110 c01ba100
>        df7fd028 c173ac58 c01bac71 df9700f8 c0212818 df970090 c021281b df970000
> Call Trace:
>  [<c012418b>] execute_in_process_context+0x25/0x55
>  [<c021ba13>] scsi_device_dev_release+0x21/0x25
>  [<c01ba0d9>] kobject_cleanup+0x45/0x6c
>  [<c01bac71>] kref_put+0x80/0x8f
>  [<c01ba091>] kobject_put+0x1e/0x21
>  [<c021b724>] scsi_forget_host+0x26/0x3f
>  [<c0214f94>] scsi_remove_host+0x5e/0xd6
>  [<e0a957b5>] quiesce_and_remove_host+0x75/0x78 [usb_storage]
>  [<e0a95897>] storage_disconnect+0x12/0x1a [usb_storage]
>  [<e08c8416>] usb_unbind_interface+0x35/0x74 [usbcore]
>  [<c020f988>] __device_release_driver+0x88/0xa0
>  [<c020fda3>] device_release_driver+0x24/0x39
>  [<c020f318>] bus_remove_device+0x86/0x9e
>  [<c020dc0e>] device_del+0x15b/0x1cb
>  [<e08c6113>] usb_disable_device+0x72/0xdd [usbcore]
>  [<e08c2ec7>] usb_disconnect+0x9c/0xee [usbcore]
>  [<e08c3af9>] hub_thread+0x30d/0xa13 [usbcore]
>  [<c0126ee3>] kthread+0xb8/0xe1
>  [<c0103873>] kernel_thread_helper+0x7/0x10
> DWARF2 unwinder stuck at kernel_thread_helper+0x7/0x10
> Leftover inexact backtrace:
>  =======================
> Code: 83 ec 04 8b 54 24 18 8b 6a 64 8d ba 70 ff ff ff 8d 45 ec 9c 5e
> fa ff 80 58 01 00 00 8d 9a 78 ff ff ff 8b 43 04 8b 8a 78 ff ff ff <89>
> 41 04 89 08 c7 43 04 00 02 20 00 8d 5a 80 8b 4a 80 8b 43 04
> EIP: [<c021c8ef>] scsi_device_dev_release_usercontext+0x2f/0xe0 SS:ESP
> 0068:df64bde8
> 

Re: 2.6.19-rc5-mm1

[Andrew Morton]

(added linux-scsi)

On Thu, 9 Nov 2006 19:43:17 +0100
"Benoit Boissinot" <bboissin@gmail.com> wrote:

> On 11/8/06, Andrew Morton <akpm@osdl.org> wrote:
> >
> > Temporarily at
> >
> > http://userweb.kernel.org/~akpm/2.6.19-rc5-mm1/
> >
> > will turn up at
> >
> > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.19-rc5/2.6.19-rc5-mm1/
> >
> > when kernel.org mirroring catches up.
> >
> 
> I got the following oops when undocking my laptop:
> 
> [27525.704000] ACPI: undocking
> [27526.076000] usb 3-1: USB disconnect, address 2
> [27526.228000] usb 4-3: USB disconnect, address 2
> [27526.232000] BUG: unable to handle kernel paging request at virtual
> address 00200200
> [27526.232000]  printing eip:
> [27526.232000] e8074e26
> [27526.232000] *pde = 00000000
> [27526.232000] Oops: 0002 [#1]
> [27526.232000] last sysfs file: /class/net/eth0/carrier
> [27526.232000] Modules linked in: af_packet binfmt_misc rfcomm l2cap
> bluetooth ipv6 capability commoncap i915 drm acpi_cpufreq
> cpufreq_userspace cpufreq_stats cpufreq_powersave cpufreq_ondemand
> freq_table cpufreq_conservative video output sr_mod cdrom sbs
> sony_acpi i2c_ec i2c_core button dock battery container ac backlight
> dm_mod md_mod sbp2 lp shpchp pci_hotplug sg usb_storage joydev tsdev
> libusual pcmcia usbhid irda evdev crc_ccitt psmouse serio_raw
> snd_intel8x0 snd_ac97_codec snd_ac97_bus snd_pcm_oss snd_mixer_oss
> ata_generic snd_pcm snd_timer ipw2200 parport_pc parport snd soundcore
> snd_page_alloc intel_agp agpgart pcspkr ieee80211 ieee80211_crypt
> yenta_socket rsrc_nonstatic pcmcia_core tg3 iTCO_wdt rtc ext3 jbd
> mbcache ohci1394 ieee1394 ehci_hcd uhci_hcd usbcore sd_mod ata_piix
> libata scsi_mod thermal processor fan
> [27526.232000] CPU:    0
> [27526.232000] EIP:    0060:[<e8074e26>]    Not tainted VLI
> [27526.232000] EFLAGS: 00010002   (2.6.19-rc5-mm1 #18)
> [27526.232000] EIP is at
> scsi_device_dev_release_usercontext+0x36/0x100 [scsi_mod]
> [27526.232000] eax: e3d88890   ebx: e3d88808   ecx: 00100100   edx: 00200200
> [27526.232000] esi: 00000286   edi: e3d88800   ebp: e45bd014   esp: dfdb1e3c
> [27526.232000] ds: 007b   es: 007b   ss: 0068
> [27526.232000] Process khubd (pid: 1739, ti=dfdb0000 task=dfe4f030
> task.ti=dfdb0000)
> [27526.232000] Stack: e3d88a64 e8074df0 c0374580 e45bd07c c01280e2
> e3d888f8 c03745dc c0233182
> [27526.232000]        c03745dc e3d888f8 c03745dc c0374580 c01d53e9
> e3d88910 c01d5430 e425ec28
> [27526.232000]        ffffffed c01d6065 e3d88890 e425ec28 ffffffed
> e8074667 e425ec00 00000202
> [27526.232000] Call Trace:
> [27526.232000]  [<e8074df0>]
> scsi_device_dev_release_usercontext+0x0/0x100 [scsi_mod]
> [27526.232000]  [execute_in_process_context+34/112]
> execute_in_process_context+0x22/0x70
> [27526.232000]  [device_release+18/112] device_release+0x12/0x70
> [27526.232000]  [kobject_cleanup+73/144] kobject_cleanup+0x49/0x90
> [27526.232000]  [kobject_release+0/16] kobject_release+0x0/0x10
> [27526.232000]  [kref_put+53/160] kref_put+0x35/0xa0
> [27526.232000]  [<e8074667>] __scsi_remove_device+0x67/0x80 [scsi_mod]
> [27526.232000]  [<e8073a33>] scsi_forget_host+0x43/0x50 [scsi_mod]
> [27526.232000]  [<e806c6f2>] scsi_remove_host+0x32/0xb0 [scsi_mod]
> [27526.232000]  [<e83c9c5e>] storage_disconnect+0xe/0x20 [usb_storage]
> [27526.232000]  [<e80e095f>] usb_unbind_interface+0x4f/0xa0 [usbcore]
> [27526.232000]  [__device_release_driver+100/144]
> __device_release_driver+0x64/0x90
> [27526.232000]  [device_release_driver+34/64] device_release_driver+0x22/0x40
> [27526.232000]  [bus_remove_device+92/144] bus_remove_device+0x5c/0x90
> [27526.232000]  [device_del+327/416] device_del+0x147/0x1a0
> [27526.232000]  [<e80ddf78>] usb_disable_device+0x78/0xe0 [usbcore]
> [27526.232000]  [<e80da614>] usb_disconnect+0x94/0xe0 [usbcore]
> [27526.232000]  [<e80db260>] hub_thread+0x200/0xc40 [usbcore]
> [27526.232000]  [autoremove_wake_function+0/80]
> autoremove_wake_function+0x0/0x50
> [27526.232000]  [<e80db060>] hub_thread+0x0/0xc40 [usbcore]
> [27526.232000]  [kthread+169/224] kthread+0xa9/0xe0
> [27526.232000]  [kthread+0/224] kthread+0x0/0xe0
> [27526.232000]  [kernel_thread_helper+7/28] kernel_thread_helper+0x7/0x1c
> [27526.232000]  =======================
> [27526.232000] Code: ff ff 89 1c 24 89 74 24 04 89 6c 24 0c 8b 68 64
> 8d 55 ec 9c 5e fa ff 82 58 01 00 00 8d 98 78 ff ff ff 8b 53 04 8b 88
> 78 ff ff ff <89> 0a 89 51 04 b9 00 01 10 00 c7 43 04 00 02 20 00 8d 58
> 80 8b
> [27526.232000] EIP: [<e8074e26>]
> scsi_device_dev_release_usercontext+0x36/0x100 [scsi_mod] SS:ESP
> 0068:dfdb1e3c
> 
> full dmesg attached, I can test patches and provide any useful
> information if needed (just not now because the dock is at work).

You're the second or third person to report this (to no effect, btw). 
Other reports have been with USB-unplug, so I doubt if the docking code is
involved.

Re: 2.6.19-rc5-mm1

[Mattia Dongili]

On Thu, Nov 09, 2006 at 11:04:53AM -0800, Andrew Morton wrote:
> 
> (added linux-scsi)
[...]
> > [27526.232000] EIP: [<e8074e26>]
> > scsi_device_dev_release_usercontext+0x36/0x100 [scsi_mod] SS:ESP
> > 0068:dfdb1e3c
> > 
> > full dmesg attached, I can test patches and provide any useful
> > information if needed (just not now because the dock is at work).
> 
> You're the second or third person to report this (to no effect, btw). 

oh, great. I was going to report the same (had with usb key unplug).
Linux version 2.6.19-rc5-mm1-1 (mattia@tadamune) (gcc version 4.1.2 20060901 (prerelease) (Debian 4.1.1-13)) #4 SMP Wed Nov 8 22:46:11 CET 2006
...
usb 5-1: new high speed USB device using ehci_hcd and address 8
usb 5-1: new device found, idVendor=0c76, idProduct=0005
usb 5-1: new device strings: Mfr=1, Product=2, SerialNumber=3
usb 5-1: Product: FlashDisk       
usb 5-1: Manufacturer: USBDisk 
usb 5-1: SerialNumber: 0608120154580
usb 5-1: configuration #1 chosen from 1 choice
scsi3 : SCSI emulation for USB Mass Storage devices
usb-storage: device found at 8
usb-storage: waiting for device to settle before scanning
scsi 3:0:0:0: Direct-Access     USBDisk  FlashDisk        1.00 PQ: 0 ANSI: 2
SCSI device sdc: 2002000 512-byte hdwr sectors (1025 MB)
sdc: Write Protect is off
sdc: Mode Sense: 0b 00 00 08
sdc: assuming drive cache: write through
SCSI device sdc: 2002000 512-byte hdwr sectors (1025 MB)
sdc: Write Protect is off
sdc: Mode Sense: 0b 00 00 08
sdc: assuming drive cache: write through
 sdc: sdc1
sd 3:0:0:0: Attached scsi removable disk sdc
usb-storage: device scan complete
usb 5-1: USB disconnect, address 8
BUG: unable to handle kernel paging request at virtual address 00100104
 printing eip:
c024831f
*pde = 00000000
Oops: 0002 [#1]
SMP 
last sysfs file: /devices/pci0000:00/0000:00:1d.7/usb5/5-1/idVendor
Modules linked in: ipv6 cpufreq_ondemand acpi_cpufreq freq_table thermal fan button processor ac battery ipt_MASQUERADE iptable_nat ip_nat xt_tcpudp xt_state ip_conntrack nfnetlink iptable_filter ip_tables x_tables usbhid hci_usb bluetooth dm_snapshot dm_mirror dm_mod sbp2 loop eth1394 usb_storage pcmcia snd_hda_intel snd_hda_codec snd_pcm_oss snd_mixer_oss ipw3945 tpm_infineon tpm ieee80211 ieee80211_crypt yenta_socket i2c_i801 ide_cd ohci1394 firmware_class intel_agp agpgart tpm_bios pcspkr ehci_hcd evdev sky2 ieee1394 uhci_hcd rsrc_nonstatic tifm_7xx1 tifm_core snd_pcm rtc psmouse pcmcia_core snd_timer usbcore snd soundcore snd_page_alloc cdrom
CPU:    0
EIP:    0060:[<c024831f>]    Not tainted VLI
EFLAGS: 00010002   (2.6.19-rc5-mm1-1 #4)
EIP is at scsi_device_dev_release_usercontext+0x41/0xfa
eax: 00200200   ebx: f7824094   ecx: 00100100   edx: 00000286
esi: f7824008   edi: f7824000   ebp: f78bddc0   esp: f78bddb0
ds: 007b   es: 007b   ss: 0068
Process khubd (pid: 756, ti=f78bc000 task=c1990a70 task.ti=f78bc000)
Stack: f7f05014 f7824284 c02482de c032e6e0 f78bddd0 c012d897 f782410c c032e748 
       f78bddd8 c024754d f78bddf0 c022f74d c01d1b6e f782410c c032e748 c032e6e0 
       f78bde08 c01d1b54 f7f0508c f7824124 c01d1b74 00000246 f78bde10 c01d1b7f 
Call Trace:
 [<c012d897>] execute_in_process_context+0x1d/0x4e
 [<c024754d>] scsi_device_dev_release+0x15/0x17
 [<c022f74d>] device_release+0x29/0x6b
 [<c01d1b54>] kobject_cleanup+0x46/0x66
 [<c01d1b7f>] kobject_release+0xb/0xd
 [<c01d263b>] kref_put+0x7f/0x90
 [<c01d1b0c>] kobject_put+0x14/0x16
 [<c022f829>] put_device+0xf/0x11
 [<c0247c49>] __scsi_remove_device+0x5e/0x62
 [<c02458cc>] scsi_forget_host+0x30/0x4f
 [<c02410c5>] scsi_remove_host+0x6a/0xdd
 [<f8e3f6c7>] quiesce_and_remove_host+0x8f/0x94 [usb_storage]
 [<f8e3f789>] storage_disconnect+0x11/0x1b [usb_storage]
 [<f8d338c2>] usb_unbind_interface+0x4c/0x94 [usbcore]
 [<c02314c7>] __device_release_driver+0x71/0x86
 [<c0231895>] device_release_driver+0x26/0x3d
 [<c0230f29>] bus_remove_device+0x5e/0x6c
 [<c022fbd2>] device_del+0x104/0x15a
 [<f8d314a8>] usb_disable_device+0x5f/0xbc [usbcore]
 [<f8d2e1be>] usb_disconnect+0x8b/0xe7 [usbcore]
 [<f8d2edd5>] hub_thread+0x397/0xa50 [usbcore]
 [<c01307e2>] kthread+0xb5/0xdf
 [<c0103a0f>] kernel_thread_helper+0x7/0x10
DWARF2 unwinder stuck at kernel_thread_helper+0x7/0x10
Leftover inexact backtrace:
 [<c0103ee9>] show_trace_log_lvl+0x1a/0x2f
 [<c0103f9b>] show_stack_log_lvl+0x9d/0xa5
 [<c0104168>] show_registers+0x1c5/0x29b
 [<c0104354>] die+0x116/0x22e
 [<c0117c57>] do_page_fault+0x446/0x51f
 [<c02c5a4c>] error_code+0x7c/0x84
 [<c012d897>] execute_in_process_context+0x1d/0x4e
 [<c024754d>] scsi_device_dev_release+0x15/0x17
 [<c022f74d>] device_release+0x29/0x6b
 [<c01d1b54>] kobject_cleanup+0x46/0x66
 [<c01d1b7f>] kobject_release+0xb/0xd
 [<c01d263b>] kref_put+0x7f/0x90
 [<c01d1b0c>] kobject_put+0x14/0x16
 [<c022f829>] put_device+0xf/0x11
 [<c0247c49>] __scsi_remove_device+0x5e/0x62
 [<c02458cc>] scsi_forget_host+0x30/0x4f
 [<c02410c5>] scsi_remove_host+0x6a/0xdd
 [<f8e3f6c7>] quiesce_and_remove_host+0x8f/0x94 [usb_storage]
 [<f8e3f789>] storage_disconnect+0x11/0x1b [usb_storage]
 [<f8d338c2>] usb_unbind_interface+0x4c/0x94 [usbcore]
 [<c02314c7>] __device_release_driver+0x71/0x86
 [<c0231895>] device_release_driver+0x26/0x3d
 [<c0230f29>] bus_remove_device+0x5e/0x6c
 [<c022fbd2>] device_del+0x104/0x15a
 [<f8d314a8>] usb_disable_device+0x5f/0xbc [usbcore]
 [<f8d2e1be>] usb_disconnect+0x8b/0xe7 [usbcore]
 [<f8d2edd5>] hub_thread+0x397/0xa50 [usbcore]
 [<c01307e2>] kthread+0xb5/0xdf
 [<c0103a0f>] kernel_thread_helper+0x7/0x10
 =======================
Code: f0 89 c6 8b 83 6c ff ff ff 83 ee 14 8b 40 2c e8 b5 d4 07 00 ff 86 70 01 00 00 8d b3 74 ff ff ff 8b 8b 74 ff ff ff 89 c2 8b 46 04 <89> 41 04 89 08 c7 46 04 00 02 20 00 8d b3 7c ff ff ff 8b 8b 7c 
EIP: [<c024831f>] scsi_device_dev_release_usercontext+0x41/0xfa SS:ESP 0068:f78bddb0
 

> Other reports have been with USB-unplug, so I doubt if the docking code is
> involved.

full dmesg is here:
http://oioio.altervista.org/linux/dmesg_usbkey_remove
and .config:
http://oioio.altervista.org/linux/config-2.6.19-rc5-mm1-1

-- 
mattia
:wq!

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Re: 2.6.19-rc5-mm1

[Alan Stern]

On Thu, 9 Nov 2006, Mattia Dongili wrote:

> On Thu, Nov 09, 2006 at 11:04:53AM -0800, Andrew Morton wrote:
> > 
> > (added linux-scsi)
> [...]
> > > [27526.232000] EIP: [<e8074e26>]
> > > scsi_device_dev_release_usercontext+0x36/0x100 [scsi_mod] SS:ESP
> > > 0068:dfdb1e3c
> > > 
> > > full dmesg attached, I can test patches and provide any useful
> > > information if needed (just not now because the dock is at work).
> > 
> > You're the second or third person to report this (to no effect, btw). 
> 
> oh, great. I was going to report the same (had with usb key unplug).
> Linux version 2.6.19-rc5-mm1-1 (mattia@tadamune) (gcc version 4.1.2 20060901 (prerelease) (Debian 4.1.1-13)) #4 SMP Wed Nov 8 22:46:11 CET 2006

I don't know exactly where the problem lies, but I have narrowed it down.

In drivers/scsi/sd.c:sd_probe(), the call to add_disk() increases the 
device's refcount by 1.  However in sd_remove(), the call to del_gendisk() 
decreases the device's refcount by 2.  Consequently the structure is 
deallocated too early, causing the oops.

Somebody who knows more than I do about add_disk() and del_gendisk() will 
have to figure what's going wrong.

Alan Stern


-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Re: 2.6.19-rc5-mm1

[Andrew Morton]

On Thu, 9 Nov 2006 16:58:31 -0500 (EST)
Alan Stern <stern@rowland.harvard.edu> wrote:

> On Thu, 9 Nov 2006, Mattia Dongili wrote:
> 
> > On Thu, Nov 09, 2006 at 11:04:53AM -0800, Andrew Morton wrote:
> > > 
> > > (added linux-scsi)
> > [...]
> > > > [27526.232000] EIP: [<e8074e26>]
> > > > scsi_device_dev_release_usercontext+0x36/0x100 [scsi_mod] SS:ESP
> > > > 0068:dfdb1e3c
> > > > 
> > > > full dmesg attached, I can test patches and provide any useful
> > > > information if needed (just not now because the dock is at work).
> > > 
> > > You're the second or third person to report this (to no effect, btw). 
> > 
> > oh, great. I was going to report the same (had with usb key unplug).
> > Linux version 2.6.19-rc5-mm1-1 (mattia@tadamune) (gcc version 4.1.2 20060901 (prerelease) (Debian 4.1.1-13)) #4 SMP Wed Nov 8 22:46:11 CET 2006
> 
> I don't know exactly where the problem lies, but I have narrowed it down.
> 
> In drivers/scsi/sd.c:sd_probe(), the call to add_disk() increases the 
> device's refcount by 1.  However in sd_remove(), the call to del_gendisk() 
> decreases the device's refcount by 2.  Consequently the structure is 
> deallocated too early, causing the oops.
> 
> Somebody who knows more than I do about add_disk() and del_gendisk() will 
> have to figure what's going wrong.
> 

hm.  Maybe it's the disk_sysfs_symlinks() changes.

Could someone who can reproduce this please try this revert, on
2.6.19-rc2-mm2 through 2.6.19-rc5-mm1?



 fs/partitions/check.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff -puN fs/partitions/check.c~revert-fix-ide-cs-hang-after-device-removal fs/partitions/check.c
--- a/fs/partitions/check.c~revert-fix-ide-cs-hang-after-device-removal
+++ a/fs/partitions/check.c
@@ -416,7 +416,7 @@ static char *make_block_name(struct gend
 
 static int disk_sysfs_symlinks(struct gendisk *disk)
 {
-	struct device *target = disk->driverfs_dev;
+	struct device *target = get_device(disk->driverfs_dev);
 	int err;
 	char *disk_name = NULL;
 
@@ -452,8 +452,9 @@ err_out_dev_link:
 		sysfs_remove_link(&disk->kobj, "device");
 err_out_disk_name:
 		kfree(disk_name);
-	}
 err_out:
+		put_device(target);
+	}
 	return err;
 }
 
_


-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Re: 2.6.19-rc5-mm1

[Cédric Augonnet]

2006/11/9, Andrew Morton <akpm@osdl.org>:

>
> hm.  Maybe it's the disk_sysfs_symlinks() changes.
>
> Could someone who can reproduce this please try this revert, on
> 2.6.19-rc2-mm2 through 2.6.19-rc5-mm1?
>
>
>
>  fs/partitions/check.c |    5 +++--
>  1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff -puN fs/partitions/check.c~revert-fix-ide-cs-hang-after-device-removal fs/partitions/check.c
> --- a/fs/partitions/check.c~revert-fix-ide-cs-hang-after-device-removal
> +++ a/fs/partitions/check.c
> @@ -416,7 +416,7 @@ static char *make_block_name(struct gend
>
>  static int disk_sysfs_symlinks(struct gendisk *disk)
>  {
> -       struct device *target = disk->driverfs_dev;
> +       struct device *target = get_device(disk->driverfs_dev);
>         int err;
>         char *disk_name = NULL;
>
> @@ -452,8 +452,9 @@ err_out_dev_link:
>                 sysfs_remove_link(&disk->kobj, "device");
>  err_out_disk_name:
>                 kfree(disk_name);
> -       }
>  err_out:
> +               put_device(target);
> +       }
>         return err;
>  }
>
> _
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>

Hi,

This patch seems to be working : whereas i had the same oops as Mattia
each time I unplugged my USB external DD drive, now it does not happen
anymore.
Thank you very much for this one !

Best regards,
Cédric

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Re: 2.6.19-rc5-mm1

[Andrew Morton]

On Fri, 10 Nov 2006 00:39:46 +0100
"C__dric Augonnet" <cedric.augonnet@gmail.com> wrote:

> 2006/11/9, Andrew Morton <akpm@osdl.org>:
> 
> >
> > hm.  Maybe it's the disk_sysfs_symlinks() changes.
> >
> > Could someone who can reproduce this please try this revert, on
> > 2.6.19-rc2-mm2 through 2.6.19-rc5-mm1?
> >
> >
> >
> >  fs/partitions/check.c |    5 +++--
> >  1 files changed, 3 insertions(+), 2 deletions(-)
> >
> > diff -puN fs/partitions/check.c~revert-fix-ide-cs-hang-after-device-removal fs/partitions/check.c
> > --- a/fs/partitions/check.c~revert-fix-ide-cs-hang-after-device-removal
> > +++ a/fs/partitions/check.c
> > @@ -416,7 +416,7 @@ static char *make_block_name(struct gend
> >
> >  static int disk_sysfs_symlinks(struct gendisk *disk)
> >  {
> > -       struct device *target = disk->driverfs_dev;
> > +       struct device *target = get_device(disk->driverfs_dev);
> >         int err;
> >         char *disk_name = NULL;
> >
> > @@ -452,8 +452,9 @@ err_out_dev_link:
> >                 sysfs_remove_link(&disk->kobj, "device");
> >  err_out_disk_name:
> >                 kfree(disk_name);
> > -       }
> >  err_out:
> > +               put_device(target);
> > +       }
> >         return err;
> >  }
> >
> > _
> >
> > -
> > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> > Please read the FAQ at  http://www.tux.org/lkml/
> >
> 
> Hi,
> 
> This patch seems to be working : whereas i had the same oops as Mattia
> each time I unplugged my USB external DD drive, now it does not happen
> anymore.
> Thank you very much for this one !
> 

OK, thanks.  I dropped the patch.  So ide-cs will now start deadlocking
again.


-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Re: [linux-usb-devel] 2.6.19-rc5-mm1

[Anton Vorontsov]

On Thu, Nov 09, 2006 at 04:11:23PM -0800, Andrew Morton wrote:
> On Fri, 10 Nov 2006 00:39:46 +0100
> "C__dric Augonnet" <cedric.augonnet@gmail.com> wrote:
> 
> > 2006/11/9, Andrew Morton <akpm@osdl.org>:
> > 
> > >
> > > hm.  Maybe it's the disk_sysfs_symlinks() changes.
> > >
> > > Could someone who can reproduce this please try this revert, on
> > > 2.6.19-rc2-mm2 through 2.6.19-rc5-mm1?
[...]
> > 
> > Hi,
> > 
> > This patch seems to be working : whereas i had the same oops as Mattia
> > each time I unplugged my USB external DD drive, now it does not happen
> > anymore.
> > Thank you very much for this one !
> > 
> 
> OK, thanks.  I dropped the patch.  So ide-cs will now start deadlocking
> again.

No, it will not. I'm really sorry, mainline was already fixed at
2.6.17-rc5 time by that commit:
http://www.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=1a2acc9e9214699a99389e323e6686e9e0e2ca67

But for some reason handhelds.org kernel tree's block/genhd.c file was
unsynchronized with mainline. I've revealed that only after my patch was
removed and I've started to investigate SCSI oops issue triggered by my
patch.

Resume: mainline do not need my patch, handhelds.org's kernel should be
synchronized with mainline.

-- Anton (irc: bd2)

Re: 2.6.19-rc5-mm1

[Benoit Boissinot]

On Thu, Nov 09, 2006 at 02:51:00PM -0800, Andrew Morton wrote:
> On Thu, 9 Nov 2006 16:58:31 -0500 (EST)
> Alan Stern <stern@rowland.harvard.edu> wrote:
> > On Thu, 9 Nov 2006, Mattia Dongili wrote:
> > > On Thu, Nov 09, 2006 at 11:04:53AM -0800, Andrew Morton wrote:
> > > [...]
> > > > > [27526.232000] EIP: [<e8074e26>]
> > > > > scsi_device_dev_release_usercontext+0x36/0x100 [scsi_mod] SS:ESP
> > > > > 0068:dfdb1e3c
> > > > > 
> > > > > full dmesg attached, I can test patches and provide any useful
> > > > > information if needed (just not now because the dock is at work).
> > > > 
> > > > You're the second or third person to report this (to no effect, btw). 
> > > 
> > > oh, great. I was going to report the same (had with usb key unplug).
> > > Linux version 2.6.19-rc5-mm1-1 (mattia@tadamune) (gcc version 4.1.2 20060901 (prerelease) (Debian 4.1.1-13)) #4 SMP Wed Nov 8 22:46:11 CET 2006
> > 
> > I don't know exactly where the problem lies, but I have narrowed it down.
> > 
> > In drivers/scsi/sd.c:sd_probe(), the call to add_disk() increases the 
> > device's refcount by 1.  However in sd_remove(), the call to del_gendisk() 
> > decreases the device's refcount by 2.  Consequently the structure is 
> > deallocated too early, causing the oops.
> > 
> > Somebody who knows more than I do about add_disk() and del_gendisk() will 
> > have to figure what's going wrong.
> > 
> 
> hm.  Maybe it's the disk_sysfs_symlinks() changes.
> 
> Could someone who can reproduce this please try this revert, on
> 2.6.19-rc2-mm2 through 2.6.19-rc5-mm1?
> 

I confirm it fixes it for me too.

regards,

Benoit

-- 
:wq

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel