* scsi: fix warning in scsi_sysfs.c
@ 2007-07-31 21:35 Lado
2007-07-31 22:39 ` James Bottomley
0 siblings, 1 reply; 2+ messages in thread
From: Lado @ 2007-07-31 21:35 UTC (permalink / raw)
To: scsi
Subject: scsi: fix warning in scsi_sysfs.c
From: Ladislav Penko <lpenko@gmx.de>
change: trivial fix warning (removed unused variable rq)
Signed-off-by: Ladislav Penko <lpenko@gmx.de>
Index: linux/drivers/scsi/scsi_sysfs.c
===================================================================
--- linux.orig/drivers/scsi/scsi_sysfs.c
+++ linux/drivers/scsi/scsi_sysfs.c
@@ -715,7 +715,6 @@ static int attr_add(struct device *dev,
int scsi_sysfs_add_sdev(struct scsi_device *sdev)
{
int error, i;
- struct request_queue *rq = sdev->request_queue;
if ((error = scsi_device_set_state(sdev, SDEV_RUNNING)) != 0)
return error;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: scsi: fix warning in scsi_sysfs.c
2007-07-31 21:35 scsi: fix warning in scsi_sysfs.c Lado
@ 2007-07-31 22:39 ` James Bottomley
0 siblings, 0 replies; 2+ messages in thread
From: James Bottomley @ 2007-07-31 22:39 UTC (permalink / raw)
To: Lado; +Cc: scsi
On Tue, 2007-07-31 at 23:35 +0200, Lado wrote:
> Subject: scsi: fix warning in scsi_sysfs.c
>
> From: Ladislav Penko <lpenko@gmx.de>
>
> change: trivial fix warning (removed unused variable rq)
>
> Signed-off-by: Ladislav Penko <lpenko@gmx.de>
The trivial fixes aren't always the best. In this case, if you set
CONFIG_BLK_DEV_BSG=y you'll find the compile breaks with this fix. The
correct fix should already be upstream by now.
James
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-07-31 22:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-07-31 21:35 scsi: fix warning in scsi_sysfs.c Lado
2007-07-31 22:39 ` James Bottomley
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox