public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: andrew.vasquez@qlogic.com
Cc: joy@entuzijast.net, sparclinux@vger.kernel.org,
	linux-scsi@vger.kernel.org
Subject: Re: kernel 2.6.26.3 qla2xxx oopsing on Fire 280R
Date: Mon, 08 Sep 2008 16:08:20 -0700 (PDT)	[thread overview]
Message-ID: <20080908.160820.20152853.davem@davemloft.net> (raw)
In-Reply-To: <20080908214932.GF22598@plap4-2.qlogic.org>

From: Andrew Vasquez <andrew.vasquez@qlogic.com>
Date: Mon, 8 Sep 2008 14:49:32 -0700

> Hmm...  Still looking...

Look at how the driver registers the IRQ handler before the host has
been registered with the SCSI layer.

That leads to a window of time where the shost hasn't been setup
fully, yet ISRs can come in and trigger DPC thread events, such as
loop resyncs, which expect the transport area to be setup.

But it won't be setup, because scsi_add_host() hasn't finished yet.

Note that in Josip's crash log, we don't even see the

	qla_printk(KERN_INFO, ha, "\n"
	    " QLogic Fibre Channel HBA Driver: %s\n"
	    "  QLogic %s - %s\n"
	    "  ISP%04X: %s @ %s hdma%c, host#=%ld, fw=%s\n",
 ...

message yet.

Which means that the crash occurs between qla2x00_request_irqs()
and printing that message.


  reply	other threads:[~2008-09-08 23:08 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-04  9:39 kernel 2.6.26.3 qla2xxx oopsing on Fire 280R Josip Rodin
2008-09-08 21:13 ` Andrew Vasquez
2008-09-08 21:23   ` David Miller
2008-09-08 21:49     ` Andrew Vasquez
2008-09-08 23:08       ` David Miller [this message]
2008-09-08 23:42         ` Josip Rodin
2008-09-09  1:35         ` Andrew Vasquez
2008-09-09  1:49           ` Josip Rodin
2008-09-09  1:53   ` Josip Rodin
2008-09-09  2:01     ` Andrew Vasquez
2008-09-09 14:39       ` Josip Rodin
2008-09-09 15:00         ` Josip Rodin
2008-09-09 21:30           ` David Miller
2008-09-09 22:00             ` Josip Rodin
2008-09-09 22:57               ` David Miller
2008-09-09 22:59                 ` David Miller
2008-09-10  0:05                   ` Josip Rodin
2008-09-10  0:30                     ` David Miller
2008-09-11 11:37         ` Josip Rodin
2008-09-11 21:57           ` Josip Rodin
2008-09-11 22:01             ` David Miller
2008-09-11 22:15               ` Andrew Vasquez
2008-09-12  5:19                 ` [PATCH scsi-rc-fixes] qla2xxx: Defer enablement of RISC interrupts until ISP initialization completes Andrew Vasquez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080908.160820.20152853.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=andrew.vasquez@qlogic.com \
    --cc=joy@entuzijast.net \
    --cc=linux-scsi@vger.kernel.org \
    --cc=sparclinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox