From: Andrew Vasquez <andrew.vasquez@qlogic.com>
To: Josip Rodin <joy@entuzijast.net>
Cc: sparclinux@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: kernel 2.6.26.3 qla2xxx oopsing on Fire 280R
Date: Mon, 8 Sep 2008 19:01:02 -0700 [thread overview]
Message-ID: <20080909020102.GE25591@plap4-2.qlogic.org> (raw)
In-Reply-To: <20080909015321.GA14147@orion.carnet.hr>
On Tue, 09 Sep 2008, Josip Rodin wrote:
> On Mon, Sep 08, 2008 at 02:13:31PM -0700, Andrew Vasquez wrote:
> > Since we have know good and bad points, could you possibly git-bisect this
> > to help troubleshoot? Also, are you seeing similar problems with Linus'
> > latest tree?
>
> OK, I've bisected it on the Linus tree (all these near-full recompiles take
> time...) and this is the result:
>
> % git bisect good
> bed475c4cde5d12f537f445bdd0a5a3bb5684481 is first bad commit
> commit bed475c4cde5d12f537f445bdd0a5a3bb5684481
> Author: Andrew Vasquez <andrew.vasquez@qlogic.com>
> Date: Wed Aug 13 21:36:58 2008 -0700
>
> [SCSI] qla2xxx: Don't leak SG-DMA mappings while aborting commands.
>
> Original code inadvertently cleared an SRB's 'flags' while
> aborting; causing a follow-on scsi_dma_unmap() to be potentially
> missed.
>
> Signed-off-by: Andrew Vasquez <andrew.vasquez@qlogic.com>
> Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
>
> :040000 040000 51f314385c1a5fae8af021a73c65904d9777d684 d4c20c01bc7c5bce15f81b90fc42621aa592b295 M drivers
>
> % git bisect log
> git-bisect start 'drivers/scsi/qla2xxx'
> # good: [20b8df8e5501bac243e64c0c8c52907735a0041b] Linux 2.6.25
> git-bisect good 20b8df8e5501bac243e64c0c8c52907735a0041b
> # bad: [7686ad5606f08d9dfb33a2087a36c8366366015b] Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input
> git-bisect bad 7686ad5606f08d9dfb33a2087a36c8366366015b
> # good: [6c2f527cb84cbd7d2d8a668c979e70bf78980ccc] [SCSI] qla2xxx: Convert vport_sem to a mutex
> git-bisect good 6c2f527cb84cbd7d2d8a668c979e70bf78980ccc
> # good: [da57bf8f25faf97308d9f4d0b87e8b69317a2fdf] [SCSI] qla2xxx: Correct vport management of MBA_PORT_UPDATE.
> git-bisect good da57bf8f25faf97308d9f4d0b87e8b69317a2fdf
> # good: [bf6583b5831d3195c45f98ec3016499389cbe18f] [SCSI] qla2xxx: suppress uninitialized-var warning
> git-bisect good bf6583b5831d3195c45f98ec3016499389cbe18f
> # bad: [bed475c4cde5d12f537f445bdd0a5a3bb5684481] [SCSI] qla2xxx: Don't leak SG-DMA mappings while aborting commands.
> git-bisect bad bed475c4cde5d12f537f445bdd0a5a3bb5684481
> # good: [00eabe7c4478f38b42d632763c4878ced5a1f25c] [SCSI] qla2xxx: fix msleep compile error
> git-bisect good 00eabe7c4478f38b42d632763c4878ced5a1f25c
> # good: [a7a28504bfa61dc6caa495f55c52623d10b42b32] [SCSI] qla2xxx: Correct vport-state management issues during ISP-ABORT.
> git-bisect good a7a28504bfa61dc6caa495f55c52623d10b42b32
>
> Let me know if you still want me to try that other patch...
Yes, please do try the patch. Could you also enable error-logging via
the ql2xextended_error_logging module parameter:
# insmod qla2xxx.ko ql2xextended_error_logging=1
And send the kernel messages... Thanks, AV
next prev parent reply other threads:[~2008-09-09 2:01 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-04 9:39 kernel 2.6.26.3 qla2xxx oopsing on Fire 280R Josip Rodin
2008-09-08 21:13 ` Andrew Vasquez
2008-09-08 21:23 ` David Miller
2008-09-08 21:49 ` Andrew Vasquez
2008-09-08 23:08 ` David Miller
2008-09-08 23:42 ` Josip Rodin
2008-09-09 1:35 ` Andrew Vasquez
2008-09-09 1:49 ` Josip Rodin
2008-09-09 1:53 ` Josip Rodin
2008-09-09 2:01 ` Andrew Vasquez [this message]
2008-09-09 14:39 ` Josip Rodin
2008-09-09 15:00 ` Josip Rodin
2008-09-09 21:30 ` David Miller
2008-09-09 22:00 ` Josip Rodin
2008-09-09 22:57 ` David Miller
2008-09-09 22:59 ` David Miller
2008-09-10 0:05 ` Josip Rodin
2008-09-10 0:30 ` David Miller
2008-09-11 11:37 ` Josip Rodin
2008-09-11 21:57 ` Josip Rodin
2008-09-11 22:01 ` David Miller
2008-09-11 22:15 ` Andrew Vasquez
2008-09-12 5:19 ` [PATCH scsi-rc-fixes] qla2xxx: Defer enablement of RISC interrupts until ISP initialization completes Andrew Vasquez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080909020102.GE25591@plap4-2.qlogic.org \
--to=andrew.vasquez@qlogic.com \
--cc=joy@entuzijast.net \
--cc=linux-scsi@vger.kernel.org \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox