public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Chandra Seetharaman <sekharan@us.ibm.com>
To: linux-scsi@vger.kernel.org
Cc: Chandra Seetharaman <sekharan@us.ibm.com>,
	pjones@redhat.com, michaelc@cs.wisc.edu,
	James.Bottomley@HansenPartnership.com
Subject: [PATCH 3/3] scsi_dh: Workaround a race condition in module insertion
Date: Tue, 17 Mar 2009 18:36:33 -0700	[thread overview]
Message-ID: <20090318013633.26548.94042.sendpatchset@chandra-ubuntu> (raw)
In-Reply-To: <20090318013615.26548.36303.sendpatchset@chandra-ubuntu>

From: Chandra Seetharaman <sekharan@us.ibm.com>

scsi_dh odule is getting inserted as soon as the first device is seen.
But, the first device is not seen by the module as we were past the 
ADD_DEVICE handling in the module.

Catch the first device by handling BUS_NOTIFY_BOUND_DRIVER event,
and not handle that event for any of the future devices (as they would
have been handled by ADD_DEVICE event).

Signed-off-by: Chandra Seetharaman <sekharan@us.ibm.com>
Signed-off-by: Peter Jones <pjones@redhat.com>

---
 drivers/scsi/device_handler/scsi_dh.c |   11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

Index: linux-2.6.28/drivers/scsi/device_handler/scsi_dh.c
===================================================================
--- linux-2.6.28.orig/drivers/scsi/device_handler/scsi_dh.c
+++ linux-2.6.28/drivers/scsi/device_handler/scsi_dh.c
@@ -294,7 +294,16 @@ static int scsi_dh_notifier(struct notif
 
 	sdev = to_scsi_device(dev);
 
-	if (action == BUS_NOTIFY_ADD_DEVICE) {
+	if ((action == BUS_NOTIFY_ADD_DEVICE) ||
+			(action == BUS_NOTIFY_BOUND_DRIVER)) {
+		/*
+		 * This can happen if device was configured already
+		 * with BUS_NOTIFY_ADD_DEVICE and we are called
+		 * now with BUS_NOTIFY_BOUND_DRIVER
+		 */
+		if (sdev->scsi_dh_data)
+			goto out;
+
 		devinfo = device_handler_match(NULL, sdev);
 		if (!devinfo)
 			goto out;

  parent reply	other threads:[~2009-03-18  1:33 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-18  1:36 [PATCH 0/3] scsi_dh: Make scsi device handler modules automatically inserted Chandra Seetharaman
2009-03-18  1:36 ` [PATCH 1/3] scsi_dh: Add modalias support for SCSI targets Chandra Seetharaman
2009-03-18 13:44   ` Konrad Rzeszutek
2009-03-18 14:02     ` James Bottomley
2009-03-18 14:36       ` Konrad Rzeszutek
2009-03-18 18:30   ` Kay Sievers
2009-03-18 19:18     ` Chandra Seetharaman
2009-03-19 18:54       ` Chandra Seetharaman
2009-03-20 18:24         ` Peter Jones
2009-03-23 22:13           ` Chandra Seetharaman
2009-04-03 22:43             ` Chandra Seetharaman
2009-04-07 20:59               ` James Bottomley
2009-04-07 23:41                 ` Chandra Seetharaman
2009-04-08 15:08                 ` Peter Jones
2009-04-15 21:52                   ` Chandra Seetharaman
2009-04-16 15:18                     ` Hannes Reinecke
2009-04-07 23:22               ` Hannes Reinecke
2009-04-07 23:50                 ` Chandra Seetharaman
2009-04-08  5:15                   ` Kay Sievers
2009-04-08 19:13                     ` Chandra Seetharaman
2009-03-18 18:47   ` James Bottomley
2009-03-18 19:12     ` Chandra Seetharaman
2009-03-18 20:09       ` James Bottomley
2009-03-18 20:24         ` Kay Sievers
2009-03-18 20:26           ` James Bottomley
2009-03-18 20:59         ` Chandra Seetharaman
2009-03-20 17:41         ` Peter Jones
2009-03-18  1:36 ` [PATCH 2/3] scsi_dh: Change scsi device handler modules to utilize modalias Chandra Seetharaman
2009-03-18 13:46   ` Konrad Rzeszutek
2009-03-18 15:43     ` Stefan Richter
2009-03-18 17:25       ` Chandra Seetharaman
2009-03-18 17:50         ` Stefan Richter
2009-03-18 18:18           ` Kay Sievers
2009-03-18 19:44             ` Stefan Richter
2009-03-18 18:50           ` Chandra Seetharaman
2009-03-18 19:46             ` Stefan Richter
2009-03-18  1:36 ` Chandra Seetharaman [this message]
2009-03-18 11:31 ` [PATCH 0/3] scsi_dh: Make scsi device handler modules automatically inserted Hannes Reinecke
  -- strict thread matches above, loose matches on Subject: below --
2009-04-27 18:06 Chandra Seetharaman
2009-04-27 18:06 ` [PATCH 3/3] scsi_dh: Workaround a race condition in module insertion Chandra Seetharaman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090318013633.26548.94042.sendpatchset@chandra-ubuntu \
    --to=sekharan@us.ibm.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=michaelc@cs.wisc.edu \
    --cc=pjones@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox