* [patch] [SCSI] libosd: remover duplicate __bitwise annotation
@ 2013-04-17 7:19 Dan Carpenter
2013-04-17 8:32 ` [osd-dev] " Benny Halevy
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2013-04-17 7:19 UTC (permalink / raw)
To: Boaz Harrosh
Cc: Benny Halevy, James E.J. Bottomley, osd-dev, linux-scsi,
kernel-janitors
__be32 is already a __bitwise type so we don't need the second __bitwise
here. It causes a Sparse error:
include/scsi/osd_protocol.h:110:26: error: invalid modifier
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/include/scsi/osd_protocol.h b/include/scsi/osd_protocol.h
index a6026da..25ac628 100644
--- a/include/scsi/osd_protocol.h
+++ b/include/scsi/osd_protocol.h
@@ -107,7 +107,7 @@ enum osd_attributes_mode {
* int exponent: 04;
* }
*/
-typedef __be32 __bitwise osd_cdb_offset;
+typedef __be32 osd_cdb_offset;
enum {
OSD_OFFSET_UNUSED = 0xFFFFFFFF,
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [osd-dev] [patch] [SCSI] libosd: remover duplicate __bitwise annotation
2013-04-17 7:19 [patch] [SCSI] libosd: remover duplicate __bitwise annotation Dan Carpenter
@ 2013-04-17 8:32 ` Benny Halevy
0 siblings, 0 replies; 2+ messages in thread
From: Benny Halevy @ 2013-04-17 8:32 UTC (permalink / raw)
To: Dan Carpenter
Cc: Boaz Harrosh, kernel-janitors, osd-dev, James E.J. Bottomley,
linux-scsi
On 2013-04-17 10:19, Dan Carpenter wrote:
> __be32 is already a __bitwise type so we don't need the second __bitwise
> here. It causes a Sparse error:
> include/scsi/osd_protocol.h:110:26: error: invalid modifier
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
ACK
>
> diff --git a/include/scsi/osd_protocol.h b/include/scsi/osd_protocol.h
> index a6026da..25ac628 100644
> --- a/include/scsi/osd_protocol.h
> +++ b/include/scsi/osd_protocol.h
> @@ -107,7 +107,7 @@ enum osd_attributes_mode {
> * int exponent: 04;
> * }
> */
> -typedef __be32 __bitwise osd_cdb_offset;
> +typedef __be32 osd_cdb_offset;
>
> enum {
> OSD_OFFSET_UNUSED = 0xFFFFFFFF,
> _______________________________________________
> osd-dev mailing list
> osd-dev@open-osd.org
> http://mailman.open-osd.org/mailman/listinfo/osd-dev
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-04-17 8:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-17 7:19 [patch] [SCSI] libosd: remover duplicate __bitwise annotation Dan Carpenter
2013-04-17 8:32 ` [osd-dev] " Benny Halevy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox