* [PATCH] [SCSI] FlashPoint: fix build warning
@ 2015-09-16 14:06 Sudip Mukherjee
2015-09-16 14:47 ` Khalid Aziz
0 siblings, 1 reply; 3+ messages in thread
From: Sudip Mukherjee @ 2015-09-16 14:06 UTC (permalink / raw)
To: Khalid Aziz, James E.J. Bottomley
Cc: linux-kernel, linux-scsi, Sudip Mukherjee
We have been getting a warning about non ANSI function.
warning: non-ANSI function declaration of function 'FPT_SccbMgrTableInitAll'
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---
drivers/scsi/FlashPoint.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/FlashPoint.c b/drivers/scsi/FlashPoint.c
index 5c74e4c..867b864 100644
--- a/drivers/scsi/FlashPoint.c
+++ b/drivers/scsi/FlashPoint.c
@@ -2136,7 +2136,7 @@ static unsigned char FPT_SccbMgr_bad_isr(u32 p_port, unsigned char p_card,
*
*---------------------------------------------------------------------*/
-static void FPT_SccbMgrTableInitAll()
+static void FPT_SccbMgrTableInitAll(void)
{
unsigned char thisCard;
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] [SCSI] FlashPoint: fix build warning
2015-09-16 14:06 [PATCH] [SCSI] FlashPoint: fix build warning Sudip Mukherjee
@ 2015-09-16 14:47 ` Khalid Aziz
2015-10-02 8:01 ` Sudip Mukherjee
0 siblings, 1 reply; 3+ messages in thread
From: Khalid Aziz @ 2015-09-16 14:47 UTC (permalink / raw)
To: Sudip Mukherjee, James E.J. Bottomley; +Cc: linux-kernel, linux-scsi
On 09/16/2015 08:06 AM, Sudip Mukherjee wrote:
> We have been getting a warning about non ANSI function.
> warning: non-ANSI function declaration of function 'FPT_SccbMgrTableInitAll'
>
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> ---
> drivers/scsi/FlashPoint.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/FlashPoint.c b/drivers/scsi/FlashPoint.c
> index 5c74e4c..867b864 100644
> --- a/drivers/scsi/FlashPoint.c
> +++ b/drivers/scsi/FlashPoint.c
> @@ -2136,7 +2136,7 @@ static unsigned char FPT_SccbMgr_bad_isr(u32 p_port, unsigned char p_card,
> *
> *---------------------------------------------------------------------*/
>
> -static void FPT_SccbMgrTableInitAll()
> +static void FPT_SccbMgrTableInitAll(void)
> {
> unsigned char thisCard;
>
>
Acked-by: Khalid Aziz <khalid@gonehiking.org>
James, please apply this to your SCSI tree.
--
Khalid
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] [SCSI] FlashPoint: fix build warning
2015-09-16 14:47 ` Khalid Aziz
@ 2015-10-02 8:01 ` Sudip Mukherjee
0 siblings, 0 replies; 3+ messages in thread
From: Sudip Mukherjee @ 2015-10-02 8:01 UTC (permalink / raw)
To: Khalid Aziz; +Cc: James E.J. Bottomley, linux-kernel, linux-scsi
On Wed, Sep 16, 2015 at 08:47:43AM -0600, Khalid Aziz wrote:
> On 09/16/2015 08:06 AM, Sudip Mukherjee wrote:
> >We have been getting a warning about non ANSI function.
> >warning: non-ANSI function declaration of function 'FPT_SccbMgrTableInitAll'
> >
> >Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> >---
> > drivers/scsi/FlashPoint.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/drivers/scsi/FlashPoint.c b/drivers/scsi/FlashPoint.c
> >index 5c74e4c..867b864 100644
> >--- a/drivers/scsi/FlashPoint.c
> >+++ b/drivers/scsi/FlashPoint.c
> >@@ -2136,7 +2136,7 @@ static unsigned char FPT_SccbMgr_bad_isr(u32 p_port, unsigned char p_card,
> > *
> > *---------------------------------------------------------------------*/
> >
> >-static void FPT_SccbMgrTableInitAll()
> >+static void FPT_SccbMgrTableInitAll(void)
> > {
> > unsigned char thisCard;
> >
> >
>
> Acked-by: Khalid Aziz <khalid@gonehiking.org>
>
> James, please apply this to your SCSI tree.
Hi James,
A gentle reminder that this is waiting to be applied.
regards
sudip
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-10-02 8:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-16 14:06 [PATCH] [SCSI] FlashPoint: fix build warning Sudip Mukherjee
2015-09-16 14:47 ` Khalid Aziz
2015-10-02 8:01 ` Sudip Mukherjee
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox