* [PATCH 01/29] scsi: qla1280: constify pci_device_id.
2017-07-30 8:37 [PATCH 00/29] constify scsi pci_device_id Arvind Yadav
@ 2017-07-30 8:37 ` Arvind Yadav
2017-07-30 8:37 ` [PATCH 02/29] scsi: qedi: " Arvind Yadav
` (9 subsequent siblings)
10 siblings, 0 replies; 17+ messages in thread
From: Arvind Yadav @ 2017-07-30 8:37 UTC (permalink / raw)
To: martin.petersen, jejb, mdr, hare, aacraid, matthew, fthain,
schmitzmic, kashyap.desai, sumit.saxena, gotom, mrochs, yokota,
QLogic-Storage-Upstream, jinpu.wang
Cc: linux-scsi, linux-kernel
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/scsi/qla1280.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/qla1280.c b/drivers/scsi/qla1280.c
index 8a29fb0..265a65b 100644
--- a/drivers/scsi/qla1280.c
+++ b/drivers/scsi/qla1280.c
@@ -537,7 +537,7 @@ struct qla_boards {
};
/* NOTE: the last argument in each entry is used to index ql1280_board_tbl */
-static struct pci_device_id qla1280_pci_tbl[] = {
+static const struct pci_device_id qla1280_pci_tbl[] = {
{PCI_VENDOR_ID_QLOGIC, PCI_DEVICE_ID_QLOGIC_ISP12160,
PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0},
{PCI_VENDOR_ID_QLOGIC, PCI_DEVICE_ID_QLOGIC_ISP1020,
--
2.7.4
^ permalink raw reply related [flat|nested] 17+ messages in thread* [PATCH 02/29] scsi: qedi: constify pci_device_id.
2017-07-30 8:37 [PATCH 00/29] constify scsi pci_device_id Arvind Yadav
2017-07-30 8:37 ` [PATCH 01/29] scsi: qla1280: constify pci_device_id Arvind Yadav
@ 2017-07-30 8:37 ` Arvind Yadav
2017-07-30 8:37 ` [PATCH 03/29] scsi: am53c974: " Arvind Yadav
` (8 subsequent siblings)
10 siblings, 0 replies; 17+ messages in thread
From: Arvind Yadav @ 2017-07-30 8:37 UTC (permalink / raw)
To: martin.petersen, jejb, mdr, hare, aacraid, matthew, fthain,
schmitzmic, kashyap.desai, sumit.saxena, gotom, mrochs, yokota,
QLogic-Storage-Upstream, jinpu.wang
Cc: linux-scsi, linux-kernel
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/scsi/qedi/qedi_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/qedi/qedi_main.c b/drivers/scsi/qedi/qedi_main.c
index 5f5a4ef..3880bf8 100644
--- a/drivers/scsi/qedi/qedi_main.c
+++ b/drivers/scsi/qedi/qedi_main.c
@@ -2004,7 +2004,7 @@ static void qedi_remove(struct pci_dev *pdev)
__qedi_remove(pdev, QEDI_MODE_NORMAL);
}
-static struct pci_device_id qedi_pci_tbl[] = {
+static const struct pci_device_id qedi_pci_tbl[] = {
{ PCI_DEVICE(PCI_VENDOR_ID_QLOGIC, 0x165E) },
{ PCI_DEVICE(PCI_VENDOR_ID_QLOGIC, 0x8084) },
{ 0 },
--
2.7.4
^ permalink raw reply related [flat|nested] 17+ messages in thread* [PATCH 03/29] scsi: am53c974: constify pci_device_id.
2017-07-30 8:37 [PATCH 00/29] constify scsi pci_device_id Arvind Yadav
2017-07-30 8:37 ` [PATCH 01/29] scsi: qla1280: constify pci_device_id Arvind Yadav
2017-07-30 8:37 ` [PATCH 02/29] scsi: qedi: " Arvind Yadav
@ 2017-07-30 8:37 ` Arvind Yadav
2017-07-30 8:37 ` [PATCH 04/29] scsi: pm8001: " Arvind Yadav
` (7 subsequent siblings)
10 siblings, 0 replies; 17+ messages in thread
From: Arvind Yadav @ 2017-07-30 8:37 UTC (permalink / raw)
To: martin.petersen, jejb, mdr, hare, aacraid, matthew, fthain,
schmitzmic, kashyap.desai, sumit.saxena, gotom, mrochs, yokota,
QLogic-Storage-Upstream, jinpu.wang
Cc: linux-scsi, linux-kernel
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/scsi/am53c974.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/am53c974.c b/drivers/scsi/am53c974.c
index beea30e..ffc49d0 100644
--- a/drivers/scsi/am53c974.c
+++ b/drivers/scsi/am53c974.c
@@ -542,7 +542,7 @@ static void pci_esp_remove_one(struct pci_dev *pdev)
scsi_host_put(esp->host);
}
-static struct pci_device_id am53c974_pci_tbl[] = {
+static const struct pci_device_id am53c974_pci_tbl[] = {
{ PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_SCSI,
PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0 },
{ }
--
2.7.4
^ permalink raw reply related [flat|nested] 17+ messages in thread* [PATCH 04/29] scsi: pm8001: constify pci_device_id.
2017-07-30 8:37 [PATCH 00/29] constify scsi pci_device_id Arvind Yadav
` (2 preceding siblings ...)
2017-07-30 8:37 ` [PATCH 03/29] scsi: am53c974: " Arvind Yadav
@ 2017-07-30 8:37 ` Arvind Yadav
2017-07-31 8:10 ` Jinpu Wang
2017-07-30 8:37 ` [PATCH 05/29] scsi: qla4xxx: " Arvind Yadav
` (6 subsequent siblings)
10 siblings, 1 reply; 17+ messages in thread
From: Arvind Yadav @ 2017-07-30 8:37 UTC (permalink / raw)
To: martin.petersen, jejb, mdr, hare, aacraid, matthew, fthain,
schmitzmic, kashyap.desai, sumit.saxena, gotom, mrochs, yokota,
QLogic-Storage-Upstream, jinpu.wang
Cc: linux-scsi, linux-kernel
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/scsi/pm8001/pm8001_init.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/pm8001/pm8001_init.c b/drivers/scsi/pm8001/pm8001_init.c
index 034b2f7..f2757cc 100644
--- a/drivers/scsi/pm8001/pm8001_init.c
+++ b/drivers/scsi/pm8001/pm8001_init.c
@@ -1270,7 +1270,7 @@ static int pm8001_pci_resume(struct pci_dev *pdev)
/* update of pci device, vendor id and driver data with
* unique value for each of the controller
*/
-static struct pci_device_id pm8001_pci_table[] = {
+static const struct pci_device_id pm8001_pci_table[] = {
{ PCI_VDEVICE(PMC_Sierra, 0x8001), chip_8001 },
{ PCI_VDEVICE(PMC_Sierra, 0x8006), chip_8006 },
{ PCI_VDEVICE(ADAPTEC2, 0x8006), chip_8006 },
--
2.7.4
^ permalink raw reply related [flat|nested] 17+ messages in thread* Re: [PATCH 04/29] scsi: pm8001: constify pci_device_id.
2017-07-30 8:37 ` [PATCH 04/29] scsi: pm8001: " Arvind Yadav
@ 2017-07-31 8:10 ` Jinpu Wang
0 siblings, 0 replies; 17+ messages in thread
From: Jinpu Wang @ 2017-07-31 8:10 UTC (permalink / raw)
To: Arvind Yadav
Cc: Martin K. Petersen, James E.J. Bottomley, mdr, Hannes Reinecke,
aacraid, matthew, fthain, schmitzmic, kashyap.desai, sumit.saxena,
gotom, mrochs, yokota, QLogic-Storage-Upstream,
Linux SCSI Mailinglist, linux-kernel@vger.kernel.org
On Sun, Jul 30, 2017 at 10:37 AM, Arvind Yadav
<arvind.yadav.cs@gmail.com> wrote:
> pci_device_id are not supposed to change at runtime. All functions
> working with pci_device_id provided by <linux/pci.h> work with
> const pci_device_id. So mark the non-const structs as const.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
> drivers/scsi/pm8001/pm8001_init.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/pm8001/pm8001_init.c b/drivers/scsi/pm8001/pm8001_init.c
> index 034b2f7..f2757cc 100644
> --- a/drivers/scsi/pm8001/pm8001_init.c
> +++ b/drivers/scsi/pm8001/pm8001_init.c
> @@ -1270,7 +1270,7 @@ static int pm8001_pci_resume(struct pci_dev *pdev)
> /* update of pci device, vendor id and driver data with
> * unique value for each of the controller
> */
> -static struct pci_device_id pm8001_pci_table[] = {
> +static const struct pci_device_id pm8001_pci_table[] = {
> { PCI_VDEVICE(PMC_Sierra, 0x8001), chip_8001 },
> { PCI_VDEVICE(PMC_Sierra, 0x8006), chip_8006 },
> { PCI_VDEVICE(ADAPTEC2, 0x8006), chip_8006 },
> --
> 2.7.4
>
Thanks,
Acked-by: Jack Wang <jinpu.wang@profitbricks.com>
--
Jack Wang
Linux Kernel Developer
^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH 05/29] scsi: qla4xxx: constify pci_device_id.
2017-07-30 8:37 [PATCH 00/29] constify scsi pci_device_id Arvind Yadav
` (3 preceding siblings ...)
2017-07-30 8:37 ` [PATCH 04/29] scsi: pm8001: " Arvind Yadav
@ 2017-07-30 8:37 ` Arvind Yadav
2017-07-30 8:37 ` [PATCH 06/29] scsi: mvsas: " Arvind Yadav
` (5 subsequent siblings)
10 siblings, 0 replies; 17+ messages in thread
From: Arvind Yadav @ 2017-07-30 8:37 UTC (permalink / raw)
To: martin.petersen, jejb, mdr, hare, aacraid, matthew, fthain,
schmitzmic, kashyap.desai, sumit.saxena, gotom, mrochs, yokota,
QLogic-Storage-Upstream, jinpu.wang
Cc: linux-scsi, linux-kernel
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/scsi/qla4xxx/ql4_os.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/qla4xxx/ql4_os.c b/drivers/scsi/qla4xxx/ql4_os.c
index 64c6fa5..41e1027 100644
--- a/drivers/scsi/qla4xxx/ql4_os.c
+++ b/drivers/scsi/qla4xxx/ql4_os.c
@@ -9793,7 +9793,7 @@ static const struct pci_error_handlers qla4xxx_err_handler = {
.resume = qla4xxx_pci_resume,
};
-static struct pci_device_id qla4xxx_pci_tbl[] = {
+static const struct pci_device_id qla4xxx_pci_tbl[] = {
{
.vendor = PCI_VENDOR_ID_QLOGIC,
.device = PCI_DEVICE_ID_QLOGIC_ISP4010,
--
2.7.4
^ permalink raw reply related [flat|nested] 17+ messages in thread* [PATCH 06/29] scsi: mvsas: constify pci_device_id.
2017-07-30 8:37 [PATCH 00/29] constify scsi pci_device_id Arvind Yadav
` (4 preceding siblings ...)
2017-07-30 8:37 ` [PATCH 05/29] scsi: qla4xxx: " Arvind Yadav
@ 2017-07-30 8:37 ` Arvind Yadav
2017-07-30 8:37 ` [PATCH 07/29] scsi: 3w-9xxx: " Arvind Yadav
` (4 subsequent siblings)
10 siblings, 0 replies; 17+ messages in thread
From: Arvind Yadav @ 2017-07-30 8:37 UTC (permalink / raw)
To: martin.petersen, jejb, mdr, hare, aacraid, matthew, fthain,
schmitzmic, kashyap.desai, sumit.saxena, gotom, mrochs, yokota,
QLogic-Storage-Upstream, jinpu.wang
Cc: linux-scsi, linux-kernel
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/scsi/mvsas/mv_init.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/mvsas/mv_init.c b/drivers/scsi/mvsas/mv_init.c
index 4e047b5..552c5a0 100644
--- a/drivers/scsi/mvsas/mv_init.c
+++ b/drivers/scsi/mvsas/mv_init.c
@@ -659,7 +659,7 @@ static void mvs_pci_remove(struct pci_dev *pdev)
return;
}
-static struct pci_device_id mvs_pci_table[] = {
+static const struct pci_device_id mvs_pci_table[] = {
{ PCI_VDEVICE(MARVELL, 0x6320), chip_6320 },
{ PCI_VDEVICE(MARVELL, 0x6340), chip_6440 },
{
--
2.7.4
^ permalink raw reply related [flat|nested] 17+ messages in thread* [PATCH 07/29] scsi: 3w-9xxx: constify pci_device_id.
2017-07-30 8:37 [PATCH 00/29] constify scsi pci_device_id Arvind Yadav
` (5 preceding siblings ...)
2017-07-30 8:37 ` [PATCH 06/29] scsi: mvsas: " Arvind Yadav
@ 2017-07-30 8:37 ` Arvind Yadav
2017-07-30 8:37 ` [PATCH 08/29] scsi: ipr: " Arvind Yadav
` (3 subsequent siblings)
10 siblings, 0 replies; 17+ messages in thread
From: Arvind Yadav @ 2017-07-30 8:37 UTC (permalink / raw)
To: martin.petersen, jejb, mdr, hare, aacraid, matthew, fthain,
schmitzmic, kashyap.desai, sumit.saxena, gotom, mrochs, yokota,
QLogic-Storage-Upstream, jinpu.wang
Cc: linux-scsi, linux-kernel
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/scsi/3w-9xxx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/3w-9xxx.c b/drivers/scsi/3w-9xxx.c
index 00e7968..27fa387 100644
--- a/drivers/scsi/3w-9xxx.c
+++ b/drivers/scsi/3w-9xxx.c
@@ -2274,7 +2274,7 @@ static int twa_resume(struct pci_dev *pdev)
#endif
/* PCI Devices supported by this driver */
-static struct pci_device_id twa_pci_tbl[] = {
+static const struct pci_device_id twa_pci_tbl[] = {
{ PCI_VENDOR_ID_3WARE, PCI_DEVICE_ID_3WARE_9000,
PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0},
{ PCI_VENDOR_ID_3WARE, PCI_DEVICE_ID_3WARE_9550SX,
--
2.7.4
^ permalink raw reply related [flat|nested] 17+ messages in thread* [PATCH 08/29] scsi: ipr: constify pci_device_id.
2017-07-30 8:37 [PATCH 00/29] constify scsi pci_device_id Arvind Yadav
` (6 preceding siblings ...)
2017-07-30 8:37 ` [PATCH 07/29] scsi: 3w-9xxx: " Arvind Yadav
@ 2017-07-30 8:37 ` Arvind Yadav
2017-07-30 8:37 ` [PATCH 09/29] scsi: arcmsr: " Arvind Yadav
` (2 subsequent siblings)
10 siblings, 0 replies; 17+ messages in thread
From: Arvind Yadav @ 2017-07-30 8:37 UTC (permalink / raw)
To: martin.petersen, jejb, mdr, hare, aacraid, matthew, fthain,
schmitzmic, kashyap.desai, sumit.saxena, gotom, mrochs, yokota,
QLogic-Storage-Upstream, jinpu.wang
Cc: linux-scsi, linux-kernel
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/scsi/ipr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/ipr.c b/drivers/scsi/ipr.c
index b0c68d2..edc7030 100644
--- a/drivers/scsi/ipr.c
+++ b/drivers/scsi/ipr.c
@@ -10644,7 +10644,7 @@ static void ipr_shutdown(struct pci_dev *pdev)
}
}
-static struct pci_device_id ipr_pci_table[] = {
+static const struct pci_device_id ipr_pci_table[] = {
{ PCI_VENDOR_ID_MYLEX, PCI_DEVICE_ID_IBM_GEMSTONE,
PCI_VENDOR_ID_IBM, IPR_SUBS_DEV_ID_5702, 0, 0, 0 },
{ PCI_VENDOR_ID_MYLEX, PCI_DEVICE_ID_IBM_GEMSTONE,
--
2.7.4
^ permalink raw reply related [flat|nested] 17+ messages in thread* [PATCH 09/29] scsi: arcmsr: constify pci_device_id.
2017-07-30 8:37 [PATCH 00/29] constify scsi pci_device_id Arvind Yadav
` (7 preceding siblings ...)
2017-07-30 8:37 ` [PATCH 08/29] scsi: ipr: " Arvind Yadav
@ 2017-07-30 8:37 ` Arvind Yadav
2017-07-30 8:37 ` [PATCH 10/29] scsi: dpt_i2o: " Arvind Yadav
2017-07-31 7:56 ` [PATCH 00/29] constify scsi pci_device_id Johannes Thumshirn
10 siblings, 0 replies; 17+ messages in thread
From: Arvind Yadav @ 2017-07-30 8:37 UTC (permalink / raw)
To: martin.petersen, jejb, mdr, hare, aacraid, matthew, fthain,
schmitzmic, kashyap.desai, sumit.saxena, gotom, mrochs, yokota,
QLogic-Storage-Upstream, jinpu.wang
Cc: linux-scsi, linux-kernel
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/scsi/arcmsr/arcmsr_hba.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c
index af032c4..392fb07 100644
--- a/drivers/scsi/arcmsr/arcmsr_hba.c
+++ b/drivers/scsi/arcmsr/arcmsr_hba.c
@@ -141,7 +141,7 @@ static struct scsi_host_template arcmsr_scsi_host_template = {
.no_write_same = 1,
};
-static struct pci_device_id arcmsr_device_id_table[] = {
+static const struct pci_device_id arcmsr_device_id_table[] = {
{PCI_DEVICE(PCI_VENDOR_ID_ARECA, PCI_DEVICE_ID_ARECA_1110),
.driver_data = ACB_ADAPTER_TYPE_A},
{PCI_DEVICE(PCI_VENDOR_ID_ARECA, PCI_DEVICE_ID_ARECA_1120),
--
2.7.4
^ permalink raw reply related [flat|nested] 17+ messages in thread* [PATCH 10/29] scsi: dpt_i2o: constify pci_device_id.
2017-07-30 8:37 [PATCH 00/29] constify scsi pci_device_id Arvind Yadav
` (8 preceding siblings ...)
2017-07-30 8:37 ` [PATCH 09/29] scsi: arcmsr: " Arvind Yadav
@ 2017-07-30 8:37 ` Arvind Yadav
2017-07-31 7:56 ` [PATCH 00/29] constify scsi pci_device_id Johannes Thumshirn
10 siblings, 0 replies; 17+ messages in thread
From: Arvind Yadav @ 2017-07-30 8:37 UTC (permalink / raw)
To: martin.petersen, jejb, mdr, hare, aacraid, matthew, fthain,
schmitzmic, kashyap.desai, sumit.saxena, gotom, mrochs, yokota,
QLogic-Storage-Upstream, jinpu.wang
Cc: linux-scsi, linux-kernel
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/scsi/dpt_i2o.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/dpt_i2o.c b/drivers/scsi/dpt_i2o.c
index 256dd67..ba90cc4 100644
--- a/drivers/scsi/dpt_i2o.c
+++ b/drivers/scsi/dpt_i2o.c
@@ -181,7 +181,7 @@ static u8 adpt_read_blink_led(adpt_hba* host)
*/
#ifdef MODULE
-static struct pci_device_id dptids[] = {
+static const struct pci_device_id dptids[] = {
{ PCI_DPT_VENDOR_ID, PCI_DPT_DEVICE_ID, PCI_ANY_ID, PCI_ANY_ID,},
{ PCI_DPT_VENDOR_ID, PCI_DPT_RAPTOR_DEVICE_ID, PCI_ANY_ID, PCI_ANY_ID,},
{ 0, }
--
2.7.4
^ permalink raw reply related [flat|nested] 17+ messages in thread* Re: [PATCH 00/29] constify scsi pci_device_id.
2017-07-30 8:37 [PATCH 00/29] constify scsi pci_device_id Arvind Yadav
` (9 preceding siblings ...)
2017-07-30 8:37 ` [PATCH 10/29] scsi: dpt_i2o: " Arvind Yadav
@ 2017-07-31 7:56 ` Johannes Thumshirn
2017-07-31 8:53 ` Arvind Yadav
10 siblings, 1 reply; 17+ messages in thread
From: Johannes Thumshirn @ 2017-07-31 7:56 UTC (permalink / raw)
To: Arvind Yadav
Cc: martin.petersen, jejb, mdr, hare, aacraid, matthew, fthain,
schmitzmic, kashyap.desai, sumit.saxena, gotom, mrochs, yokota,
QLogic-Storage-Upstream, jinpu.wang, linux-scsi, linux-kernel
On Sun, Jul 30, 2017 at 02:07:09PM +0530, Arvind Yadav wrote:
> pci_device_id are not supposed to change at runtime. All functions
> working with pci_device_id provided by <linux/pci.h> work with
> const pci_device_id. So mark the non-const structs as const.
Can't this go all in one patch instead of replicating the same patch 29
times?
Thanks,
Johannes
--
Johannes Thumshirn Storage
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: [PATCH 00/29] constify scsi pci_device_id.
2017-07-31 7:56 ` [PATCH 00/29] constify scsi pci_device_id Johannes Thumshirn
@ 2017-07-31 8:53 ` Arvind Yadav
2017-07-31 9:27 ` Johannes Thumshirn
0 siblings, 1 reply; 17+ messages in thread
From: Arvind Yadav @ 2017-07-31 8:53 UTC (permalink / raw)
To: Johannes Thumshirn
Cc: martin.petersen, jejb, mdr, hare, aacraid, matthew, fthain,
schmitzmic, kashyap.desai, sumit.saxena, gotom, mrochs, yokota,
QLogic-Storage-Upstream, jinpu.wang, linux-scsi, linux-kernel
On Monday 31 July 2017 01:26 PM, Johannes Thumshirn wrote:
> On Sun, Jul 30, 2017 at 02:07:09PM +0530, Arvind Yadav wrote:
>> pci_device_id are not supposed to change at runtime. All functions
>> working with pci_device_id provided by <linux/pci.h> work with
>> const pci_device_id. So mark the non-const structs as const.
> Can't this go all in one patch instead of replicating the same patch 29
> times?
Yes, We can add all of them in single patch. But other maintainer wants
single single patch. thats why I have send 29 patch. :(
> Thanks,
> Johannes
>
~arvind
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH 00/29] constify scsi pci_device_id.
2017-07-31 8:53 ` Arvind Yadav
@ 2017-07-31 9:27 ` Johannes Thumshirn
2017-08-07 17:28 ` Martin K. Petersen
0 siblings, 1 reply; 17+ messages in thread
From: Johannes Thumshirn @ 2017-07-31 9:27 UTC (permalink / raw)
To: Arvind Yadav
Cc: martin.petersen, jejb, mdr, hare, aacraid, matthew, fthain,
schmitzmic, kashyap.desai, sumit.saxena, gotom, mrochs, yokota,
QLogic-Storage-Upstream, jinpu.wang, linux-scsi, linux-kernel
On Mon, Jul 31, 2017 at 02:23:11PM +0530, Arvind Yadav wrote:
> Yes, We can add all of them in single patch. But other maintainer wants
> single single patch. thats why I have send 29 patch. :(
Ultimately it's up to Martin and James but I don't see a hughe benefit in
having it all in a separate patch.
Thanks,
Johannes
--
Johannes Thumshirn Storage
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH 00/29] constify scsi pci_device_id.
2017-07-31 9:27 ` Johannes Thumshirn
@ 2017-08-07 17:28 ` Martin K. Petersen
2017-08-08 6:34 ` Johannes Thumshirn
0 siblings, 1 reply; 17+ messages in thread
From: Martin K. Petersen @ 2017-08-07 17:28 UTC (permalink / raw)
To: Johannes Thumshirn
Cc: Arvind Yadav, martin.petersen, jejb, mdr, hare, aacraid, matthew,
fthain, schmitzmic, kashyap.desai, sumit.saxena, gotom, mrochs,
yokota, QLogic-Storage-Upstream, jinpu.wang, linux-scsi,
linux-kernel
Johannes,
> Ultimately it's up to Martin and James but I don't see a hughe benefit
> in having it all in a separate patch.
Generally speaking, I prefer driver maintainers to be able to sign off
on changes to their code. So I tend to lean towards a per-driver
grouping.
However, having a bazillion identical commit messages is also really
annoying. So for automated changes like this, I'd rather just have a
single patch.
It needs to have a really good and comprehensive commit messages that
justifies the (sub) tree-wide change, though...
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH 00/29] constify scsi pci_device_id.
2017-08-07 17:28 ` Martin K. Petersen
@ 2017-08-08 6:34 ` Johannes Thumshirn
0 siblings, 0 replies; 17+ messages in thread
From: Johannes Thumshirn @ 2017-08-08 6:34 UTC (permalink / raw)
To: Martin K. Petersen
Cc: Arvind Yadav, jejb, mdr, hare, aacraid, matthew, fthain,
schmitzmic, kashyap.desai, sumit.saxena, gotom, mrochs, yokota,
QLogic-Storage-Upstream, jinpu.wang, linux-scsi, linux-kernel
On Mon, Aug 07, 2017 at 01:28:18PM -0400, Martin K . Petersen wrote:
> However, having a bazillion identical commit messages is also really
> annoying. So for automated changes like this, I'd rather just have a
> single patch.
Thought so ;-)
--
Johannes Thumshirn Storage
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
^ permalink raw reply [flat|nested] 17+ messages in thread