* [PATCH] scsi: cxgb4i: clean up a debug printk
@ 2020-07-13 10:51 Dan Carpenter
2020-07-13 16:13 ` Varun Prakash
2020-07-14 4:58 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2020-07-13 10:51 UTC (permalink / raw)
To: James E.J. Bottomley, Varun Prakash
Cc: Martin K. Petersen, Pankaj Bharadiya, Austin Kim, linux-scsi,
kernel-janitors
The pr_fmt() at the top of the file already includes the __func__ so we
can remove the duplicative "cxgbi_conn_init_pdu:" from the string here.
Now it all fits on one line as well.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/scsi/cxgbi/libcxgbi.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/scsi/cxgbi/libcxgbi.c b/drivers/scsi/cxgbi/libcxgbi.c
index 1fb101c616b7..ba1593be626c 100644
--- a/drivers/scsi/cxgbi/libcxgbi.c
+++ b/drivers/scsi/cxgbi/libcxgbi.c
@@ -2182,8 +2182,7 @@ int cxgbi_conn_init_pdu(struct iscsi_task *task, unsigned int offset,
}
log_debug(1 << CXGBI_DBG_ISCSI | 1 << CXGBI_DBG_PDU_TX,
- "cxgbi_conn_init_pdu: tdata->total_count %u, "
- "tdata->total_offset %u\n",
+ "data->total_count %u, tdata->total_offset %u\n",
tdata->total_count, tdata->total_offset);
expected_count = tdata->total_count;
--
2.27.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: cxgb4i: clean up a debug printk
2020-07-13 10:51 [PATCH] scsi: cxgb4i: clean up a debug printk Dan Carpenter
@ 2020-07-13 16:13 ` Varun Prakash
2020-07-14 4:58 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Varun Prakash @ 2020-07-13 16:13 UTC (permalink / raw)
To: Dan Carpenter
Cc: James E.J. Bottomley, Martin K. Petersen, Pankaj Bharadiya,
Austin Kim, linux-scsi, kernel-janitors, varun
On Mon, Jul 13, 2020 at 10:51:00AM +0000, Dan Carpenter wrote:
> The pr_fmt() at the top of the file already includes the __func__ so we
> can remove the duplicative "cxgbi_conn_init_pdu:" from the string here.
> Now it all fits on one line as well.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/scsi/cxgbi/libcxgbi.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/cxgbi/libcxgbi.c b/drivers/scsi/cxgbi/libcxgbi.c
> index 1fb101c616b7..ba1593be626c 100644
> --- a/drivers/scsi/cxgbi/libcxgbi.c
> +++ b/drivers/scsi/cxgbi/libcxgbi.c
> @@ -2182,8 +2182,7 @@ int cxgbi_conn_init_pdu(struct iscsi_task *task, unsigned int offset,
> }
>
> log_debug(1 << CXGBI_DBG_ISCSI | 1 << CXGBI_DBG_PDU_TX,
> - "cxgbi_conn_init_pdu: tdata->total_count %u, "
> - "tdata->total_offset %u\n",
> + "data->total_count %u, tdata->total_offset %u\n",
> tdata->total_count, tdata->total_offset);
>
> expected_count = tdata->total_count;
Acked-by: Varun Prakash <varun@chelsio.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: cxgb4i: clean up a debug printk
2020-07-13 10:51 [PATCH] scsi: cxgb4i: clean up a debug printk Dan Carpenter
2020-07-13 16:13 ` Varun Prakash
@ 2020-07-14 4:58 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2020-07-14 4:58 UTC (permalink / raw)
To: Dan Carpenter, Varun Prakash, James E.J. Bottomley
Cc: Martin K . Petersen, kernel-janitors, Austin Kim,
Pankaj Bharadiya, linux-scsi
On Mon, 13 Jul 2020 10:51:00 +0000 (UTC), Dan Carpenter wrote:
> The pr_fmt() at the top of the file already includes the __func__ so we
> can remove the duplicative "cxgbi_conn_init_pdu:" from the string here.
> Now it all fits on one line as well.
Applied to 5.9/scsi-queue, thanks!
[1/1] scsi: cxgb4i: Clean up a debug printk
https://git.kernel.org/mkp/scsi/c/30f259b4886a
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-07-14 5:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-07-13 10:51 [PATCH] scsi: cxgb4i: clean up a debug printk Dan Carpenter
2020-07-13 16:13 ` Varun Prakash
2020-07-14 4:58 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox