* [PATCH] pcmcia/nsp_cs: Use SAM_STAT_CHECK_CONDITION
@ 2021-05-27 7:22 Hannes Reinecke
2021-05-27 16:43 ` Bart Van Assche
0 siblings, 1 reply; 2+ messages in thread
From: Hannes Reinecke @ 2021-05-27 7:22 UTC (permalink / raw)
To: Martin K. Petersen
Cc: Christoph Hellwig, James Bottomley, linux-scsi, Stephen Rothwell,
Hannes Reinecke
The nsp_cs driver stores the SAM status values in SCp.Status, so
we need to use the non-shifted version SAM_STAT_CHECK_CONDITION.
Signed-off-by: Hannes Reinecke <hare@suse.de>
---
drivers/scsi/pcmcia/nsp_cs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/pcmcia/nsp_cs.c b/drivers/scsi/pcmcia/nsp_cs.c
index ac89002646a3..7c0f931e55e8 100644
--- a/drivers/scsi/pcmcia/nsp_cs.c
+++ b/drivers/scsi/pcmcia/nsp_cs.c
@@ -221,7 +221,7 @@ static int nsp_queuecommand_lck(struct scsi_cmnd *SCpnt,
data->CurrentSC = SCpnt;
- SCpnt->SCp.Status = CHECK_CONDITION;
+ SCpnt->SCp.Status = SAM_STAT_CHECK_CONDITION;
SCpnt->SCp.Message = 0;
SCpnt->SCp.have_data_in = IO_UNKNOWN;
SCpnt->SCp.sent_command = 0;
--
2.29.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] pcmcia/nsp_cs: Use SAM_STAT_CHECK_CONDITION
2021-05-27 7:22 [PATCH] pcmcia/nsp_cs: Use SAM_STAT_CHECK_CONDITION Hannes Reinecke
@ 2021-05-27 16:43 ` Bart Van Assche
0 siblings, 0 replies; 2+ messages in thread
From: Bart Van Assche @ 2021-05-27 16:43 UTC (permalink / raw)
To: Hannes Reinecke, Martin K. Petersen
Cc: Christoph Hellwig, James Bottomley, linux-scsi, Stephen Rothwell
On 5/27/21 12:22 AM, Hannes Reinecke wrote:
> The nsp_cs driver stores the SAM status values in SCp.Status, so
> we need to use the non-shifted version SAM_STAT_CHECK_CONDITION.
>
> Signed-off-by: Hannes Reinecke <hare@suse.de>
> ---
> drivers/scsi/pcmcia/nsp_cs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/pcmcia/nsp_cs.c b/drivers/scsi/pcmcia/nsp_cs.c
> index ac89002646a3..7c0f931e55e8 100644
> --- a/drivers/scsi/pcmcia/nsp_cs.c
> +++ b/drivers/scsi/pcmcia/nsp_cs.c
> @@ -221,7 +221,7 @@ static int nsp_queuecommand_lck(struct scsi_cmnd *SCpnt,
>
> data->CurrentSC = SCpnt;
>
> - SCpnt->SCp.Status = CHECK_CONDITION;
> + SCpnt->SCp.Status = SAM_STAT_CHECK_CONDITION;
> SCpnt->SCp.Message = 0;
> SCpnt->SCp.have_data_in = IO_UNKNOWN;
> SCpnt->SCp.sent_command = 0;
Since this patch is a bug fix, does this patch need a Cc: stable tag?
I'm not sure how to add a Fixes: tag since this bug predates Linux
kernel v2.6.12.
Thanks,
Bart.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-05-27 16:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-05-27 7:22 [PATCH] pcmcia/nsp_cs: Use SAM_STAT_CHECK_CONDITION Hannes Reinecke
2021-05-27 16:43 ` Bart Van Assche
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox