* [PATCH] scsi: hisi_sas: remove stray fallthrough annotation
@ 2022-03-17 7:52 Dan Carpenter
2022-03-17 8:47 ` John Garry
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Dan Carpenter @ 2022-03-17 7:52 UTC (permalink / raw)
To: John Garry
Cc: James E.J. Bottomley, Martin K. Petersen, linux-scsi,
kernel-janitors
This case statement doesn't fall through any more so remove the
fallthrough annotation.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/scsi/hisi_sas/hisi_sas_main.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/scsi/hisi_sas/hisi_sas_main.c b/drivers/scsi/hisi_sas/hisi_sas_main.c
index 461ef8a76c4c..4bda2f6cb352 100644
--- a/drivers/scsi/hisi_sas/hisi_sas_main.c
+++ b/drivers/scsi/hisi_sas/hisi_sas_main.c
@@ -442,7 +442,6 @@ void hisi_sas_task_deliver(struct hisi_hba *hisi_hba,
case SAS_PROTOCOL_INTERNAL_ABORT:
hisi_sas_task_prep_abort(hisi_hba, slot);
break;
- fallthrough;
default:
return;
}
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] scsi: hisi_sas: remove stray fallthrough annotation
2022-03-17 7:52 [PATCH] scsi: hisi_sas: remove stray fallthrough annotation Dan Carpenter
@ 2022-03-17 8:47 ` John Garry
2022-03-30 3:53 ` Martin K. Petersen
2022-04-07 13:35 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: John Garry @ 2022-03-17 8:47 UTC (permalink / raw)
To: Dan Carpenter
Cc: James E.J. Bottomley, Martin K. Petersen, linux-scsi,
kernel-janitors
On 17/03/2022 07:52, Dan Carpenter wrote:
> This case statement doesn't fall through any more so remove the
> fallthrough annotation.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks
Acked-by: John Garry <john.garry@huawei.com>
> ---
> drivers/scsi/hisi_sas/hisi_sas_main.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/scsi/hisi_sas/hisi_sas_main.c b/drivers/scsi/hisi_sas/hisi_sas_main.c
> index 461ef8a76c4c..4bda2f6cb352 100644
> --- a/drivers/scsi/hisi_sas/hisi_sas_main.c
> +++ b/drivers/scsi/hisi_sas/hisi_sas_main.c
> @@ -442,7 +442,6 @@ void hisi_sas_task_deliver(struct hisi_hba *hisi_hba,
> case SAS_PROTOCOL_INTERNAL_ABORT:
> hisi_sas_task_prep_abort(hisi_hba, slot);
> break;
> - fallthrough;
> default:
> return;
> }
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] scsi: hisi_sas: remove stray fallthrough annotation
2022-03-17 7:52 [PATCH] scsi: hisi_sas: remove stray fallthrough annotation Dan Carpenter
2022-03-17 8:47 ` John Garry
@ 2022-03-30 3:53 ` Martin K. Petersen
2022-04-07 13:35 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2022-03-30 3:53 UTC (permalink / raw)
To: Dan Carpenter
Cc: John Garry, James E.J. Bottomley, Martin K. Petersen, linux-scsi,
kernel-janitors
Dan,
> This case statement doesn't fall through any more so remove the
> fallthrough annotation.
Applied to 5.18/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] scsi: hisi_sas: remove stray fallthrough annotation
2022-03-17 7:52 [PATCH] scsi: hisi_sas: remove stray fallthrough annotation Dan Carpenter
2022-03-17 8:47 ` John Garry
2022-03-30 3:53 ` Martin K. Petersen
@ 2022-04-07 13:35 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2022-04-07 13:35 UTC (permalink / raw)
To: Dan Carpenter, John Garry; +Cc: Martin K . Petersen, linux-scsi
On Thu, 17 Mar 2022 10:52:14 +0300, Dan Carpenter wrote:
> This case statement doesn't fall through any more so remove the
> fallthrough annotation.
>
>
Applied to 5.18/scsi-fixes, thanks!
[1/1] scsi: hisi_sas: remove stray fallthrough annotation
https://git.kernel.org/mkp/scsi/c/066f4c31945c
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-04-07 13:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-03-17 7:52 [PATCH] scsi: hisi_sas: remove stray fallthrough annotation Dan Carpenter
2022-03-17 8:47 ` John Garry
2022-03-30 3:53 ` Martin K. Petersen
2022-04-07 13:35 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox