From: Mike Christie <michael.christie@oracle.com>
To: bvanassche@acm.org, mwilck@suse.com, hch@lst.de,
martin.petersen@oracle.com, linux-scsi@vger.kernel.org,
james.bottomley@hansenpartnership.com
Cc: Mike Christie <michael.christie@oracle.com>
Subject: [PATCH v4 19/36] scsi: Remove scsi_execute functions
Date: Sun, 16 Oct 2022 14:59:29 -0500 [thread overview]
Message-ID: <20221016195946.7613-20-michael.christie@oracle.com> (raw)
In-Reply-To: <20221016195946.7613-1-michael.christie@oracle.com>
The scsi_execute* functions are no longer used so remove them.
Signed-off-by: Mike Christie <michael.christie@oracle.com>
Reviewed-by: Martin Wilck <mwilck@suse.com>
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
---
include/scsi/scsi_device.h | 39 --------------------------------------
1 file changed, 39 deletions(-)
diff --git a/include/scsi/scsi_device.h b/include/scsi/scsi_device.h
index 72d1690f4ff1..c2dbb8824ef8 100644
--- a/include/scsi/scsi_device.h
+++ b/include/scsi/scsi_device.h
@@ -482,45 +482,6 @@ extern int __scsi_exec_req(const struct scsi_exec_args *args);
args.sense_len != SCSI_SENSE_BUFFERSIZE); \
__scsi_exec_req(&args); \
})
-
-/* Make sure any sense buffer is the correct size. */
-#define scsi_execute(_sdev, _cmd, _data_dir, _buffer, _bufflen, _sense, \
- _sshdr, _timeout, _retries, _flags, _rq_flags, \
- _resid) \
-({ \
- BUILD_BUG_ON((_sense) != NULL && \
- sizeof(_sense) != SCSI_SENSE_BUFFERSIZE); \
- __scsi_exec_req(&((struct scsi_exec_args) { \
- .sdev = _sdev, \
- .cmd = _cmd, \
- .data_dir = _data_dir, \
- .buf = _buffer, \
- .buf_len = _bufflen, \
- .sense = _sense, \
- .sshdr = _sshdr, \
- .timeout = _timeout, \
- .retries = _retries, \
- .op_flags = _flags, \
- .req_flags = _rq_flags, \
- .resid = _resid, })); \
-})
-
-static inline int scsi_execute_req(struct scsi_device *sdev,
- const unsigned char *cmd, int data_direction, void *buffer,
- unsigned bufflen, struct scsi_sense_hdr *sshdr, int timeout,
- int retries, int *resid)
-{
- return __scsi_exec_req(&(struct scsi_exec_args) {
- .sdev = sdev,
- .cmd = cmd,
- .data_dir = data_direction,
- .buf = buffer,
- .buf_len = bufflen,
- .sshdr = sshdr,
- .timeout = timeout,
- .retries = retries,
- .resid = resid });
-}
extern void sdev_disable_disk_events(struct scsi_device *sdev);
extern void sdev_enable_disk_events(struct scsi_device *sdev);
extern int scsi_vpd_lun_id(struct scsi_device *, char *, size_t);
--
2.25.1
next prev parent reply other threads:[~2022-10-16 20:08 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-16 19:59 [PATCH v4 00/36] Allow scsi_execute users to control retries Mike Christie
2022-10-16 19:59 ` [PATCH v4 01/36] scsi: Add helper to prep sense during error handling Mike Christie
2022-10-16 19:59 ` [PATCH v4 02/36] scsi: Allow passthrough to override what errors to retry Mike Christie
2022-10-19 22:17 ` Bart Van Assche
2022-10-16 19:59 ` [PATCH v4 03/36] scsi: Add struct for args to execution functions Mike Christie
2022-10-16 19:59 ` [PATCH v4 04/36] scsi: Add scsi_failure field to scsi_exec_args Mike Christie
2022-10-16 19:59 ` [PATCH v4 05/36] scsi: libata: Convert to scsi_exec_req Mike Christie
2022-10-16 19:59 ` [PATCH v4 06/36] hwmon: drivetemp: " Mike Christie
2022-10-19 22:06 ` Bart Van Assche
2022-10-19 23:23 ` Damien Le Moal
2022-10-20 17:52 ` Bart Van Assche
2022-10-20 21:22 ` Damien Le Moal
2022-10-16 19:59 ` [PATCH v4 07/36] scsi: ch: " Mike Christie
2022-10-16 19:59 ` [PATCH v4 08/36] scsi: scsi_dh: " Mike Christie
2022-10-16 19:59 ` [PATCH v4 09/36] scsi: core: " Mike Christie
2022-10-16 19:59 ` [PATCH v4 10/36] scsi: spi: " Mike Christie
2022-10-16 19:59 ` [PATCH v4 11/36] scsi: sd: " Mike Christie
2022-10-16 19:59 ` [PATCH v4 12/36] scsi: zbc: " Mike Christie
2022-10-16 19:59 ` [PATCH v4 13/36] scsi: ses: " Mike Christie
2022-10-16 19:59 ` [PATCH v4 14/36] scsi: sr: " Mike Christie
2022-10-16 19:59 ` [PATCH v4 15/36] scsi: virtio_scsi: " Mike Christie
2022-10-16 19:59 ` [PATCH v4 16/36] scsi: target_core_pscsi: " Mike Christie
2022-10-16 19:59 ` [PATCH v4 17/36] scsi: ufshcd: " Mike Christie
2022-10-16 19:59 ` [PATCH v4 18/36] scsi: cxlflash: " Mike Christie
2022-10-16 19:59 ` Mike Christie [this message]
2022-10-16 19:59 ` [PATCH v4 20/36] scsi: Have scsi-ml retry scsi_probe_lun errors Mike Christie
2022-10-19 22:08 ` Bart Van Assche
2022-10-16 19:59 ` [PATCH v4 21/36] scsi: retry INQUIRY after timeout Mike Christie
2022-10-16 19:59 ` [PATCH v4 22/36] scsi: Have scsi-ml retry read_capacity_16 errors Mike Christie
2022-10-19 22:15 ` Bart Van Assche
2022-10-20 19:15 ` Mike Christie
2022-10-16 19:59 ` [PATCH v4 23/36] scsi: Have scsi-ml retry sd_spinup_disk errors Mike Christie
2022-10-20 18:23 ` Bart Van Assche
2022-10-16 19:59 ` [PATCH v4 24/36] scsi: hp_sw: Have scsi-ml retry scsi_exec_req errors Mike Christie
2022-10-16 19:59 ` [PATCH v4 25/36] scsi: rdac: Have scsi-ml retry send_mode_select errors Mike Christie
2022-10-16 19:59 ` [PATCH v4 26/36] scsi: spi: Have scsi-ml retry spi_execute errors Mike Christie
2022-10-16 19:59 ` [PATCH v4 27/36] scsi: sd: Have scsi-ml retry sd_sync_cache errors Mike Christie
2022-10-16 19:59 ` [PATCH v4 28/36] scsi: ch: Have scsi-ml retry ch_do_scsi errors Mike Christie
2022-10-16 19:59 ` [PATCH v4 29/36] scsi: Have scsi-ml retry scsi_mode_sense errors Mike Christie
2022-10-16 19:59 ` [PATCH v4 30/36] scsi: Have scsi-ml retry scsi_report_lun_scan errors Mike Christie
2022-10-16 19:59 ` [PATCH v4 31/36] scsi: sd: Have sd_pr_command retry UAs Mike Christie
2022-10-16 19:59 ` [PATCH v4 32/36] scsi: sd: Have scsi-ml retry read_capacity_10 errors Mike Christie
2022-10-16 19:59 ` [PATCH v4 33/36] scsi: ses: Have scsi-ml retry scsi_exec_req errors Mike Christie
2022-10-16 19:59 ` [PATCH v4 34/36] scsi: sr: Have scsi-ml retry get_sectorsize errors Mike Christie
2022-10-16 19:59 ` [PATCH v4 35/36] scsi: cxlflash: Have scsi-ml retry read_cap16 errors Mike Christie
2022-10-16 19:59 ` [PATCH v4 36/36] scsi: Add kunit tests for scsi_check_passthrough Mike Christie
2022-10-19 21:39 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221016195946.7613-20-michael.christie@oracle.com \
--to=michael.christie@oracle.com \
--cc=bvanassche@acm.org \
--cc=hch@lst.de \
--cc=james.bottomley@hansenpartnership.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mwilck@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox