From: Bart Van Assche <bvanassche@acm.org>
To: Mike Christie <michael.christie@oracle.com>,
mwilck@suse.com, hch@lst.de, martin.petersen@oracle.com,
linux-scsi@vger.kernel.org,
james.bottomley@hansenpartnership.com
Subject: Re: [PATCH v4 22/36] scsi: Have scsi-ml retry read_capacity_16 errors
Date: Wed, 19 Oct 2022 15:15:53 -0700 [thread overview]
Message-ID: <2aca5af1-3949-a8ac-6050-4b06d71e2fbf@acm.org> (raw)
In-Reply-To: <20221016195946.7613-23-michael.christie@oracle.com>
On 10/16/22 12:59, Mike Christie wrote:
> + struct scsi_failure failures[] = {
> + {
> + .sense = UNIT_ATTENTION,
> + .asc = 0x29,
> + .ascq = 0,
> + /* Device reset might occur several times */
> + .allowed = READ_CAPACITY_RETRIES_ON_RESET,
> + .result = SAM_STAT_CHECK_CONDITION,
> + },
> + {
> + .result = SCMD_FAILURE_ANY,
> + .allowed = 3,
> + },
> + {},
> + };
Is the implication of the above that any failure reported in the .result
field will result in a retry? I don't think that matches the current
behavior of read_capacity_16().
Thanks,
Bart.
next prev parent reply other threads:[~2022-10-19 22:16 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-16 19:59 [PATCH v4 00/36] Allow scsi_execute users to control retries Mike Christie
2022-10-16 19:59 ` [PATCH v4 01/36] scsi: Add helper to prep sense during error handling Mike Christie
2022-10-16 19:59 ` [PATCH v4 02/36] scsi: Allow passthrough to override what errors to retry Mike Christie
2022-10-19 22:17 ` Bart Van Assche
2022-10-16 19:59 ` [PATCH v4 03/36] scsi: Add struct for args to execution functions Mike Christie
2022-10-16 19:59 ` [PATCH v4 04/36] scsi: Add scsi_failure field to scsi_exec_args Mike Christie
2022-10-16 19:59 ` [PATCH v4 05/36] scsi: libata: Convert to scsi_exec_req Mike Christie
2022-10-16 19:59 ` [PATCH v4 06/36] hwmon: drivetemp: " Mike Christie
2022-10-19 22:06 ` Bart Van Assche
2022-10-19 23:23 ` Damien Le Moal
2022-10-20 17:52 ` Bart Van Assche
2022-10-20 21:22 ` Damien Le Moal
2022-10-16 19:59 ` [PATCH v4 07/36] scsi: ch: " Mike Christie
2022-10-16 19:59 ` [PATCH v4 08/36] scsi: scsi_dh: " Mike Christie
2022-10-16 19:59 ` [PATCH v4 09/36] scsi: core: " Mike Christie
2022-10-16 19:59 ` [PATCH v4 10/36] scsi: spi: " Mike Christie
2022-10-16 19:59 ` [PATCH v4 11/36] scsi: sd: " Mike Christie
2022-10-16 19:59 ` [PATCH v4 12/36] scsi: zbc: " Mike Christie
2022-10-16 19:59 ` [PATCH v4 13/36] scsi: ses: " Mike Christie
2022-10-16 19:59 ` [PATCH v4 14/36] scsi: sr: " Mike Christie
2022-10-16 19:59 ` [PATCH v4 15/36] scsi: virtio_scsi: " Mike Christie
2022-10-16 19:59 ` [PATCH v4 16/36] scsi: target_core_pscsi: " Mike Christie
2022-10-16 19:59 ` [PATCH v4 17/36] scsi: ufshcd: " Mike Christie
2022-10-16 19:59 ` [PATCH v4 18/36] scsi: cxlflash: " Mike Christie
2022-10-16 19:59 ` [PATCH v4 19/36] scsi: Remove scsi_execute functions Mike Christie
2022-10-16 19:59 ` [PATCH v4 20/36] scsi: Have scsi-ml retry scsi_probe_lun errors Mike Christie
2022-10-19 22:08 ` Bart Van Assche
2022-10-16 19:59 ` [PATCH v4 21/36] scsi: retry INQUIRY after timeout Mike Christie
2022-10-16 19:59 ` [PATCH v4 22/36] scsi: Have scsi-ml retry read_capacity_16 errors Mike Christie
2022-10-19 22:15 ` Bart Van Assche [this message]
2022-10-20 19:15 ` Mike Christie
2022-10-16 19:59 ` [PATCH v4 23/36] scsi: Have scsi-ml retry sd_spinup_disk errors Mike Christie
2022-10-20 18:23 ` Bart Van Assche
2022-10-16 19:59 ` [PATCH v4 24/36] scsi: hp_sw: Have scsi-ml retry scsi_exec_req errors Mike Christie
2022-10-16 19:59 ` [PATCH v4 25/36] scsi: rdac: Have scsi-ml retry send_mode_select errors Mike Christie
2022-10-16 19:59 ` [PATCH v4 26/36] scsi: spi: Have scsi-ml retry spi_execute errors Mike Christie
2022-10-16 19:59 ` [PATCH v4 27/36] scsi: sd: Have scsi-ml retry sd_sync_cache errors Mike Christie
2022-10-16 19:59 ` [PATCH v4 28/36] scsi: ch: Have scsi-ml retry ch_do_scsi errors Mike Christie
2022-10-16 19:59 ` [PATCH v4 29/36] scsi: Have scsi-ml retry scsi_mode_sense errors Mike Christie
2022-10-16 19:59 ` [PATCH v4 30/36] scsi: Have scsi-ml retry scsi_report_lun_scan errors Mike Christie
2022-10-16 19:59 ` [PATCH v4 31/36] scsi: sd: Have sd_pr_command retry UAs Mike Christie
2022-10-16 19:59 ` [PATCH v4 32/36] scsi: sd: Have scsi-ml retry read_capacity_10 errors Mike Christie
2022-10-16 19:59 ` [PATCH v4 33/36] scsi: ses: Have scsi-ml retry scsi_exec_req errors Mike Christie
2022-10-16 19:59 ` [PATCH v4 34/36] scsi: sr: Have scsi-ml retry get_sectorsize errors Mike Christie
2022-10-16 19:59 ` [PATCH v4 35/36] scsi: cxlflash: Have scsi-ml retry read_cap16 errors Mike Christie
2022-10-16 19:59 ` [PATCH v4 36/36] scsi: Add kunit tests for scsi_check_passthrough Mike Christie
2022-10-19 21:39 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2aca5af1-3949-a8ac-6050-4b06d71e2fbf@acm.org \
--to=bvanassche@acm.org \
--cc=hch@lst.de \
--cc=james.bottomley@hansenpartnership.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=michael.christie@oracle.com \
--cc=mwilck@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox