Linux SCSI subsystem development
 help / color / mirror / Atom feed
From: "Alexey V. Vissarionov" <gremlin@altlinux.org>
To: Bart Van Assche <bvanassche@acm.org>
Cc: "Alexey V. Vissarionov" <gremlin@altlinux.org>,
	Don Brace <don.brace@microchip.com>,
	"James E.J. Bottomley" <jejb@linux.ibm.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	"Stephen M. Cameron" <scameron@beardog.cce.hp.com>,
	storagedev@microchip.com, linux-scsi@vger.kernel.org,
	lvc-project@linuxtesting.org
Subject: Re: [PATCH] scsi: hpsa: fix allocation size for scsi_host_alloc()
Date: Tue, 17 Jan 2023 12:56:45 +0300	[thread overview]
Message-ID: <20230117095644.GA12547@altlinux.org> (raw)
In-Reply-To: <39006233-ff6f-82ad-b772-e00e789375a5@acm.org>

On 2023-01-16 14:41:08 -0800, Bart Van Assche wrote:

 >> Fixes: b705690d8d16f708 ("[SCSI] hpsa: combine hpsa_scsi_detect
 >> and hpsa_register_scsi")
 > That seems incorrect to me. Shouldn't the Fixes tag be changed
 > into the following?
 > Fixes: edd163687ea5 ("[SCSI] hpsa: add driver for HP Smart Array
 > controllers.")

% git blame -L 5853,+1 -- drivers/scsi/hpsa.c
b705690d8d16f7081 (Stephen M. Cameron 2012-01-19 14:00:53 -0600 5853)
	sh = scsi_host_alloc(&hpsa_driver_template, sizeof(h));

Is anything wrong here?


-- 
Alexey V. Vissarionov
gremlin ПРИ altlinux ТЧК org; +vii-cmiii-ccxxix-lxxix-xlii
GPG: 0D92F19E1C0DC36E27F61A29CD17E2B43D879005 @ hkp://keys.gnupg.net

  reply	other threads:[~2023-01-17  9:56 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-16 13:31 [PATCH] scsi: hpsa: fix allocation size for scsi_host_alloc() Alexey V. Vissarionov
2023-01-16 22:41 ` Bart Van Assche
2023-01-17  9:56   ` Alexey V. Vissarionov [this message]
2023-01-17 10:35     ` [lvc-project] " Alexey Khoroshilov
2023-01-17 21:12       ` Alexey V. Vissarionov
2023-01-17 21:23         ` Bart Van Assche
2023-01-18  3:12           ` Alexey V. Vissarionov
2023-01-19  0:06             ` Martin K. Petersen
2023-01-19  0:21             ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230117095644.GA12547@altlinux.org \
    --to=gremlin@altlinux.org \
    --cc=bvanassche@acm.org \
    --cc=don.brace@microchip.com \
    --cc=jejb@linux.ibm.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=lvc-project@linuxtesting.org \
    --cc=martin.petersen@oracle.com \
    --cc=scameron@beardog.cce.hp.com \
    --cc=storagedev@microchip.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox