From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: "Alexey V. Vissarionov" <gremlin@altlinux.org>
Cc: Bart Van Assche <bvanassche@acm.org>,
Alexey Khoroshilov <khoroshilov@ispras.ru>,
linux-scsi@vger.kernel.org,
"Martin K. Petersen" <martin.petersen@oracle.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Stephen M. Cameron" <scameron@beardog.cce.hp.com>,
storagedev@microchip.com, Don Brace <don.brace@microchip.com>,
lvc-project@linuxtesting.org
Subject: Re: [PATCH] scsi: hpsa: fix allocation size for scsi_host_alloc()
Date: Wed, 18 Jan 2023 19:06:09 -0500 [thread overview]
Message-ID: <yq1lelzo0kt.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20230118031255.GE15213@altlinux.org> (Alexey V. Vissarionov's message of "Wed, 18 Jan 2023 06:12:55 +0300")
Alexey,
Next time please use -v2 instead of replying when you post a version 2
of a patch.
> On 2023-01-17 13:23:19 -0800, Bart Van Assche wrote:
>
> > My understanding is that you used an incorrect commit hash.
> > Hence, it is up to you to fix the commit hash.
>
> ACK. Resending:
Comments such as this ACK must go below a '---' separator to avoid
ending up in the commit log.
And finally, the updated commit hash now no longer matches the commit
description:
> Fixes: edd163687ea5 ("[SCSI] hpsa: combine hpsa_scsi_detect and hpsa_register_scsi")
$ git log --oneline edd163687ea5 -1
edd163687ea5 [SCSI] hpsa: add driver for HP Smart Array controllers.
I fixed these up and applied to 6.2/scsi-fixes, thanks!
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2023-01-19 0:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-16 13:31 [PATCH] scsi: hpsa: fix allocation size for scsi_host_alloc() Alexey V. Vissarionov
2023-01-16 22:41 ` Bart Van Assche
2023-01-17 9:56 ` Alexey V. Vissarionov
2023-01-17 10:35 ` [lvc-project] " Alexey Khoroshilov
2023-01-17 21:12 ` Alexey V. Vissarionov
2023-01-17 21:23 ` Bart Van Assche
2023-01-18 3:12 ` Alexey V. Vissarionov
2023-01-19 0:06 ` Martin K. Petersen [this message]
2023-01-19 0:21 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1lelzo0kt.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=bvanassche@acm.org \
--cc=don.brace@microchip.com \
--cc=gremlin@altlinux.org \
--cc=jejb@linux.ibm.com \
--cc=khoroshilov@ispras.ru \
--cc=linux-scsi@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=scameron@beardog.cce.hp.com \
--cc=storagedev@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox