From: "Alexey V. Vissarionov" <gremlin@altlinux.org>
To: Alexey Khoroshilov <khoroshilov@ispras.ru>
Cc: "Alexey V. Vissarionov" <gremlin@altlinux.org>,
Bart Van Assche <bvanassche@acm.org>,
linux-scsi@vger.kernel.org,
"Martin K. Petersen" <martin.petersen@oracle.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Stephen M. Cameron" <scameron@beardog.cce.hp.com>,
storagedev@microchip.com, Don Brace <don.brace@microchip.com>,
lvc-project@linuxtesting.org
Subject: Re: [lvc-project] [PATCH] scsi: hpsa: fix allocation size for scsi_host_alloc()
Date: Wed, 18 Jan 2023 00:12:01 +0300 [thread overview]
Message-ID: <20230117211201.GD15213@altlinux.org> (raw)
In-Reply-To: <30d3e555-4fb0-23df-abeb-e1c3dc41543e@ispras.ru>
[-- Attachment #1: Type: text/plain, Size: 1046 bytes --]
On 2023-01-17 13:35:54 +0300, Alexey Khoroshilov wrote:
>>>> Fixes: b705690d8d16f708 ("[SCSI] hpsa: combine
>>>> hpsa_scsi_detect and hpsa_register_scsi")
>>> That seems incorrect to me. Shouldn't the Fixes tag be
>>> changed into the following?
>>> Fixes: edd163687ea5 ("[SCSI] hpsa: add driver for HP
>>> Smart Array controllers.")
>> % git blame -L 5853,+1 -- drivers/scsi/hpsa.c
>> b705690d8d16f7081 (Stephen M. Cameron 2012-01-19 14:00:53
>> -0600 5853)
>> sh = scsi_host_alloc(&hpsa_driver_template, sizeof(h));
>> Is anything wrong here?
> Yes, this commit just moves
> sh = scsi_host_alloc(&hpsa_driver_template, sizeof(h));
> from one function to another one.
> edd163687ea5 ("[SCSI] hpsa: add driver for HP Smart Array
> controllers.")
> is the correct commit introducing the bug.
ACK.
2 BVA: please use the correct commit number.
--
Alexey V. Vissarionov
gremlin ПРИ altlinux ТЧК org; +vii-cmiii-ccxxix-lxxix-xlii
GPG: 0D92F19E1C0DC36E27F61A29CD17E2B43D879005 @ hkp://keys.gnupg.net
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2023-01-17 23:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-16 13:31 [PATCH] scsi: hpsa: fix allocation size for scsi_host_alloc() Alexey V. Vissarionov
2023-01-16 22:41 ` Bart Van Assche
2023-01-17 9:56 ` Alexey V. Vissarionov
2023-01-17 10:35 ` [lvc-project] " Alexey Khoroshilov
2023-01-17 21:12 ` Alexey V. Vissarionov [this message]
2023-01-17 21:23 ` Bart Van Assche
2023-01-18 3:12 ` Alexey V. Vissarionov
2023-01-19 0:06 ` Martin K. Petersen
2023-01-19 0:21 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230117211201.GD15213@altlinux.org \
--to=gremlin@altlinux.org \
--cc=bvanassche@acm.org \
--cc=don.brace@microchip.com \
--cc=jejb@linux.ibm.com \
--cc=khoroshilov@ispras.ru \
--cc=linux-scsi@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=martin.petersen@oracle.com \
--cc=scameron@beardog.cce.hp.com \
--cc=storagedev@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox