Re: [PATCH 3/7] ufs: core: Redirect clock gating to RPM

[kernel test robot <lkp@intel.com>]

Hi Bart,

kernel test robot noticed the following build errors:

[auto build test ERROR on jejb-scsi/for-next]
[also build test ERROR on mkp-scsi/for-next linus/master v6.19-rc5 next-20260116]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Bart-Van-Assche/ufs-core-Change-the-type-of-an-ufshcd_clkgate_delay_set-argument/20260117-022907
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git for-next
patch link:    https://lore.kernel.org/r/20260116182628.3255116-4-bvanassche%40acm.org
patch subject: [PATCH 3/7] ufs: core: Redirect clock gating to RPM
config: hexagon-randconfig-002-20260117 (https://download.01.org/0day-ci/archive/20260117/202601170903.r8uLs14E-lkp@intel.com/config)
compiler: clang version 22.0.0git (https://github.com/llvm/llvm-project 9b8addffa70cee5b2acc5454712d9cf78ce45710)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260117/202601170903.r8uLs14E-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202601170903.r8uLs14E-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/ufs/core/ufshcd.c:2120:22: error: no member named 'use_autosuspend' in 'struct dev_pm_info'
    2120 |         if (!rpm_dev->power.use_autosuspend)
         |              ~~~~~~~~~~~~~~ ^
>> drivers/ufs/core/ufshcd.c:2123:48: error: no member named 'autosuspend_delay' in 'struct dev_pm_info'
    2123 |         return sysfs_emit(buf, "%u\n", rpm_dev->power.autosuspend_delay);
         |                                        ~~~~~~~~~~~~~~ ^
   drivers/ufs/core/ufshcd.c:2143:22: error: no member named 'use_autosuspend' in 'struct dev_pm_info'
    2143 |         if (!rpm_dev->power.use_autosuspend)
         |              ~~~~~~~~~~~~~~ ^
>> drivers/ufs/core/ufshcd.c:2158:57: error: no member named 'runtime_auto' in 'struct dev_pm_info'
    2158 |         return sysfs_emit(buf, "%d\n", ufs_rpm_dev(hba)->power.runtime_auto);
         |                                        ~~~~~~~~~~~~~~~~~~~~~~~ ^
   drivers/ufs/core/ufshcd.c:10656:44: warning: shift count >= width of type [-Wshift-count-overflow]
    10656 |                 if (!dma_set_mask_and_coherent(hba->dev, DMA_BIT_MASK(64)))
          |                                                          ^~~~~~~~~~~~~~~~
   include/linux/dma-mapping.h:93:54: note: expanded from macro 'DMA_BIT_MASK'
      93 | #define DMA_BIT_MASK(n) (((n) == 64) ? ~0ULL : ((1ULL<<(n))-1))
         |                                                      ^ ~~~
   1 warning and 4 errors generated.


vim +2120 drivers/ufs/core/ufshcd.c

  2113	
  2114	static ssize_t ufshcd_clkgate_delay_show(struct device *dev,
  2115			struct device_attribute *attr, char *buf)
  2116	{
  2117		struct ufs_hba *hba = dev_get_drvdata(dev);
  2118		struct device *rpm_dev = ufs_rpm_dev(hba);
  2119	
> 2120		if (!rpm_dev->power.use_autosuspend)
  2121			return -EIO;
  2122	
> 2123		return sysfs_emit(buf, "%u\n", rpm_dev->power.autosuspend_delay);
  2124	}
  2125	
  2126	void ufshcd_clkgate_delay_set(struct ufs_hba *hba, unsigned long value)
  2127	{
  2128		struct device *rpm_dev = ufs_rpm_dev(hba);
  2129	
  2130		device_lock(rpm_dev);
  2131		pm_runtime_set_autosuspend_delay(rpm_dev, value);
  2132		device_unlock(rpm_dev);
  2133	}
  2134	EXPORT_SYMBOL_GPL(ufshcd_clkgate_delay_set);
  2135	
  2136	static ssize_t ufshcd_clkgate_delay_store(struct device *dev,
  2137			struct device_attribute *attr, const char *buf, size_t count)
  2138	{
  2139		struct ufs_hba *hba = dev_get_drvdata(dev);
  2140		struct device *rpm_dev = ufs_rpm_dev(hba);
  2141		unsigned long value;
  2142	
  2143		if (!rpm_dev->power.use_autosuspend)
  2144			return -EIO;
  2145	
  2146		if (kstrtoul(buf, 0, &value))
  2147			return -EINVAL;
  2148	
  2149		ufshcd_clkgate_delay_set(hba, value);
  2150		return count;
  2151	}
  2152	
  2153	static ssize_t ufshcd_clkgate_enable_show(struct device *dev,
  2154			struct device_attribute *attr, char *buf)
  2155	{
  2156		struct ufs_hba *hba = dev_get_drvdata(dev);
  2157	
> 2158		return sysfs_emit(buf, "%d\n", ufs_rpm_dev(hba)->power.runtime_auto);
  2159	}
  2160	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki