* Re: [PATCH RESEND 0/5] Add vhost-blk support
2012-07-17 15:09 ` [PATCH RESEND 0/5] Add vhost-blk support Michael S. Tsirkin
@ 2012-07-18 2:09 ` Asias He
2012-07-18 11:42 ` Stefan Hajnoczi
1 sibling, 0 replies; 3+ messages in thread
From: Asias He @ 2012-07-18 2:09 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: linux-kernel, Alexander Viro, Benjamin LaHaise, James Bottomley,
Jeff Moyer, kvm, linux-aio, linux-fsdevel, target-devel,
linux-scsi, lf-virt, Stefan Hajnoczi, Zhi Yong Wu,
Anthony Liguori, Paolo Bonzini, Christoph Hellwig, Jens Axboe,
Hannes Reinecke
On 07/17/2012 11:09 PM, Michael S. Tsirkin wrote:
> On Fri, Jul 13, 2012 at 04:55:06PM +0800, Asias He wrote:
>>
>> Hi folks,
>>
>> [I am resending to fix the broken thread in the previous one.]
>>
>> This patchset adds vhost-blk support. vhost-blk is a in kernel virito-blk
>> device accelerator. Compared to userspace virtio-blk implementation, vhost-blk
>> gives about 5% to 15% performance improvement.
>
> Same thing as tcm_host comment:
>
> It seems not 100% clear whether this driver will have major
> userspace using it. And if not, it would be very hard to support a
> driver when recent userspace does not use it in the end.
>
> I think a good idea for 3.6 would be to make it depend on
> CONFIG_STAGING. Then we don't commit to an ABI. For this, you can add
> a separate Kconfig and source it from drivers/staging/Kconfig. Maybe it
> needs to be in a separate directory drivers/vhost/staging/Kconfig.
OK.
> I Cc'd the list of tcm_host in the hope that you can cooperate on this.
Sure.
--
Asias
--
To unsubscribe, send a message with 'unsubscribe linux-aio' in
the body to majordomo@kvack.org. For more info on Linux AIO,
see: http://www.kvack.org/aio/
Don't email: <a href=mailto:"aart@kvack.org">aart@kvack.org</a>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH RESEND 0/5] Add vhost-blk support
2012-07-17 15:09 ` [PATCH RESEND 0/5] Add vhost-blk support Michael S. Tsirkin
2012-07-18 2:09 ` Asias He
@ 2012-07-18 11:42 ` Stefan Hajnoczi
1 sibling, 0 replies; 3+ messages in thread
From: Stefan Hajnoczi @ 2012-07-18 11:42 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: Asias He, Jens Axboe, linux-aio, target-devel, linux-scsi, kvm,
linux-kernel, lf-virt, James Bottomley, Anthony Liguori,
Jeff Moyer, Benjamin LaHaise, Alexander Viro, linux-fsdevel,
Paolo Bonzini, Zhi Yong Wu, Christoph Hellwig, Stefan Hajnoczi
On Tue, Jul 17, 2012 at 4:09 PM, Michael S. Tsirkin <mst@redhat.com> wrote:
> On Fri, Jul 13, 2012 at 04:55:06PM +0800, Asias He wrote:
>>
>> Hi folks,
>>
>> [I am resending to fix the broken thread in the previous one.]
>>
>> This patchset adds vhost-blk support. vhost-blk is a in kernel virito-blk
>> device accelerator. Compared to userspace virtio-blk implementation, vhost-blk
>> gives about 5% to 15% performance improvement.
>
> Same thing as tcm_host comment:
>
> It seems not 100% clear whether this driver will have major
> userspace using it. And if not, it would be very hard to support a
> driver when recent userspace does not use it in the end.
>
> I think a good idea for 3.6 would be to make it depend on
> CONFIG_STAGING. Then we don't commit to an ABI. For this, you can add
> a separate Kconfig and source it from drivers/staging/Kconfig. Maybe it
> needs to be in a separate directory drivers/vhost/staging/Kconfig.
>
> I Cc'd the list of tcm_host in the hope that you can cooperate on this.
>
Adding it to staging allows more people to try it out, so that's a
good thing. If I get a moment to play with it I'll let you know the
results.
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread