public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Sagi Grimberg <sagi@grimberg.me>, Keith Busch <kbusch@kernel.org>,
	"hch@lst.de" <hch@lst.de>,
	"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
	Damien Le Moal <damien.lemoal@opensource.wdc.com>
Cc: "dgilbert@interlog.com" <dgilbert@interlog.com>,
	Hannes Reinecke <hare@suse.de>,
	"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
	"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	"lsf-pc@lists.linuxfoundation.org"
	<lsf-pc@lists.linuxfoundation.org>
Subject: Re: [LSF/MM/BPF BOF] Userspace command abouts
Date: Fri, 24 Feb 2023 23:54:39 +0000	[thread overview]
Message-ID: <73b4dd39-9ce8-9b55-8a1d-06865f3bde32@nvidia.com> (raw)
In-Reply-To: <561afa67-04d0-c675-6bbb-048313da152b@grimberg.me>

(+Martin, Damien)

On 2/23/2023 7:35 AM, Sagi Grimberg wrote:
> 
>>>>> I did not understand what is the relationship between aborts and CDL.
>>>>> Sounds to me that this would tie in to something like Time Limited 
>>>>> Error
>>>>> Recovery (TLER) and LR bit set based on ioprio?
>>>>>
>>>>> I am unclear where do aborts come into play here.
>>>>
>>>> CDL: Command Duration Limits
>>>>
>>>> One use case is reading from storage for audio visual output.
>>>> An application only wants to wait so long (e.g. one or two frames
>>>> on the video output) before it wants to forget about the current
>>>> read (i.e. "abort" it) and move onto the next read. An alert viewer
>>>> might notice a momentary freeze frame.
>>>>
>>>> The SCSI CDL mechanism uses the DL0, DL1 and DL2 bits in the 
>>>> READ(16,32)
>>>> commands. CDL also depends on the CDLP and RWCDLP fields in the
>>>> REPORT SUPPORTED OPERATION CODES command and one of the CDL
>>>> mode pages. So there may be some additional "wiring" needed in the
>>>> SCSI subsystem.
>>>
>>> I still don't understand where issuing aborts from userspace come into
>>> play here...
>>
>> The only connection is that aborts are obsolete and unnecessary if
>> you have a working CDL implementation.
> 
> OK, that makes sense. Indeed I *think* that nvme can support CDL and if
> this is useful for userspace then this is an interesting path to take.

I do think that we should work on CDL for NVMe as it will solve some of
the timeout related problems effectively than using aborts or any other
mechanism.

-ck



  reply	other threads:[~2023-02-24 23:54 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-16 11:50 [LSF/MM/BPF BOF] Userspace command abouts Hannes Reinecke
2023-02-16 16:40 ` Keith Busch
2023-02-17 18:53   ` Chaitanya Kulkarni
2023-02-18  9:50     ` [LSF/MM/BPF BOF] Userspace command aborts Hannes Reinecke
2023-02-21 18:15       ` Chaitanya Kulkarni
2023-02-20 11:24   ` [LSF/MM/BPF BOF] Userspace command abouts Sagi Grimberg
2023-02-21 16:25     ` Douglas Gilbert
2023-02-22 14:37       ` Sagi Grimberg
2023-02-22 14:53         ` Keith Busch
2023-02-23 15:35           ` Sagi Grimberg
2023-02-24 23:54             ` Chaitanya Kulkarni [this message]
2023-02-25  1:51               ` Keith Busch
2023-02-25  4:15                 ` Damien Le Moal
2023-02-25 16:14                   ` James Smart
2023-02-27 16:33                   ` Sagi Grimberg
2023-02-27 17:28                     ` Hannes Reinecke
2023-02-27 17:44                       ` Keith Busch
2023-02-27 21:18                         ` Damien Le Moal
2023-02-27 21:42                         ` Damien Le Moal
2023-02-28  8:05                         ` Sagi Grimberg
2023-02-27 21:17                     ` Damien Le Moal
2023-02-27  8:20                 ` Hannes Reinecke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=73b4dd39-9ce8-9b55-8a1d-06865f3bde32@nvidia.com \
    --to=chaitanyak@nvidia.com \
    --cc=damien.lemoal@opensource.wdc.com \
    --cc=dgilbert@interlog.com \
    --cc=hare@suse.de \
    --cc=hch@lst.de \
    --cc=kbusch@kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=lsf-pc@lists.linuxfoundation.org \
    --cc=martin.petersen@oracle.com \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox