From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Keith Busch <kbusch@kernel.org>, Hannes Reinecke <hare@suse.de>
Cc: "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"lsf-pc@lists.linuxfoundation.org"
<lsf-pc@lists.linuxfoundation.org>
Subject: Re: [LSF/MM/BPF BOF] Userspace command abouts
Date: Fri, 17 Feb 2023 18:53:53 +0000 [thread overview]
Message-ID: <e7b781d8-d5a7-cf7f-f681-c116fbadfd01@nvidia.com> (raw)
In-Reply-To: <Y+5cjPBE6h/IW9VH@kbusch-mbp>
On 2/16/23 08:40, Keith Busch wrote:
> On Thu, Feb 16, 2023 at 12:50:03PM +0100, Hannes Reinecke wrote:
>> Hi all,
>>
>> it has come up in other threads, so it might be worthwhile to have its own
>> topic:
>>
>> Userspace command aborts
>>
>> As it stands we cannot abort I/O commands from userspace.
>> This is hitting us when running in a virtual machine:
>> The VM sets a timeout when submitting a command, but that
>> information can't be transmitted to the VM host. The VM host
>> then issues a different command (with another timeout), and
>> again that timeout can't be transmitted to the attached devices.
>> So when the VM detects a timeout, it will try to issue an abort,
>> but that goes nowhere as the VM host has no way to abort commands
>> from userspace.
>> So in the end the VM has to wait for the command to complete, causing
>> stalls in the VM if the host had to undergo error recovery or something.
>
> Aborts are racy. A lot of hardware implements these as a no-op, too.
>
I'd avoid implementing userspace aborts and fix things in spec first.
-ck
next prev parent reply other threads:[~2023-02-17 18:54 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-16 11:50 [LSF/MM/BPF BOF] Userspace command abouts Hannes Reinecke
2023-02-16 16:40 ` Keith Busch
2023-02-17 18:53 ` Chaitanya Kulkarni [this message]
2023-02-18 9:50 ` [LSF/MM/BPF BOF] Userspace command aborts Hannes Reinecke
2023-02-21 18:15 ` Chaitanya Kulkarni
2023-02-20 11:24 ` [LSF/MM/BPF BOF] Userspace command abouts Sagi Grimberg
2023-02-21 16:25 ` Douglas Gilbert
2023-02-22 14:37 ` Sagi Grimberg
2023-02-22 14:53 ` Keith Busch
2023-02-23 15:35 ` Sagi Grimberg
2023-02-24 23:54 ` Chaitanya Kulkarni
2023-02-25 1:51 ` Keith Busch
2023-02-25 4:15 ` Damien Le Moal
2023-02-25 16:14 ` James Smart
2023-02-27 16:33 ` Sagi Grimberg
2023-02-27 17:28 ` Hannes Reinecke
2023-02-27 17:44 ` Keith Busch
2023-02-27 21:18 ` Damien Le Moal
2023-02-27 21:42 ` Damien Le Moal
2023-02-28 8:05 ` Sagi Grimberg
2023-02-27 21:17 ` Damien Le Moal
2023-02-27 8:20 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e7b781d8-d5a7-cf7f-f681-c116fbadfd01@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=hare@suse.de \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=lsf-pc@lists.linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox