From: Damien Le Moal <dlemoal@kernel.org>
To: Guenter Roeck <linux@roeck-us.net>,
Bart Van Assche <bvanassche@acm.org>,
"Martin K . Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org, Brian Bunker <brian@purestorage.com>,
Hannes Reinecke <hare@suse.de>,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>
Subject: Re: [PATCH 2/2] scsi: core: Convert inquiry information
Date: Thu, 14 May 2026 08:55:46 +0900 [thread overview]
Message-ID: <787e03b1-2765-4f31-ab8b-bfbb8bdc7863@kernel.org> (raw)
In-Reply-To: <8f801fd4-6a52-438f-8c99-1cfa28b058df@roeck-us.net>
On 2026/05/14 3:40, Guenter Roeck wrote:
> On 5/13/26 10:26, Bart Van Assche wrote:
>> On 5/13/26 1:03 AM, Damien Le Moal wrote:
>>> On 5/13/26 04:46, Bart Van Assche wrote:
>>>> Currently the vendor, model, and revision members of struct scsi_device
>>>> are pointers to fixed-length strings that are not NUL-terminated.
>>>
>>> s/NUL/NULL
>> Really? NUL is the correct spelling according to
>> https://en.wikipedia.org/wiki/ASCII and also according to any other
>> ASCII table I have ever seen.
>>
>
> Maybe the confusion is NULL pointer (or NULL-terminated array)
> vs. NUL-terminated string ?
Ah, yes, indeed. Please ignore my comment.
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2026-05-13 23:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-12 19:46 [PATCH 0/2] Rework the struct scsi_device inquiry information Bart Van Assche
2026-05-12 19:46 ` [PATCH 1/2] scsi: core, target: Move three constants into <scsi/scsi_common.h> Bart Van Assche
2026-05-13 8:04 ` Damien Le Moal
2026-05-13 9:28 ` Hannes Reinecke
2026-05-12 19:46 ` [PATCH 2/2] scsi: core: Convert inquiry information Bart Van Assche
2026-05-13 8:03 ` Damien Le Moal
2026-05-13 17:26 ` Bart Van Assche
2026-05-13 18:40 ` Guenter Roeck
2026-05-13 23:55 ` Damien Le Moal [this message]
2026-05-13 9:33 ` Hannes Reinecke
2026-05-13 17:40 ` Bart Van Assche
2026-05-13 12:49 ` James Bottomley
2026-05-13 17:49 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=787e03b1-2765-4f31-ab8b-bfbb8bdc7863@kernel.org \
--to=dlemoal@kernel.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=brian@purestorage.com \
--cc=bvanassche@acm.org \
--cc=hare@suse.de \
--cc=linux-scsi@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox