From: John Garry <john.g.garry@oracle.com>
To: Jason Yan <yanaijie@huawei.com>,
martin.petersen@oracle.com, jejb@linux.ibm.com
Cc: linux-scsi@vger.kernel.org, hare@suse.com, hch@lst.de,
bvanassche@acm.org, jinpu.wang@cloud.ionos.com,
damien.lemoal@opensource.wdc.com
Subject: Re: [PATCH 4/6] scsi: libsas: remove useless dev_list delete in sas_ex_discover_end_dev()
Date: Thu, 8 Dec 2022 10:40:42 +0000 [thread overview]
Message-ID: <8e077620-e0e8-71f0-0a77-66fd91320a78@oracle.com> (raw)
In-Reply-To: <1a1f0169-bb89-c9fb-b26a-f8c03c669bd3@huawei.com>
On 08/12/2022 07:21, Jason Yan wrote:
>>> t_list_del:
>>> sas_rphy_free(child->rphy);
>>> list_del(&child->disco_list_node);
>>> - spin_lock_irq(&parent->port->dev_list_lock);
>>> - list_del(&child->dev_list_node);
>>> - spin_unlock_irq(&parent->port->dev_list_lock);
>>
>> Since we have the spin lock'ing, this seems to be have been
>> intentionally added (and not some simple typo or similar) - any idea
>> of the origin?
>
> The new device used to be added to the dev_list in this function. But
> after 92625f9bff38 ("[SCSI] libsas: restore scan order") and
> 87c8331fcf72 ("[SCSI] libsas: prevent domain rediscovery competing with
> ata error handling") it is added to the disco_list instead. But the
> list_del() and locking is forgot to be removed.
OK, so can we have a fixes tag then? That even helps review, as I can
then quickly see where we went wrong.
Thanks,
John
next prev parent reply other threads:[~2022-12-08 10:46 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-04 8:16 [PATCH 0/6] scsi: libsas: Some coding style fixes and cleanups Jason Yan
2022-12-04 8:16 ` [PATCH 1/6] scsi: libsas: move sas_get_ata_command_set() up to save the declaration Jason Yan
2022-12-05 8:45 ` John Garry
2022-12-08 6:36 ` Jason Yan
2022-12-04 8:16 ` [PATCH 2/6] scsi: libsas: delete wrapper function sas_discover_end_dev() Jason Yan
2022-12-05 8:57 ` John Garry
2022-12-08 6:56 ` Jason Yan
2022-12-04 8:16 ` [PATCH 3/6] scsi: libsas: rename sas_discover_sata() and related refactors Jason Yan
2022-12-04 8:16 ` [PATCH 4/6] scsi: libsas: remove useless dev_list delete in sas_ex_discover_end_dev() Jason Yan
2022-12-05 9:14 ` John Garry
2022-12-08 7:21 ` Jason Yan
2022-12-08 10:40 ` John Garry [this message]
2022-12-08 11:11 ` Jason Yan
2022-12-04 8:16 ` [PATCH 5/6] scsi: libsas: factor out sas_ata_add_dev() Jason Yan
2022-12-05 9:24 ` John Garry
2022-12-08 7:26 ` Jason Yan
2022-12-04 8:16 ` [PATCH 6/6] scsi: libsas: factor out sas_ex_add_dev() Jason Yan
2022-12-05 9:31 ` John Garry
2022-12-08 8:07 ` Jason Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e077620-e0e8-71f0-0a77-66fd91320a78@oracle.com \
--to=john.g.garry@oracle.com \
--cc=bvanassche@acm.org \
--cc=damien.lemoal@opensource.wdc.com \
--cc=hare@suse.com \
--cc=hch@lst.de \
--cc=jejb@linux.ibm.com \
--cc=jinpu.wang@cloud.ionos.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=yanaijie@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox