From: Jason Yan <yanaijie@huawei.com>
To: John Garry <john.g.garry@oracle.com>,
<martin.petersen@oracle.com>, <jejb@linux.ibm.com>
Cc: <linux-scsi@vger.kernel.org>, <hare@suse.com>, <hch@lst.de>,
<bvanassche@acm.org>, <jinpu.wang@cloud.ionos.com>,
<damien.lemoal@opensource.wdc.com>
Subject: Re: [PATCH 5/6] scsi: libsas: factor out sas_ata_add_dev()
Date: Thu, 8 Dec 2022 15:26:27 +0800 [thread overview]
Message-ID: <a05a403d-b663-8255-c9b0-9882ebe05032@huawei.com> (raw)
In-Reply-To: <9eeaad19-c1e6-f401-3bdf-a7c3d0b3ab77@oracle.com>
On 2022/12/5 17:24, John Garry wrote:
> On 04/12/2022 08:16, Jason Yan wrote:
>> +static inline int sas_ata_add_dev(struct domain_device *parent,
>> struct ex_phy *phy,
>> + struct domain_device *child, int phy_id)
>> +{
>> + pr_notice("ATA is not enabled, target proto 0x%x at %016llx:0x%x\n",
>
> nit: how about add "SCSI_SAS_ATA is not enabled ..." or use similar to
> the log in sas_discover_domain()?
Yes, make sense. Will update.
Thanks,
Jason
>
>> + phy->attached_tproto, SAS_ADDR(parent->sas_addr), phy_id);
>> + return -ENODEV;
>
> .
next prev parent reply other threads:[~2022-12-08 7:26 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-04 8:16 [PATCH 0/6] scsi: libsas: Some coding style fixes and cleanups Jason Yan
2022-12-04 8:16 ` [PATCH 1/6] scsi: libsas: move sas_get_ata_command_set() up to save the declaration Jason Yan
2022-12-05 8:45 ` John Garry
2022-12-08 6:36 ` Jason Yan
2022-12-04 8:16 ` [PATCH 2/6] scsi: libsas: delete wrapper function sas_discover_end_dev() Jason Yan
2022-12-05 8:57 ` John Garry
2022-12-08 6:56 ` Jason Yan
2022-12-04 8:16 ` [PATCH 3/6] scsi: libsas: rename sas_discover_sata() and related refactors Jason Yan
2022-12-04 8:16 ` [PATCH 4/6] scsi: libsas: remove useless dev_list delete in sas_ex_discover_end_dev() Jason Yan
2022-12-05 9:14 ` John Garry
2022-12-08 7:21 ` Jason Yan
2022-12-08 10:40 ` John Garry
2022-12-08 11:11 ` Jason Yan
2022-12-04 8:16 ` [PATCH 5/6] scsi: libsas: factor out sas_ata_add_dev() Jason Yan
2022-12-05 9:24 ` John Garry
2022-12-08 7:26 ` Jason Yan [this message]
2022-12-04 8:16 ` [PATCH 6/6] scsi: libsas: factor out sas_ex_add_dev() Jason Yan
2022-12-05 9:31 ` John Garry
2022-12-08 8:07 ` Jason Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a05a403d-b663-8255-c9b0-9882ebe05032@huawei.com \
--to=yanaijie@huawei.com \
--cc=bvanassche@acm.org \
--cc=damien.lemoal@opensource.wdc.com \
--cc=hare@suse.com \
--cc=hch@lst.de \
--cc=jejb@linux.ibm.com \
--cc=jinpu.wang@cloud.ionos.com \
--cc=john.g.garry@oracle.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox