From: Christoph Hellwig <hch@infradead.org>
To: Brian Bunker <brian@purestorage.com>
Cc: linux-scsi@vger.kernel.org, Hannes Reinecke <hare@suse.de>
Subject: Re: [PATCH 1/1] scsi_dh_alua: properly handling the ALUA transitioning state
Date: Mon, 23 May 2022 22:25:42 -0700 [thread overview]
Message-ID: <YoxsVi0EYuWQxcoO@infradead.org> (raw)
In-Reply-To: <CAHZQxy+4sTPz9+pY3=7VJH+CLUJsDct81KtnR2be8ycN5mhqTg@mail.gmail.com>
On Mon, May 02, 2022 at 08:09:17AM -0700, Brian Bunker wrote:
> case SCSI_ACCESS_STATE_ACTIVE:
> case SCSI_ACCESS_STATE_LBA:
> - return BLK_STS_OK;
> case SCSI_ACCESS_STATE_TRANSITIONING:
> - return BLK_STS_AGAIN;
> + return BLK_STS_OK;
As there is a lot of discussion on BLK_STS_AGAIN in the thread:
Independent of the actul outcome here, BLK_STS_AGAIN is fundamentally
the wrong thing to return here. BLK_STS_AGAIN must only be returned
for REQ_NOWAIT requests that would have to block.
next prev parent reply other threads:[~2022-05-24 5:25 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-02 15:09 [PATCH 1/1] scsi_dh_alua: properly handling the ALUA transitioning state Brian Bunker
2022-05-02 16:22 ` Hannes Reinecke
2022-05-03 0:50 ` Martin K. Petersen
2022-05-20 10:57 ` Martin Wilck
2022-05-20 12:06 ` Hannes Reinecke
2022-05-20 14:03 ` Martin Wilck
2022-05-20 19:08 ` Mike Christie
2022-05-20 20:03 ` Martin Wilck
2022-05-21 2:52 ` Brian Bunker
2022-05-23 16:03 ` Martin Wilck
2022-05-23 16:52 ` Brian Bunker
2022-05-24 8:29 ` Martin Wilck
2022-05-21 10:17 ` Hannes Reinecke
2022-05-23 15:33 ` Martin Wilck
2022-05-21 16:58 ` Mike Christie
2022-05-24 5:25 ` Christoph Hellwig [this message]
2022-05-24 5:33 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YoxsVi0EYuWQxcoO@infradead.org \
--to=hch@infradead.org \
--cc=brian@purestorage.com \
--cc=hare@suse.de \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox