From: Hannes Reinecke <hare@suse.de>
To: Christoph Hellwig <hch@infradead.org>,
Brian Bunker <brian@purestorage.com>
Cc: linux-scsi@vger.kernel.org
Subject: Re: [PATCH 1/1] scsi_dh_alua: properly handling the ALUA transitioning state
Date: Tue, 24 May 2022 07:33:53 +0200 [thread overview]
Message-ID: <c96e668c-88f9-f883-e580-eb93e6a75595@suse.de> (raw)
In-Reply-To: <YoxsVi0EYuWQxcoO@infradead.org>
On 5/24/22 07:25, Christoph Hellwig wrote:
> On Mon, May 02, 2022 at 08:09:17AM -0700, Brian Bunker wrote:
>> case SCSI_ACCESS_STATE_ACTIVE:
>> case SCSI_ACCESS_STATE_LBA:
>> - return BLK_STS_OK;
>> case SCSI_ACCESS_STATE_TRANSITIONING:
>> - return BLK_STS_AGAIN;
>> + return BLK_STS_OK;
>
> As there is a lot of discussion on BLK_STS_AGAIN in the thread:
> Independent of the actual outcome here, BLK_STS_AGAIN is fundamentally
> the wrong thing to return here. BLK_STS_AGAIN must only be returned
> for REQ_NOWAIT requests that would have to block.
Guess we should document that.
It wasn't clear to me that this is a requirement.
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Ivo Totev, Andrew
Myers, Andrew McDonald, Martje Boudien Moerman
prev parent reply other threads:[~2022-05-24 5:34 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-02 15:09 [PATCH 1/1] scsi_dh_alua: properly handling the ALUA transitioning state Brian Bunker
2022-05-02 16:22 ` Hannes Reinecke
2022-05-03 0:50 ` Martin K. Petersen
2022-05-20 10:57 ` Martin Wilck
2022-05-20 12:06 ` Hannes Reinecke
2022-05-20 14:03 ` Martin Wilck
2022-05-20 19:08 ` Mike Christie
2022-05-20 20:03 ` Martin Wilck
2022-05-21 2:52 ` Brian Bunker
2022-05-23 16:03 ` Martin Wilck
2022-05-23 16:52 ` Brian Bunker
2022-05-24 8:29 ` Martin Wilck
2022-05-21 10:17 ` Hannes Reinecke
2022-05-23 15:33 ` Martin Wilck
2022-05-21 16:58 ` Mike Christie
2022-05-24 5:25 ` Christoph Hellwig
2022-05-24 5:33 ` Hannes Reinecke [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c96e668c-88f9-f883-e580-eb93e6a75595@suse.de \
--to=hare@suse.de \
--cc=brian@purestorage.com \
--cc=hch@infradead.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox