From: Bart Van Assche <bvanassche@acm.org>
To: Bean Huo <huobean@gmail.com>,
alim.akhtar@samsung.com, avri.altman@wdc.com,
asutoshd@codeaurora.org, jejb@linux.ibm.com,
martin.petersen@oracle.com, stanley.chu@mediatek.com,
beanhuo@micron.com, tomas.winkler@intel.com, cang@codeaurora.org
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 5/9] scsi: ufs: Delete two unnecessary functions
Date: Thu, 16 Jan 2020 19:58:08 -0800 [thread overview]
Message-ID: <b315bf53-6b64-0e1f-ffd4-823dce99954e@acm.org> (raw)
In-Reply-To: <20200116215914.16015-6-huobean@gmail.com>
On 2020-01-16 13:59, Bean Huo wrote:
> From: Bean Huo <beanhuo@micron.com>
>
> Delete ufshcd_read_power_desc() and ufshcd_read_device_desc(), directly
> inline ufshcd_read_desc() into its callers.
How about changing the subject into "Inline two functions into their
callers"? Otherwise this patch looks fine to me.
Thanks,
Bart.
next prev parent reply other threads:[~2020-01-17 3:58 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-16 21:59 [PATCH v2 0/9] Use UFS device indicated maximum LU number Bean Huo
2020-01-16 21:59 ` [PATCH v2 1/9] scsi: ufs: goto with returned value while failed to add WL Bean Huo
2020-01-17 3:56 ` Bart Van Assche
2020-01-17 12:57 ` [EXT] " Bean Huo (beanhuo)
2020-01-17 18:23 ` Asutosh Das (asd)
2020-01-16 21:59 ` [PATCH v2 2/9] scsi: ufs: Delete struct ufs_dev_desc Bean Huo
2020-01-17 3:53 ` Bart Van Assche
2020-01-17 12:55 ` [EXT] " Bean Huo (beanhuo)
2020-01-17 18:21 ` Asutosh Das (asd)
2020-01-16 21:59 ` [PATCH v2 3/9] scsi: ufs: Split ufshcd_probe_hba() based on its called flow Bean Huo
2020-01-17 20:13 ` Asutosh Das (asd)
2020-01-16 21:59 ` [PATCH v2 4/9] scsi: ufs: Move ufshcd_get_max_pwr_mode() to ufs_init_params() Bean Huo
2020-01-16 21:59 ` [PATCH v2 5/9] scsi: ufs: Delete two unnecessary functions Bean Huo
2020-01-17 3:58 ` Bart Van Assche [this message]
2020-01-17 13:32 ` [EXT] " Bean Huo (beanhuo)
2020-01-16 21:59 ` [PATCH v2 6/9] scsi: ufs: Delete is_init_prefetch from struct ufs_hba Bean Huo
2020-01-17 4:00 ` Bart Van Assche
2020-01-17 13:12 ` [EXT] " Bean Huo (beanhuo)
2020-01-16 21:59 ` [PATCH v2 7/9] scsi: ufs: Add max_lu_supported in struct ufs_dev_info Bean Huo
2020-01-17 4:02 ` Bart Van Assche
2020-01-17 13:17 ` [EXT] " Bean Huo (beanhuo)
2020-01-16 21:59 ` [PATCH v2 8/9] scsi: ufs: Initialize max_lu_supported Bean Huo
2020-01-16 21:59 ` [PATCH v2 9/9] scsi: ufs: Use UFS device indicated maximum LU number Bean Huo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b315bf53-6b64-0e1f-ffd4-823dce99954e@acm.org \
--to=bvanassche@acm.org \
--cc=alim.akhtar@samsung.com \
--cc=asutoshd@codeaurora.org \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=cang@codeaurora.org \
--cc=huobean@gmail.com \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=stanley.chu@mediatek.com \
--cc=tomas.winkler@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox