* Re: [PATCH] qla2xxx: Remove return value from qla_nvme_ls()
2020-05-20 13:08 [PATCH] qla2xxx: Remove return value from qla_nvme_ls() Daniel Wagner
@ 2020-05-20 13:36 ` Johannes Thumshirn
2020-05-20 15:51 ` Bart Van Assche
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Johannes Thumshirn @ 2020-05-20 13:36 UTC (permalink / raw)
To: Daniel Wagner, linux-scsi@vger.kernel.org
Cc: Arun Easi, Nilesh Javali, Himanshu Madhani, Hannes Reinecke,
Martin Wilck, Roman Bolshakov
Looks good,
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] qla2xxx: Remove return value from qla_nvme_ls()
2020-05-20 13:08 [PATCH] qla2xxx: Remove return value from qla_nvme_ls() Daniel Wagner
2020-05-20 13:36 ` Johannes Thumshirn
@ 2020-05-20 15:51 ` Bart Van Assche
2020-05-20 16:03 ` Roman Bolshakov
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Bart Van Assche @ 2020-05-20 15:51 UTC (permalink / raw)
To: Daniel Wagner, linux-scsi
Cc: Arun Easi, Nilesh Javali, Himanshu Madhani, Hannes Reinecke,
Martin Wilck, Roman Bolshakov
On 2020-05-20 06:08, Daniel Wagner wrote:
> The function always returns QLA_SUCCESS and the caller
> qla2x00_start_sp() doesn't even evalute the return value. So there is
> no point in returning a status.
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] qla2xxx: Remove return value from qla_nvme_ls()
2020-05-20 13:08 [PATCH] qla2xxx: Remove return value from qla_nvme_ls() Daniel Wagner
2020-05-20 13:36 ` Johannes Thumshirn
2020-05-20 15:51 ` Bart Van Assche
@ 2020-05-20 16:03 ` Roman Bolshakov
2020-05-20 16:41 ` Himanshu Madhani
2020-05-27 2:12 ` Martin K. Petersen
4 siblings, 0 replies; 6+ messages in thread
From: Roman Bolshakov @ 2020-05-20 16:03 UTC (permalink / raw)
To: Daniel Wagner
Cc: linux-scsi, Arun Easi, Nilesh Javali, Himanshu Madhani,
Hannes Reinecke, Martin Wilck
On Wed, May 20, 2020 at 03:08:19PM +0200, Daniel Wagner wrote:
> The function always returns QLA_SUCCESS and the caller
> qla2x00_start_sp() doesn't even evalute the return value. So there is
> no point in returning a status.
>
> Signed-off-by: Daniel Wagner <dwagner@suse.de>
> ---
> drivers/scsi/qla2xxx/qla_iocb.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/scsi/qla2xxx/qla_iocb.c b/drivers/scsi/qla2xxx/qla_iocb.c
> index b039bd83f947..8865c35d3421 100644
> --- a/drivers/scsi/qla2xxx/qla_iocb.c
> +++ b/drivers/scsi/qla2xxx/qla_iocb.c
> @@ -3607,11 +3607,10 @@ static void qla2x00_send_notify_ack_iocb(srb_t *sp,
> /*
> * Build NVME LS request
> */
> -static int
> +static void
> qla_nvme_ls(srb_t *sp, struct pt_ls4_request *cmd_pkt)
> {
> struct srb_iocb *nvme;
> - int rval = QLA_SUCCESS;
>
> nvme = &sp->u.iocb_cmd;
> cmd_pkt->entry_type = PT_LS4_REQUEST;
> @@ -3631,8 +3630,6 @@ qla_nvme_ls(srb_t *sp, struct pt_ls4_request *cmd_pkt)
> cmd_pkt->rx_byte_count = cpu_to_le32(nvme->u.nvme.rsp_len);
> cmd_pkt->dsd[1].length = cpu_to_le32(nvme->u.nvme.rsp_len);
> put_unaligned_le64(nvme->u.nvme.rsp_dma, &cmd_pkt->dsd[1].address);
> -
> - return rval;
> }
>
> static void
> --
> 2.16.4
>
Reviewed-by: Roman Bolshakov <r.bolshakov@yadro.com>
Thanks,
Roman
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] qla2xxx: Remove return value from qla_nvme_ls()
2020-05-20 13:08 [PATCH] qla2xxx: Remove return value from qla_nvme_ls() Daniel Wagner
` (2 preceding siblings ...)
2020-05-20 16:03 ` Roman Bolshakov
@ 2020-05-20 16:41 ` Himanshu Madhani
2020-05-27 2:12 ` Martin K. Petersen
4 siblings, 0 replies; 6+ messages in thread
From: Himanshu Madhani @ 2020-05-20 16:41 UTC (permalink / raw)
To: Daniel Wagner, linux-scsi
Cc: Arun Easi, Nilesh Javali, Hannes Reinecke, Martin Wilck,
Roman Bolshakov
Daniel,
On 5/20/20 8:08 AM, Daniel Wagner wrote:
> The function always returns QLA_SUCCESS and the caller
> qla2x00_start_sp() doesn't even evalute the return value. So there is
> no point in returning a status.
>
> Signed-off-by: Daniel Wagner<dwagner@suse.de>
> ---
Good Catch.
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
--
Himanshu Madhani Oracle Linux Engineering
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] qla2xxx: Remove return value from qla_nvme_ls()
2020-05-20 13:08 [PATCH] qla2xxx: Remove return value from qla_nvme_ls() Daniel Wagner
` (3 preceding siblings ...)
2020-05-20 16:41 ` Himanshu Madhani
@ 2020-05-27 2:12 ` Martin K. Petersen
4 siblings, 0 replies; 6+ messages in thread
From: Martin K. Petersen @ 2020-05-27 2:12 UTC (permalink / raw)
To: linux-scsi, Daniel Wagner
Cc: Martin K . Petersen, Hannes Reinecke, Arun Easi, Himanshu Madhani,
Roman Bolshakov, Nilesh Javali, Martin Wilck
On Wed, 20 May 2020 15:08:19 +0200, Daniel Wagner wrote:
> The function always returns QLA_SUCCESS and the caller
> qla2x00_start_sp() doesn't even evalute the return value. So there is
> no point in returning a status.
Applied to 5.8/scsi-queue, thanks!
[1/1] scsi: qla2xxx: Remove return value from qla_nvme_ls()
https://git.kernel.org/mkp/scsi/c/ac988c49367a
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 6+ messages in thread