[PATCH] scsi:ufs:core: update compl_time_stamp_local_clock after complete a cqe

[PATCH] scsi:ufs:core: update compl_time_stamp_local_clock after complete a cqe

[liuderong]

From: liuderong <liuderong@oppo.com>

For now, lrbp->compl_time_stamp_local_clock is set to zero
after send a sqe, but it is not updated after complete a cqe,
the printed information in ufshcd_print_tr will always be zero.
So update lrbp->cmpl_time_stamp_local_clock after complete a cqe.

Log sample:
ufshcd-qcom 1d84000.ufshc: UPIU[8] - issue time 8750227249 us
ufshcd-qcom 1d84000.ufshc: UPIU[8] - complete time 0 us

Signed-off-by: liuderong <liuderong@oppo.com>
---
 drivers/ufs/core/ufshcd.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
index 6a26853..bd70fe1 100644
--- a/drivers/ufs/core/ufshcd.c
+++ b/drivers/ufs/core/ufshcd.c
@@ -5519,6 +5519,7 @@ void ufshcd_compl_one_cqe(struct ufs_hba *hba, int task_tag,
 
 	lrbp = &hba->lrb[task_tag];
 	lrbp->compl_time_stamp = ktime_get();
+	lrbp->compl_time_stamp_local_clock = local_clock();
 	cmd = lrbp->cmd;
 	if (cmd) {
 		if (unlikely(ufshcd_should_inform_monitor(hba, lrbp)))
-- 
2.7.4

Re: [PATCH] scsi:ufs:core: update compl_time_stamp_local_clock after complete a cqe

[Bean Huo]

On Wed, 2024-12-04 at 19:50 +0800, liuderong@oppo.com wrote:
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
> index 6a26853..bd70fe1 100644
> --- a/drivers/ufs/core/ufshcd.c
> +++ b/drivers/ufs/core/ufshcd.c
> @@ -5519,6 +5519,7 @@ void ufshcd_compl_one_cqe(struct ufs_hba *hba,
> int task_tag,
>  
>         lrbp = &hba->lrb[task_tag];
>         lrbp->compl_time_stamp = ktime_get();
> +       lrbp->compl_time_stamp_local_clock = local_clock();

probably, we should change lrbp->compl_time_stamp = ktime_get(); to
lrbp->compl_time_stamp = local_clock(); also, the name of
compl_time_stamp_local_clock, is so long, should be shorter. 


but the patch is ok to me:

Reviewed-by: Bean Huo <beanhuo@micron.com>

Re: [PATCH] scsi:ufs:core: update compl_time_stamp_local_clock after complete a cqe

[Peter Wang (王信友)]

On Wed, 2024-12-04 at 19:50 +0800, liuderong@oppo.com wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> From: liuderong <liuderong@oppo.com>
> 
> For now, lrbp->compl_time_stamp_local_clock is set to zero
> after send a sqe, but it is not updated after complete a cqe,
> the printed information in ufshcd_print_tr will always be zero.
> So update lrbp->cmpl_time_stamp_local_clock after complete a cqe.
> 
> Log sample:
> ufshcd-qcom 1d84000.ufshc: UPIU[8] - issue time 8750227249 us
> ufshcd-qcom 1d84000.ufshc: UPIU[8] - complete time 0 us
> 
> Signed-off-by: liuderong <liuderong@oppo.com>
> ---
>  drivers/ufs/core/ufshcd.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
> index 6a26853..bd70fe1 100644
> --- a/drivers/ufs/core/ufshcd.c
> +++ b/drivers/ufs/core/ufshcd.c
> @@ -5519,6 +5519,7 @@ void ufshcd_compl_one_cqe(struct ufs_hba *hba,
> int task_tag,
> 
>         lrbp = &hba->lrb[task_tag];
>         lrbp->compl_time_stamp = ktime_get();
> +       lrbp->compl_time_stamp_local_clock = local_clock();
>         cmd = lrbp->cmd;
>         if (cmd) {
>                 if (unlikely(ufshcd_should_inform_monitor(hba,
> lrbp)))
> --
> 2.7.4

Reviewed-by: Peter Wang <peter.wang@mediatek.com>


> 

RE: [PATCH] scsi:ufs:core: update compl_time_stamp_local_clock after complete a cqe

[Avri Altman]

> 
> From: liuderong <liuderong@oppo.com>
> 
> For now, lrbp->compl_time_stamp_local_clock is set to zero after send a sqe,
> but it is not updated after complete a cqe, the printed information in
> ufshcd_print_tr will always be zero.
> So update lrbp->cmpl_time_stamp_local_clock after complete a cqe.
> 
> Log sample:
> ufshcd-qcom 1d84000.ufshc: UPIU[8] - issue time 8750227249 us ufshcd-qcom
> 1d84000.ufshc: UPIU[8] - complete time 0 us
Fixes tag?
I think that the commit that dropped updating it is:
c30d8d010b5e scsi: ufs: core: Prepare for completion in MCQ.

Thanks,
Avri

> 
> Signed-off-by: liuderong <liuderong@oppo.com>
> ---
>  drivers/ufs/core/ufshcd.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c index
> 6a26853..bd70fe1 100644
> --- a/drivers/ufs/core/ufshcd.c
> +++ b/drivers/ufs/core/ufshcd.c
> @@ -5519,6 +5519,7 @@ void ufshcd_compl_one_cqe(struct ufs_hba *hba,
> int task_tag,
> 
>         lrbp = &hba->lrb[task_tag];
>         lrbp->compl_time_stamp = ktime_get();
> +       lrbp->compl_time_stamp_local_clock = local_clock();
>         cmd = lrbp->cmd;
>         if (cmd) {
>                 if (unlikely(ufshcd_should_inform_monitor(hba, lrbp)))
> --
> 2.7.4