Linux SCSI subsystem development
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Qiliang Yuan" <qiliang.yuan@linux.dev>
Cc: linux-scsi@vger.kernel.org, target-devel@vger.kernel.org
Subject: Re: [PATCH RFC 12/18] scsi: target: uring: Support SYNCHRONIZE CACHE
Date: Mon, 16 Nov 2026 00:40:14 +0000	[thread overview]
Message-ID: <sashiko-outbox-215962@kernel.org> (raw)
In-Reply-To: <20261115-feat-target-core-uring-v1-12-28cdc137eac6@linux.dev>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] scsi: target: uring: wrong flush length in
  tcmur_execute_sync_cache()
--

commit 36370455252a7c6edc07d1415bceee399ffd1ebe
Author: Qiliang Yuan <qiliang.yuan@linux.dev>

scsi: target: uring: Support SYNCHRONIZE CACHE

This commit adds TCMUR_OP_FLUSH and wires up .execute_sync_cache in
target_core_uring so SYNCHRONIZE CACHE commands are forwarded to the
userspace server.

> diff --git a/drivers/target/target_core_uring.c b/drivers/target/target_core_uring.c
> index 629419a4c8f46..f39bf7bf36d0f 100644
> --- a/drivers/target/target_core_uring.c
> +++ b/drivers/target/target_core_uring.c

[ ... ]

> @@ -257,6 +258,16 @@ static sense_reason_t tcmur_execute_rw(struct se_cmd *se_cmd,
>  			    se_cmd->data_length, sgl, sgl_nents);
>  }
>  
> +static sense_reason_t tcmur_execute_sync_cache(struct se_cmd *se_cmd)
> +{
> +	u32 block_size = se_cmd->se_dev->dev_attrib.block_size;
> +
> +	/* Pass a zero length to flush up to the end of the device */
> +	return tcmur_submit(se_cmd, TCMUR_OP_FLUSH,
> +			    se_cmd->t_task_lba * block_size,
> +			    se_cmd->data_length, NULL, 0);
> +}

[Severity: High]
Does tcmur_execute_sync_cache() pass the wrong flush length in
tcmd->desc.len by reading se_cmd->data_length?

SYNCHRONIZE CACHE (10) and SYNCHRONIZE CACHE (16) are non-data commands
(DMA_NONE), so fabrics where cmd->unknown_data_length is 0 initialize
cmd->data_length to the transport expected transfer length of 0.  When
.execute_sync_cache is set, sbc_parse_cdb() jumps to check_lba, which
computes size = sbc_get_size(cmd, sectors) even though SCF_SCSI_DATA_CDB is
not set, and passes that size to target_cmd_size_check():

drivers/target/target_core_transport.c:target_cmd_size_check() {
	if (cmd->unknown_data_length) {
		cmd->data_length = size;
	} else if (size != cmd->data_length) {
		...
		if (size > cmd->data_length) {
			cmd->se_cmd_flags |= SCF_OVERFLOW_BIT;
			cmd->residual_count = (size - cmd->data_length);
		} else {
			cmd->se_cmd_flags |= SCF_UNDERFLOW_BIT;
			cmd->residual_count = (cmd->data_length - size);
			if (cmd->data_direction == DMA_FROM_DEVICE) {
				cmd->data_length = size;
			}
		}
}

When an initiator specifies a non-zero block count on a normal fabric,
target_cmd_size_check() logs a transfer length mismatch warning, sets
SCF_OVERFLOW_BIT with a bogus residual_count, and leaves se_cmd->data_length
at 0, so tcmd->desc.len is always 0 instead of the requested range.

On fabrics that set cmd->unknown_data_length (such as USB gadget f_tcm),
setting cmd->data_length to size causes transport_generic_new_cmd() to
allocate size bytes of unused scatterlist pages via target_alloc_sgl() for a
DMA_NONE command.  In addition, both sbc_get_size() and se_cmd->data_length
are 32-bit u32 values, which truncates 32-bit SYNCHRONIZE_CACHE_16 block
counts when the byte range reaches 4 GiB.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261115-feat-target-core-uring-v1-0-28cdc137eac6@linux.dev?part=12

  reply	other threads:[~2026-11-16  0:40 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16  0:17 [PATCH RFC 00/18] scsi: target: Add target_core_uring, an io_uring based user backstore Qiliang Yuan
2026-11-16  0:17 ` [PATCH RFC 01/18] scsi: target: uring: Introduce " Qiliang Yuan
2026-11-16  0:38   ` sashiko-bot
2026-11-16  0:17 ` [PATCH RFC 02/18] scsi: target: uring: Allocate per-queue command descriptors Qiliang Yuan
2026-11-16  0:17 ` [PATCH RFC 03/18] scsi: target: uring: Create a character device per backstore device Qiliang Yuan
2026-11-16  0:33   ` sashiko-bot
2026-11-16  0:17 ` [PATCH RFC 04/18] scsi: target: uring: Map the command descriptors into the server Qiliang Yuan
2026-11-16  0:17 ` [PATCH RFC 05/18] scsi: target: uring: Queue commands until a server fetches them Qiliang Yuan
2026-11-16  0:46   ` sashiko-bot
2026-11-16  0:17 ` [PATCH RFC 06/18] scsi: target: uring: Hand commands out through TCMUR_IO_FETCH Qiliang Yuan
2026-11-16  0:18 ` [PATCH RFC 07/18] scsi: target: uring: Complete commands with TCMUR_IO_COMMIT_AND_FETCH Qiliang Yuan
2026-11-16  0:18 ` [PATCH RFC 08/18] scsi: target: uring: Copy command data with pread() and pwrite() Qiliang Yuan
2026-11-16  0:18 ` [PATCH RFC 09/18] scsi: target: uring: Fail in-flight commands when the server exits Qiliang Yuan
2026-11-16  0:18 ` [PATCH RFC 10/18] scsi: target: uring: Time out commands the server does not complete Qiliang Yuan
2026-11-16  0:41   ` sashiko-bot
2026-11-16  0:18 ` [PATCH RFC 11/18] scsi: target: uring: Drop aborted commands that are still queued Qiliang Yuan
2026-11-16  0:37   ` sashiko-bot
2026-11-16  0:18 ` [PATCH RFC 12/18] scsi: target: uring: Support SYNCHRONIZE CACHE Qiliang Yuan
2026-11-16  0:40   ` sashiko-bot [this message]
2026-11-16  0:18 ` [PATCH RFC 13/18] scsi: target: uring: Implement UNMAP Qiliang Yuan
2026-11-16  0:45   ` sashiko-bot
2026-11-16  0:18 ` [PATCH RFC 14/18] scsi: target: uring: Handle WRITE SAME Qiliang Yuan
2026-11-16  0:44   ` sashiko-bot
2026-11-16  0:18 ` [PATCH RFC 15/18] scsi: target: uring: Register command data as io_uring fixed buffers Qiliang Yuan
2026-11-16  0:18 ` [PATCH RFC 16/18] selftests: target_core_uring: Add a minimal server Qiliang Yuan
2026-11-16  1:03   ` sashiko-bot
2026-11-16  0:18 ` [PATCH RFC 17/18] selftests: target_core_uring: Test a device exported through tcm_loop Qiliang Yuan
2026-11-16  0:49   ` sashiko-bot
2026-11-16  0:18 ` [PATCH RFC 18/18] Documentation: target: Describe the uring backstore Qiliang Yuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-215962@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=qiliang.yuan@linux.dev \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=target-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox