Linux SCSI subsystem development
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Qiliang Yuan" <qiliang.yuan@linux.dev>
Cc: linux-scsi@vger.kernel.org, target-devel@vger.kernel.org
Subject: Re: [PATCH RFC 14/18] scsi: target: uring: Handle WRITE SAME
Date: Mon, 16 Nov 2026 00:44:08 +0000	[thread overview]
Message-ID: <sashiko-outbox-215967@kernel.org> (raw)
In-Reply-To: <20261115-feat-target-core-uring-v1-14-28cdc137eac6@linux.dev>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] scsi: target: uring: missing payload checks in
  tcmur_execute_write_same()
--

commit 194f0b295175d883a8fb6c1f553cf215c122630e
Author: Qiliang Yuan <qiliang.yuan@linux.dev>

scsi: target: uring: Handle WRITE SAME

This commit adds WRITE SAME support to the target_core_uring backend via a
new TCMUR_OP_WRITE_SAME operation.

> diff --git a/drivers/target/target_core_uring.c b/drivers/target/target_core_uring.c
> index 366c5e9820956..42283a1ae1512 100644
> --- a/drivers/target/target_core_uring.c
> +++ b/drivers/target/target_core_uring.c
[ ... ]
> @@ -295,6 +297,16 @@ static sense_reason_t tcmur_execute_unmap(struct se_cmd *se_cmd, sector_t lba,
>  	return tcmd.status ? TCM_LOGICAL_UNIT_COMMUNICATION_FAILURE : 0;
>  }
>  
> +static sense_reason_t tcmur_execute_write_same(struct se_cmd *se_cmd)
> +{
> +	u32 block_size = se_cmd->se_dev->dev_attrib.block_size;
> +
> +	return tcmur_submit(se_cmd, TCMUR_OP_WRITE_SAME,
> +			    se_cmd->t_task_lba * block_size,
> +			    (u64)sbc_get_write_same_sectors(se_cmd) * block_size,
> +			    se_cmd->t_data_sg, se_cmd->t_data_nents);
> +}

[Severity: High]
Can tcmur_execute_write_same() submit a TCMUR_OP_WRITE_SAME descriptor
whose data_len is 0 or larger than block_size?

Because sbc_parse_cdb() does not set SCF_SCSI_DATA_CDB for WRITE SAME,
target_cmd_size_check() does not reject commands when an initiator sends no
data buffer (leaving t_data_sg NULL and t_data_nents 0) or a transfer
length larger than one block, nor when protection information sets
se_cmd->prot_op.  tcmur_submit() then sets desc.data_len to 0 or
se_cmd->data_length, breaking the UAPI guarantee that data_len is one block
and causing a userspace server to spin forever on a zero step or overflow a
single-block buffer.

Should tcmur_execute_write_same() validate se_cmd->prot_op,
se_cmd->t_data_nents == 1, and se_cmd->t_data_sg[0].length == block_size
the same way fd_execute_write_same() and iblock_execute_write_same() do?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261115-feat-target-core-uring-v1-0-28cdc137eac6@linux.dev?part=14

  reply	other threads:[~2026-11-16  0:44 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16  0:17 [PATCH RFC 00/18] scsi: target: Add target_core_uring, an io_uring based user backstore Qiliang Yuan
2026-11-16  0:17 ` [PATCH RFC 01/18] scsi: target: uring: Introduce " Qiliang Yuan
2026-11-16  0:38   ` sashiko-bot
2026-11-16  0:17 ` [PATCH RFC 02/18] scsi: target: uring: Allocate per-queue command descriptors Qiliang Yuan
2026-11-16  0:17 ` [PATCH RFC 03/18] scsi: target: uring: Create a character device per backstore device Qiliang Yuan
2026-11-16  0:33   ` sashiko-bot
2026-11-16  0:17 ` [PATCH RFC 04/18] scsi: target: uring: Map the command descriptors into the server Qiliang Yuan
2026-11-16  0:17 ` [PATCH RFC 05/18] scsi: target: uring: Queue commands until a server fetches them Qiliang Yuan
2026-11-16  0:46   ` sashiko-bot
2026-11-16  0:17 ` [PATCH RFC 06/18] scsi: target: uring: Hand commands out through TCMUR_IO_FETCH Qiliang Yuan
2026-11-16  0:18 ` [PATCH RFC 07/18] scsi: target: uring: Complete commands with TCMUR_IO_COMMIT_AND_FETCH Qiliang Yuan
2026-11-16  0:18 ` [PATCH RFC 08/18] scsi: target: uring: Copy command data with pread() and pwrite() Qiliang Yuan
2026-11-16  0:18 ` [PATCH RFC 09/18] scsi: target: uring: Fail in-flight commands when the server exits Qiliang Yuan
2026-11-16  0:18 ` [PATCH RFC 10/18] scsi: target: uring: Time out commands the server does not complete Qiliang Yuan
2026-11-16  0:41   ` sashiko-bot
2026-11-16  0:18 ` [PATCH RFC 11/18] scsi: target: uring: Drop aborted commands that are still queued Qiliang Yuan
2026-11-16  0:37   ` sashiko-bot
2026-11-16  0:18 ` [PATCH RFC 12/18] scsi: target: uring: Support SYNCHRONIZE CACHE Qiliang Yuan
2026-11-16  0:40   ` sashiko-bot
2026-11-16  0:18 ` [PATCH RFC 13/18] scsi: target: uring: Implement UNMAP Qiliang Yuan
2026-11-16  0:45   ` sashiko-bot
2026-11-16  0:18 ` [PATCH RFC 14/18] scsi: target: uring: Handle WRITE SAME Qiliang Yuan
2026-11-16  0:44   ` sashiko-bot [this message]
2026-11-16  0:18 ` [PATCH RFC 15/18] scsi: target: uring: Register command data as io_uring fixed buffers Qiliang Yuan
2026-11-16  0:18 ` [PATCH RFC 16/18] selftests: target_core_uring: Add a minimal server Qiliang Yuan
2026-11-16  1:03   ` sashiko-bot
2026-11-16  0:18 ` [PATCH RFC 17/18] selftests: target_core_uring: Test a device exported through tcm_loop Qiliang Yuan
2026-11-16  0:49   ` sashiko-bot
2026-11-16  0:18 ` [PATCH RFC 18/18] Documentation: target: Describe the uring backstore Qiliang Yuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-215967@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=qiliang.yuan@linux.dev \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=target-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox