Linux SCSI subsystem development
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Qiliang Yuan" <qiliang.yuan@linux.dev>
Cc: linux-scsi@vger.kernel.org, target-devel@vger.kernel.org
Subject: Re: [PATCH RFC 13/18] scsi: target: uring: Implement UNMAP
Date: Mon, 16 Nov 2026 00:45:04 +0000	[thread overview]
Message-ID: <sashiko-outbox-215968@kernel.org> (raw)
In-Reply-To: <20261115-feat-target-core-uring-v1-13-28cdc137eac6@linux.dev>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] scsi: target: uring: submission workqueue stall and TMR hang in
  tcmur_execute_unmap()
--

commit a69183b9652241c1e0d7dcfe7c2618562f084113
Author: Qiliang Yuan <qiliang.yuan@linux.dev>

scsi: target: uring: Implement UNMAP

This commit adds UNMAP support to target_core_uring by introducing
TCMUR_OP_UNMAP and synchronously waiting for each unmap range to complete
in tcmur_execute_unmap().

> diff --git a/drivers/target/target_core_uring.c b/drivers/target/target_core_uring.c
> index f39bf7bf36d0f..366c5e9820956 100644
> --- a/drivers/target/target_core_uring.c
> +++ b/drivers/target/target_core_uring.c

[ ... ]

> @@ -268,6 +275,36 @@ static sense_reason_t tcmur_execute_sync_cache(struct se_cmd *se_cmd)
>  			    se_cmd->data_length, NULL, 0);
>  }
>  
> +static sense_reason_t tcmur_execute_unmap(struct se_cmd *se_cmd, sector_t lba,
> +					  sector_t nolb)
> +{
> +	u32 block_size = se_cmd->se_dev->dev_attrib.block_size;
> +	DECLARE_COMPLETION_ONSTACK(done);
> +	struct tcmur_cmd tcmd = {
> +		.se_cmd		= se_cmd,
> +		.done		= &done,
> +		.desc.op	= TCMUR_OP_UNMAP,
> +		.desc.offset	= lba * block_size,
> +		.desc.len	= nolb * block_size,
> +	};
> +
> +	/* Wait here, as the core completes the command after all ranges */
> +	tcmur_queue_cmd(TCMUR_DEV(se_cmd->se_dev), &tcmd);
> +	wait_for_completion(&done);

[Severity: High]
Can waiting on done here stall the submission workqueue and hang task
management?

On fabrics using TARGET_QUEUE_SUBMIT (such as vhost-scsi or tcm_loop),
target_execute_cmd() runs inside target_queued_submit_work() on
dev->queues[i].sq.work.  Sleeping in wait_for_completion(&done) blocks
further commands on that queue until the server completes the unmap.

If no idle tag is available, tcmur_queue_cmd() places tcmd on q->pending.
When an ABORT_TASK or LUN_RESET arrives, core_tmr_abort_task() and
core_tmr_drain_state_list() flush sq.work before calling
dev->transport->tmr_notify() (tcmur_tmr_notify()):

sq.work                           tmr_wq
target_queued_submit_work()
  ...
    tcmur_execute_unmap()
      tcmur_queue_cmd()
      wait_for_completion(&done)
                                  core_tmr_abort_task()
                                    flush_work(&dev->queues[i].sq.work)
                                      <-- waits for sq.work
                                    ...
                                    dev->transport->tmr_notify()

Because flush_work() waits for tcmur_execute_unmap() to return,
tcmur_tmr_notify() never runs to remove tcmd from q->pending and complete
done, stalling task management until cmd_timeout expires (or forever when
cmd_time_out is 0).

Even when target_execute_cmd() runs outside sq.work, if a TMR aborts
se_cmd before tcmur_queue_cmd() queues tcmd on q->pending,
tcmur_tmr_notify() has already run and removed se_cmd from state_list, so
tcmd is never aborted and target_put_cmd_and_wait() hangs.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261115-feat-target-core-uring-v1-0-28cdc137eac6@linux.dev?part=13

  reply	other threads:[~2026-11-16  0:45 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16  0:17 [PATCH RFC 00/18] scsi: target: Add target_core_uring, an io_uring based user backstore Qiliang Yuan
2026-11-16  0:17 ` [PATCH RFC 01/18] scsi: target: uring: Introduce " Qiliang Yuan
2026-11-16  0:38   ` sashiko-bot
2026-11-16  0:17 ` [PATCH RFC 02/18] scsi: target: uring: Allocate per-queue command descriptors Qiliang Yuan
2026-11-16  0:17 ` [PATCH RFC 03/18] scsi: target: uring: Create a character device per backstore device Qiliang Yuan
2026-11-16  0:33   ` sashiko-bot
2026-11-16  0:17 ` [PATCH RFC 04/18] scsi: target: uring: Map the command descriptors into the server Qiliang Yuan
2026-11-16  0:17 ` [PATCH RFC 05/18] scsi: target: uring: Queue commands until a server fetches them Qiliang Yuan
2026-11-16  0:46   ` sashiko-bot
2026-11-16  0:17 ` [PATCH RFC 06/18] scsi: target: uring: Hand commands out through TCMUR_IO_FETCH Qiliang Yuan
2026-11-16  0:18 ` [PATCH RFC 07/18] scsi: target: uring: Complete commands with TCMUR_IO_COMMIT_AND_FETCH Qiliang Yuan
2026-11-16  0:18 ` [PATCH RFC 08/18] scsi: target: uring: Copy command data with pread() and pwrite() Qiliang Yuan
2026-11-16  0:18 ` [PATCH RFC 09/18] scsi: target: uring: Fail in-flight commands when the server exits Qiliang Yuan
2026-11-16  0:18 ` [PATCH RFC 10/18] scsi: target: uring: Time out commands the server does not complete Qiliang Yuan
2026-11-16  0:41   ` sashiko-bot
2026-11-16  0:18 ` [PATCH RFC 11/18] scsi: target: uring: Drop aborted commands that are still queued Qiliang Yuan
2026-11-16  0:37   ` sashiko-bot
2026-11-16  0:18 ` [PATCH RFC 12/18] scsi: target: uring: Support SYNCHRONIZE CACHE Qiliang Yuan
2026-11-16  0:40   ` sashiko-bot
2026-11-16  0:18 ` [PATCH RFC 13/18] scsi: target: uring: Implement UNMAP Qiliang Yuan
2026-11-16  0:45   ` sashiko-bot [this message]
2026-11-16  0:18 ` [PATCH RFC 14/18] scsi: target: uring: Handle WRITE SAME Qiliang Yuan
2026-11-16  0:44   ` sashiko-bot
2026-11-16  0:18 ` [PATCH RFC 15/18] scsi: target: uring: Register command data as io_uring fixed buffers Qiliang Yuan
2026-11-16  0:18 ` [PATCH RFC 16/18] selftests: target_core_uring: Add a minimal server Qiliang Yuan
2026-11-16  0:18 ` [PATCH RFC 17/18] selftests: target_core_uring: Test a device exported through tcm_loop Qiliang Yuan
2026-11-16  0:49   ` sashiko-bot
2026-11-16  0:18 ` [PATCH RFC 18/18] Documentation: target: Describe the uring backstore Qiliang Yuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-215968@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=qiliang.yuan@linux.dev \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=target-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox