* [patch] scsi: libfc: Remove an unneeded condition
@ 2016-11-24 10:52 Dan Carpenter
2016-11-25 8:59 ` Johannes Thumshirn
2016-11-25 15:07 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2016-11-24 10:52 UTC (permalink / raw)
To: Johannes Thumshirn, Hannes Reinecke
Cc: James E.J. Bottomley, Martin K. Petersen, fcoe-devel, linux-scsi,
kernel-janitors
We verified that resp_code is FC_SPP_RESP_ACK earlier so we don't need
to check again here.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/scsi/libfc/fc_rport.c b/drivers/scsi/libfc/fc_rport.c
index 110a707..c991f3b 100644
--- a/drivers/scsi/libfc/fc_rport.c
+++ b/drivers/scsi/libfc/fc_rport.c
@@ -1196,7 +1196,6 @@ static void fc_rport_prli_resp(struct fc_seq *sp, struct fc_frame *fp,
* Check if the image pair could be established
*/
if (rdata->spp_type != FC_TYPE_FCP ||
- resp_code != FC_SPP_RESP_ACK ||
!(pp->spp.spp_flags & FC_SPP_EST_IMG_PAIR)) {
/*
* Nope; we can't use this port as a target.
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [patch] scsi: libfc: Remove an unneeded condition
2016-11-24 10:52 [patch] scsi: libfc: Remove an unneeded condition Dan Carpenter
@ 2016-11-25 8:59 ` Johannes Thumshirn
2016-11-25 15:07 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Johannes Thumshirn @ 2016-11-25 8:59 UTC (permalink / raw)
To: Dan Carpenter
Cc: Johannes Thumshirn, Hannes Reinecke, James E.J. Bottomley,
Martin K. Petersen, fcoe-devel, linux-scsi, kernel-janitors
On Thu, Nov 24, 2016 at 01:52:38PM +0300, Dan Carpenter wrote:
> We verified that resp_code is FC_SPP_RESP_ACK earlier so we don't need
> to check again here.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
Looks good,
Acked-by: Johannes Thumshirn <jth@kernel.org>
--
Johannes Thumshirn Storage
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch] scsi: libfc: Remove an unneeded condition
2016-11-24 10:52 [patch] scsi: libfc: Remove an unneeded condition Dan Carpenter
2016-11-25 8:59 ` Johannes Thumshirn
@ 2016-11-25 15:07 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2016-11-25 15:07 UTC (permalink / raw)
To: Dan Carpenter
Cc: Johannes Thumshirn, Hannes Reinecke, James E.J. Bottomley,
Martin K. Petersen, fcoe-devel, linux-scsi, kernel-janitors
>>>>> "Dan" == Dan Carpenter <dan.carpenter@oracle.com> writes:
Dan> We verified that resp_code is FC_SPP_RESP_ACK earlier so we don't
Dan> need to check again here.
Applied to 4.10/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-11-25 16:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-24 10:52 [patch] scsi: libfc: Remove an unneeded condition Dan Carpenter
2016-11-25 8:59 ` Johannes Thumshirn
2016-11-25 15:07 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox