[PATCH 0/1] drivers/scsi: remove dead code

[PATCH 0/1] drivers/scsi: remove dead code

[Ariel Otilibili]

Hello,

This patch clears out a dead code warning.

Thank you,

Link: https://scan7.scan.coverity.com/#/project-view/52745/11354?selectedIssue=1602240

Ariel Otilibili (1):
  drivers/scsi: remove dead code

 drivers/scsi/myrb.c | 2 --
 1 file changed, 2 deletions(-)

-- 
2.47.1

[PATCH 1/1] drivers/scsi: remove dead code

[Ariel Otilibili]

* reported by Coverity ID 1602240
* ldev_info is always true, therefore the branch statement is never called.

Fixes: 081ff398c56cc ("scsi: myrb: Add Mylex RAID controller (block interface)")
Cc: Hannes Reinecke <hare@kernel.org>
Cc: "James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
Signed-off-by: Ariel Otilibili <ariel.otilibili-anieli@eurecom.fr>
---
 drivers/scsi/myrb.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/scsi/myrb.c b/drivers/scsi/myrb.c
index 363d71189cfe..dc4bd422b601 100644
--- a/drivers/scsi/myrb.c
+++ b/drivers/scsi/myrb.c
@@ -1627,8 +1627,6 @@ static int myrb_ldev_sdev_init(struct scsi_device *sdev)
 	enum raid_level level;
 
 	ldev_info = cb->ldev_info_buf + ldev_num;
-	if (!ldev_info)
-		return -ENXIO;
 
 	sdev->hostdata = kzalloc(sizeof(*ldev_info), GFP_KERNEL);
 	if (!sdev->hostdata)
-- 
2.47.1

[PING] drivers/scsi: remove dead code

[Ariel Otilibili-Anieli]

Hello,

Is there any news of the patch? Your feedback is much appreciated.

Have a good day,
Ariel

On Friday, December 13, 2024 23:57 CET, Ariel Otilibili <ariel.otilibili-anieli@eurecom.fr> wrote:

> * reported by Coverity ID 1602240
> * ldev_info is always true, therefore the branch statement is never called.
> 
> Fixes: 081ff398c56cc ("scsi: myrb: Add Mylex RAID controller (block interface)")
> Cc: Hannes Reinecke <hare@kernel.org>
> Cc: "James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>
> Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
> Signed-off-by: Ariel Otilibili <ariel.otilibili-anieli@eurecom.fr>
> ---
>  drivers/scsi/myrb.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/scsi/myrb.c b/drivers/scsi/myrb.c
> index 363d71189cfe..dc4bd422b601 100644
> --- a/drivers/scsi/myrb.c
> +++ b/drivers/scsi/myrb.c
> @@ -1627,8 +1627,6 @@ static int myrb_ldev_sdev_init(struct scsi_device *sdev)
>  	enum raid_level level;
>  
>  	ldev_info = cb->ldev_info_buf + ldev_num;
> -	if (!ldev_info)
> -		return -ENXIO;
>  
>  	sdev->hostdata = kzalloc(sizeof(*ldev_info), GFP_KERNEL);
>  	if (!sdev->hostdata)
> -- 
> 2.47.1
>

Re: [PATCH 1/1] drivers/scsi: remove dead code

[Martin K. Petersen]

Hi Ariel,

> * reported by Coverity ID 1602240
> * ldev_info is always true, therefore the branch statement is never called.

> Fixes: 081ff398c56cc ("scsi: myrb: Add Mylex RAID controller (block interface)")

Per the Fixes line above: The correct tag for this driver is "scsi:
myrb:" and not "drivers/scsi:". I fixed it up.

Applied to 6.14/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering

Re: [PATCH 1/1] drivers/scsi: remove dead code

[Ariel Otilibili-Anieli]

On Thursday, January 02, 2025 19:50 CET, "Martin K. Petersen" <martin.petersen@oracle.com> wrote:

> 
> Per the Fixes line above: The correct tag for this driver is "scsi:
> myrb:" and not "drivers/scsi:". I fixed it up.
> 
> Applied to 6.14/scsi-staging, thanks!

Hi Martin, that is awesome. Thanks for handling the patch! 

Were you referring to this tree? The commit hasn’t appeared yet.

https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git/log/?h=6.14/scsi-staging

Best regards, and happy new year,
Ariel
> 
> -- 
> Martin K. Petersen	Oracle Linux Engineering

Re: [PATCH 1/1] drivers/scsi: remove dead code

[Martin K. Petersen]

Ariel,

> Were you referring to this tree? The commit hasn’t appeared yet.

It's there now.

-- 
Martin K. Petersen	Oracle Linux Engineering

Re: [PATCH 1/1] drivers/scsi: remove dead code

[Ariel Otilibili-Anieli]

On Thursday, January 02, 2025 23:51 CET, "Martin K. Petersen" <martin.petersen@oracle.com> wrote:

> 
> Ariel,
> 
> > Were you referring to this tree? The commit hasn’t appeared yet.
> 
> It's there now.

Indeed. Thanks, Martin;
Have a good one.
> 
> -- 
> Martin K. Petersen	Oracle Linux Engineering

Re: [PATCH 1/1] drivers/scsi: remove dead code

[Martin K. Petersen]

On Fri, 13 Dec 2024 23:57:29 +0100, Ariel Otilibili wrote:

> * reported by Coverity ID 1602240
> * ldev_info is always true, therefore the branch statement is never called.
> 
> 

Applied to 6.14/scsi-queue, thanks!

[1/1] drivers/scsi: remove dead code
      https://git.kernel.org/mkp/scsi/c/850f814b01a5

-- 
Martin K. Petersen	Oracle Linux Engineering