* Re: [PATCH v2 1/1] scsi: ufs: core: Fix the HIGH/LOW_TEMP Bit Definitions
2025-01-13 18:32 [PATCH v2 1/1] scsi: ufs: core: Fix the HIGH/LOW_TEMP Bit Definitions Bao D. Nguyen
@ 2025-01-15 11:05 ` Peter Wang (王信友)
2025-01-17 16:59 ` Manivannan Sadhasivam
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Peter Wang (王信友) @ 2025-01-15 11:05 UTC (permalink / raw)
To: quic_cang@quicinc.com, manivannan.sadhasivam@linaro.org,
bvanassche@acm.org, quic_nguyenb@quicinc.com,
martin.petersen@oracle.com, avri.altman@wdc.com
Cc: linux-scsi@vger.kernel.org, beanhuo@micron.com,
stable@vger.kernel.org, daejun7.park@samsung.com,
linux-kernel@vger.kernel.org, linux@roeck-us.net
On Mon, 2025-01-13 at 10:32 -0800, Bao D. Nguyen wrote:
>
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>
>
> According to the UFS Device Specification, the
> dExtendedUFSFeaturesSupport
> defines the support for TOO_HIGH_TEMPERATURE as bit[4] and the
> TOO_LOW_TEMPERATURE as bit[5]. Correct the code to match with
> the UFS device specification definition.
>
> Fixes: e88e2d322 ("scsi: ufs: core: Probe for temperature
> notification support")
> Cc: stable@vger.kernel.org
> Signed-off-by: Bao D. Nguyen <quic_nguyenb@quicinc.com>
> Reviewed-by: Avri Altman <Avri.Altman@wdc.com>
> ---
> include/ufs/ufs.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/ufs/ufs.h b/include/ufs/ufs.h
> index e594abe..f0c6111 100644
> --- a/include/ufs/ufs.h
> +++ b/include/ufs/ufs.h
> @@ -386,8 +386,8 @@ enum {
>
> /* Possible values for dExtendedUFSFeaturesSupport */
> enum {
> - UFS_DEV_LOW_TEMP_NOTIF = BIT(4),
> - UFS_DEV_HIGH_TEMP_NOTIF = BIT(5),
> + UFS_DEV_HIGH_TEMP_NOTIF = BIT(4),
> + UFS_DEV_LOW_TEMP_NOTIF = BIT(5),
> UFS_DEV_EXT_TEMP_NOTIF = BIT(6),
> UFS_DEV_HPB_SUPPORT = BIT(7),
> UFS_DEV_WRITE_BOOSTER_SUP = BIT(8),
> --
> 2.7.4
>
Hi Bao,
Thanks for fix this bug.
Reviewed-by: Peter Wang <peter.wang@mediatek.com>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v2 1/1] scsi: ufs: core: Fix the HIGH/LOW_TEMP Bit Definitions
2025-01-13 18:32 [PATCH v2 1/1] scsi: ufs: core: Fix the HIGH/LOW_TEMP Bit Definitions Bao D. Nguyen
2025-01-15 11:05 ` Peter Wang (王信友)
@ 2025-01-17 16:59 ` Manivannan Sadhasivam
2025-01-21 17:18 ` Martin K. Petersen
2025-02-04 3:35 ` Martin K. Petersen
3 siblings, 0 replies; 5+ messages in thread
From: Manivannan Sadhasivam @ 2025-01-17 16:59 UTC (permalink / raw)
To: Bao D. Nguyen
Cc: quic_cang, bvanassche, avri.altman, peter.wang, martin.petersen,
linux-scsi, stable, Bean Huo, Daejun Park, Guenter Roeck,
open list
On Mon, Jan 13, 2025 at 10:32:07AM -0800, Bao D. Nguyen wrote:
> According to the UFS Device Specification, the dExtendedUFSFeaturesSupport
> defines the support for TOO_HIGH_TEMPERATURE as bit[4] and the
> TOO_LOW_TEMPERATURE as bit[5]. Correct the code to match with
> the UFS device specification definition.
>
> Fixes: e88e2d322 ("scsi: ufs: core: Probe for temperature notification support")
Fixes commit SHA should be 12 characters:
Fixes: e88e2d32200a ("scsi: ufs: core: Probe for temperature notification support")
- Mani
> Cc: stable@vger.kernel.org
> Signed-off-by: Bao D. Nguyen <quic_nguyenb@quicinc.com>
> Reviewed-by: Avri Altman <Avri.Altman@wdc.com>
> ---
> include/ufs/ufs.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/ufs/ufs.h b/include/ufs/ufs.h
> index e594abe..f0c6111 100644
> --- a/include/ufs/ufs.h
> +++ b/include/ufs/ufs.h
> @@ -386,8 +386,8 @@ enum {
>
> /* Possible values for dExtendedUFSFeaturesSupport */
> enum {
> - UFS_DEV_LOW_TEMP_NOTIF = BIT(4),
> - UFS_DEV_HIGH_TEMP_NOTIF = BIT(5),
> + UFS_DEV_HIGH_TEMP_NOTIF = BIT(4),
> + UFS_DEV_LOW_TEMP_NOTIF = BIT(5),
> UFS_DEV_EXT_TEMP_NOTIF = BIT(6),
> UFS_DEV_HPB_SUPPORT = BIT(7),
> UFS_DEV_WRITE_BOOSTER_SUP = BIT(8),
> --
> 2.7.4
>
--
மணிவண்ணன் சதாசிவம்
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v2 1/1] scsi: ufs: core: Fix the HIGH/LOW_TEMP Bit Definitions
2025-01-13 18:32 [PATCH v2 1/1] scsi: ufs: core: Fix the HIGH/LOW_TEMP Bit Definitions Bao D. Nguyen
2025-01-15 11:05 ` Peter Wang (王信友)
2025-01-17 16:59 ` Manivannan Sadhasivam
@ 2025-01-21 17:18 ` Martin K. Petersen
2025-02-04 3:35 ` Martin K. Petersen
3 siblings, 0 replies; 5+ messages in thread
From: Martin K. Petersen @ 2025-01-21 17:18 UTC (permalink / raw)
To: Bao D. Nguyen
Cc: quic_cang, bvanassche, avri.altman, peter.wang,
manivannan.sadhasivam, martin.petersen, linux-scsi, stable,
Bean Huo, Daejun Park, Guenter Roeck, open list
Bao,
> According to the UFS Device Specification, the
> dExtendedUFSFeaturesSupport defines the support for
> TOO_HIGH_TEMPERATURE as bit[4] and the TOO_LOW_TEMPERATURE as bit[5].
> Correct the code to match with the UFS device specification
> definition.
Applied to 6.14/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2 1/1] scsi: ufs: core: Fix the HIGH/LOW_TEMP Bit Definitions
2025-01-13 18:32 [PATCH v2 1/1] scsi: ufs: core: Fix the HIGH/LOW_TEMP Bit Definitions Bao D. Nguyen
` (2 preceding siblings ...)
2025-01-21 17:18 ` Martin K. Petersen
@ 2025-02-04 3:35 ` Martin K. Petersen
3 siblings, 0 replies; 5+ messages in thread
From: Martin K. Petersen @ 2025-02-04 3:35 UTC (permalink / raw)
To: quic_cang, bvanassche, avri.altman, peter.wang,
manivannan.sadhasivam, Bao D. Nguyen
Cc: Martin K . Petersen, linux-scsi, stable, Bean Huo, Daejun Park,
Guenter Roeck, open list
On Mon, 13 Jan 2025 10:32:07 -0800, Bao D. Nguyen wrote:
> According to the UFS Device Specification, the dExtendedUFSFeaturesSupport
> defines the support for TOO_HIGH_TEMPERATURE as bit[4] and the
> TOO_LOW_TEMPERATURE as bit[5]. Correct the code to match with
> the UFS device specification definition.
>
>
Applied to 6.14/scsi-fixes, thanks!
[1/1] scsi: ufs: core: Fix the HIGH/LOW_TEMP Bit Definitions
https://git.kernel.org/mkp/scsi/c/1b3e2d4ec0c5
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 5+ messages in thread