* [PATCH] ima: remove CREDS_CHECK fall through
@ 2019-01-31 18:01 Mimi Zohar
2019-01-31 18:08 ` Gustavo A. R. Silva
2019-01-31 21:26 ` Matthew Garrett
0 siblings, 2 replies; 3+ messages in thread
From: Mimi Zohar @ 2019-01-31 18:01 UTC (permalink / raw)
To: linux-security-module; +Cc: Mimi Zohar, Gustavo A . R . Silva, Matthew Garrett
This patch fixes the CREDS_CHECK fall through as annotated in the
"security mark expected switch fall-throughs" patch.
Signed-off-by: Mimi Zohar <zohar@linux.ibm.com>
Cc: Gustavo A. R. Silva <gustavo@embeddedor.com>
Cc: Matthew Garrett <mjg59@google.com>
---
security/integrity/ima/ima_appraise.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/security/integrity/ima/ima_appraise.c b/security/integrity/ima/ima_appraise.c
index a2baa85ea2f5..5fb7127bbe68 100644
--- a/security/integrity/ima/ima_appraise.c
+++ b/security/integrity/ima/ima_appraise.c
@@ -114,6 +114,7 @@ static void ima_set_cache_status(struct integrity_iint_cache *iint,
break;
case CREDS_CHECK:
iint->ima_creds_status = status;
+ break;
case FILE_CHECK:
case POST_SETATTR:
iint->ima_file_status = status;
--
2.7.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ima: remove CREDS_CHECK fall through
2019-01-31 18:01 [PATCH] ima: remove CREDS_CHECK fall through Mimi Zohar
@ 2019-01-31 18:08 ` Gustavo A. R. Silva
2019-01-31 21:26 ` Matthew Garrett
1 sibling, 0 replies; 3+ messages in thread
From: Gustavo A. R. Silva @ 2019-01-31 18:08 UTC (permalink / raw)
To: Mimi Zohar, linux-security-module; +Cc: Matthew Garrett
Great!
Thanks for reviewing this, Mimi.
On 1/31/19 12:01 PM, Mimi Zohar wrote:
> This patch fixes the CREDS_CHECK fall through as annotated in the
> "security mark expected switch fall-throughs" patch.
>
> Signed-off-by: Mimi Zohar <zohar@linux.ibm.com>
> Cc: Gustavo A. R. Silva <gustavo@embeddedor.com>
> Cc: Matthew Garrett <mjg59@google.com>
Acked-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
> security/integrity/ima/ima_appraise.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/security/integrity/ima/ima_appraise.c b/security/integrity/ima/ima_appraise.c
> index a2baa85ea2f5..5fb7127bbe68 100644
> --- a/security/integrity/ima/ima_appraise.c
> +++ b/security/integrity/ima/ima_appraise.c
> @@ -114,6 +114,7 @@ static void ima_set_cache_status(struct integrity_iint_cache *iint,
> break;
> case CREDS_CHECK:
> iint->ima_creds_status = status;
> + break;
> case FILE_CHECK:
> case POST_SETATTR:
> iint->ima_file_status = status;
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ima: remove CREDS_CHECK fall through
2019-01-31 18:01 [PATCH] ima: remove CREDS_CHECK fall through Mimi Zohar
2019-01-31 18:08 ` Gustavo A. R. Silva
@ 2019-01-31 21:26 ` Matthew Garrett
1 sibling, 0 replies; 3+ messages in thread
From: Matthew Garrett @ 2019-01-31 21:26 UTC (permalink / raw)
To: Mimi Zohar; +Cc: LSM List, Gustavo A . R . Silva
On Thu, Jan 31, 2019 at 10:02 AM Mimi Zohar <zohar@linux.ibm.com> wrote:
>
> This patch fixes the CREDS_CHECK fall through as annotated in the
> "security mark expected switch fall-throughs" patch.
>
> Signed-off-by: Mimi Zohar <zohar@linux.ibm.com>
> Cc: Gustavo A. R. Silva <gustavo@embeddedor.com>
> Cc: Matthew Garrett <mjg59@google.com>
Acked-by: Matthew Garrett <mjg59@google.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-01-31 21:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-31 18:01 [PATCH] ima: remove CREDS_CHECK fall through Mimi Zohar
2019-01-31 18:08 ` Gustavo A. R. Silva
2019-01-31 21:26 ` Matthew Garrett
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox