Linux Security Modules development
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: "Christian Göttsche" <cgzones@googlemail.com>,
	linux-security-module@vger.kernel.org, cocci@inria.fr,
	"Julia Lawall" <Julia.Lawall@inria.fr>,
	"Nicolas Palix" <nicolas.palix@imag.fr>,
	"Serge Hallyn" <serge@hallyn.com>
Cc: "Christian Göttsche" <cgoettsche@seltendoof.de>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [cocci] [PATCH 01/11] coccinelle: Add script to reorder capable() calls
Date: Tue, 26 Nov 2024 13:55:36 +0100	[thread overview]
Message-ID: <8e49861c-123d-4d78-9da7-bdf747c9c33a@web.de> (raw)
In-Reply-To: <20241125104011.36552-11-cgoettsche@seltendoof.de>

…
> +(
> +-  F@p(EL) op E
> ++  E op F(EL)
> +|
> +-  E1 op1 F@p(EL) op2 E2
> ++  E1 op1 E2 op2 F(EL)
> +)

How do you think about to use an SmPL code variant like the following?

(
 E1 op1
-F@p(EL)
+E2
 op2
-E2
+F(EL)
|
-F@p(EL) op
 E
+op F(EL)
)


> +//----------------------------------------------------------
> +//  For context mode
> +//----------------------------------------------------------
> +
> +@r1 depends on !patch exists@
…

I would prefer the dependency specification “context” for this SmPL rule.
The SmPL asterisk functionality should be better distinguished here.


…
> +@script:python depends on org@
> +p << r1.p;
> +@@
…

I got the impression that source code search approaches can be safely
shared only between the operation modes “org” and “report” so far.

Regards,
Markus

  parent reply	other threads:[~2024-11-26 12:56 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-25 10:39 [PATCH 02/11] quota: reorder capability check last Christian Göttsche
2024-11-25 10:39 ` [PATCH 03/11] ext4: " Christian Göttsche
2024-11-25 10:39 ` [PATCH 04/11] hugetlbfs: " Christian Göttsche
2024-11-25 10:39 ` [PATCH 05/11] genwqe: " Christian Göttsche
2024-11-25 10:39 ` [PATCH 06/11] ubifs: " Christian Göttsche
2024-11-25 11:10   ` Liviu Dudau
2024-11-25 11:30   ` Richard Weinberger
2024-11-25 11:48     ` Christian Göttsche
2024-11-25 10:39 ` [PATCH 07/11] ipv4: " Christian Göttsche
2024-11-26  8:01   ` Paolo Abeni
2024-11-25 10:40 ` [PATCH 08/11] gfs2: " Christian Göttsche
2024-11-25 11:34   ` Andreas Gruenbacher
2024-11-25 10:40 ` [PATCH 09/11] fs: " Christian Göttsche
2024-11-25 12:17   ` Christian Brauner
2024-11-25 10:40 ` [PATCH 10/11] skbuff: " Christian Göttsche
2024-11-25 10:40 ` [PATCH 11/11] infiniband: " Christian Göttsche
2024-11-25 10:40 ` [PATCH 01/11] coccinelle: Add script to reorder capable() calls Christian Göttsche
2024-11-25 17:48   ` [cocci] " Markus Elfring
2024-11-26 12:55   ` Markus Elfring [this message]
2024-11-27 11:45   ` Markus Elfring
2024-11-29 12:38   ` Markus Elfring
2024-11-30  4:08   ` Serge E. Hallyn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8e49861c-123d-4d78-9da7-bdf747c9c33a@web.de \
    --to=markus.elfring@web.de \
    --cc=Julia.Lawall@inria.fr \
    --cc=cgoettsche@seltendoof.de \
    --cc=cgzones@googlemail.com \
    --cc=cocci@inria.fr \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=nicolas.palix@imag.fr \
    --cc=serge@hallyn.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox