Linux Security Modules development
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: Hongbo Li <lihongbo22@huawei.com>
Cc: brauner@kernel.org, jack@suse.cz, viro@zeniv.linux.org.uk,
	gnoack@google.com, mic@digikod.net,
	linux-fsdevel@vger.kernel.org,
	linux-security-module@vger.kernel.org
Subject: Re: [RFC PATCH] fs: obtain the inode generation number from vfs directly
Date: Wed, 28 Aug 2024 14:27:53 +1000	[thread overview]
Message-ID: <Zs6nSe1cwmoWu5RD@dread.disaster.area> (raw)
In-Reply-To: <20240827014108.222719-1-lihongbo22@huawei.com>

On Tue, Aug 27, 2024 at 01:41:08AM +0000, Hongbo Li wrote:
> Many mainstream file systems already support the GETVERSION ioctl,
> and their implementations are completely the same, essentially
> just obtain the value of i_generation. We think this ioctl can be
> implemented at the VFS layer, so the file systems do not need to
> implement it individually.
> 
> Signed-off-by: Hongbo Li <lihongbo22@huawei.com>

Nope. No. Definitely not.

I definitely do not want unprivileged users to be able to construct
arbitrary file handles in userspace.....

-Dave.
-- 
Dave Chinner
david@fromorbit.com

  parent reply	other threads:[~2024-08-28  4:27 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-27  1:41 [RFC PATCH] fs: obtain the inode generation number from vfs directly Hongbo Li
2024-08-27  2:13 ` Darrick J. Wong
2024-08-27  2:32   ` Hongbo Li
2024-08-27  5:37     ` Darrick J. Wong
2024-08-27  9:22       ` Christian Brauner
2024-08-27 17:11         ` Darrick J. Wong
2024-08-28  2:16           ` Hongbo Li
2024-08-28  3:44           ` Theodore Ts'o
2024-08-28  5:38           ` Dave Chinner
2024-08-28 15:55             ` Jan Kara
2024-08-29  1:46               ` Darrick J. Wong
2024-08-29 13:34               ` Dave Chinner
2024-08-27  2:53 ` Matthew Wilcox
2024-08-27  3:07   ` Hongbo Li
2024-08-28  4:27 ` Dave Chinner [this message]
2024-08-28 16:36 ` Tavian Barnes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zs6nSe1cwmoWu5RD@dread.disaster.area \
    --to=david@fromorbit.com \
    --cc=brauner@kernel.org \
    --cc=gnoack@google.com \
    --cc=jack@suse.cz \
    --cc=lihongbo22@huawei.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=mic@digikod.net \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox