Linux Security Modules development
 help / color / mirror / Atom feed
From: Jarkko Sakkinen <jarkko@kernel.org>
To: Cen Zhang <zzzccc427@gmail.com>
Cc: Eric Biggers <ebiggers@kernel.org>,
	dhowells@redhat.com, paul@paul-moore.com, jmorris@namei.org,
	serge@hallyn.com, sergeh@kernel.org, keyrings@vger.kernel.org,
	linux-security-module@vger.kernel.org,
	linux-kernel@vger.kernel.org, baijiaju1990@gmail.com,
	jjzuming@gmail.com
Subject: Re: [PATCH v2] keys: Avoid the owner account dereference in named keyring lookup
Date: Sat, 17 Oct 2026 19:28:27 +0300	[thread overview]
Message-ID: <atOiKzlHKH47SMNt@kernel.org> (raw)
In-Reply-To: <CAFRLqsWcV=0MKituMQqALy_2rS3kOPPFpMHxn7yRxoyxOHp6hg@mail.gmail.com>

On Sat, Oct 17, 2026 at 03:47:32PM +0800, Cen Zhang wrote:
> Hi Eric,
> 
> Eric Biggers <ebiggers@kernel.org> 于2026年10月17日周六 11:51写道:
> >
> > Don't key_serial_next() and find_ge_key() (used when reading from
> > /proc/keys) have the same bug?
> >
> > - Eric
> 
> Thansk a lot for the reivew. You're right — key_serial_next() and
> find_ge_key() have
> the same issue.
> 
> I'll send a follow-up patch to fix those as well.
> 
> Thanks for the catch again.
> 
> Best regards,
> Cen Zhang

Yeah, please do.

You put so much effort to scenario and you are nailing the bug
that way, and I do appreciate that, so here's what you should do
with the commit messages:

1. Do the first half like you always do. That's great. And I've
   also said that.
2. Think just a moment. If you get anxiety from that something
   that should be mentioned e.g., something that you did not get
   immediately yourself at first, write remarks those down. I'm
   100% sure you know when it might be good tip on something
   non-obvious.
3. Send that. If we feel it is lacking some info needed, let's
   iterate that. It's not a big deal.

I'm just underlining this because so little would have to be
improved to make this right :-)

Br, Jarkko

  reply	other threads:[~2026-10-17 16:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-09  5:11 [PATCH v2] keys: Avoid the owner account dereference in named keyring lookup Cen Zhang
2026-10-09  5:22 ` sashiko-bot
2026-10-10 20:50 ` Jarkko Sakkinen
2026-10-17  3:51 ` Eric Biggers
2026-10-17  7:47   ` Cen Zhang
2026-10-17 16:28     ` Jarkko Sakkinen [this message]
2026-10-17 16:31       ` Jarkko Sakkinen
2026-10-17 16:19   ` Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=atOiKzlHKH47SMNt@kernel.org \
    --to=jarkko@kernel.org \
    --cc=baijiaju1990@gmail.com \
    --cc=dhowells@redhat.com \
    --cc=ebiggers@kernel.org \
    --cc=jjzuming@gmail.com \
    --cc=jmorris@namei.org \
    --cc=keyrings@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=paul@paul-moore.com \
    --cc=serge@hallyn.com \
    --cc=sergeh@kernel.org \
    --cc=zzzccc427@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox