Linux Security Modules development
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Jarkko Sakkinen" <jarkko@kernel.org>
Cc: keyrings@vger.kernel.org, linux-security-module@vger.kernel.org,
	"Alec Brown" <alec.r.brown@oracle.com>,
	"Daniel P. Smith" <dpsmith@apertussolutions.com>,
	"David Howells" <dhowells@redhat.com>,
	"Eric Biggers" <ebiggers@kernel.org>,
	"James Bottomley" <James.Bottomley@HansenPartnership.com>,
	"James Morris" <jmorris@namei.org>,
	"Jason Gunthorpe" <jgg@ziepe.ca>,
	"Jonathan McDowell" <noodles@earth.li>,
	"Matthew Garrett" <mjg59@srcf.ucam.org>,
	"Mimi Zohar" <zohar@linux.ibm.com>,
	"Paul Moore" <paul@paul-moore.com>,
	"Peter Huewe" <peterhuewe@gmx.de>,
	"Roberto Sassu" <roberto.sassu@huawei.com>,
	"Ross Philipson" <ross.philipson@gmail.com>,
	"Serge E. Hallyn" <serge@hallyn.com>
Subject: Re: [PATCH v3 5/5] tpm-buf: Make tpm_buf_read*() fallible
Date: Mon, 16 Nov 2026 01:09:31 +0000	[thread overview]
Message-ID: <sashiko-outbox-215989@kernel.org> (raw)
In-Reply-To: <20261116005105.1573016-6-jarkko@kernel.org>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] tpm-buf: commit message says @offset instead of @value for
  tpm_buf_read*()
--

commit 1b879beddad8b2ec7e0adcfdce0e0fbb6825a4f9
Author: Jarkko Sakkinen <jarkko@kernel.org>

tpm-buf: Make tpm_buf_read*() fallible

This commit changes tpm_buf_read_u8(), tpm_buf_read_u16(), and
tpm_buf_read_u32() to return a boolean status and write the read word into
an output parameter, updating callers to check for out-of-bounds reads.

> Make tpm_buf_read_u8(), tpm_buf_read_u16() and tpm_buf_read_u32() flows
> unambiguous, and fallible by writing the updated offset to @offset.

[Severity: Low]
This isn't a bug, but the commit message says @offset where the patch adds
a @value output parameter for the read word; @offset was already updated in
place before this change.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261116005105.1573016-1-jarkko@kernel.org?part=5

  reply	other threads:[~2026-11-16  1:09 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16  0:50 [PATCH v3 0/5] Unsorted tpm2-sessions improvements Jarkko Sakkinen
2026-11-16  0:51 ` [PATCH v3 1/5] tpm2-sessions: Drop TPM2_NAME_SIZE Jarkko Sakkinen
2026-11-16  0:55   ` sashiko-bot
2026-11-16  0:51 ` [PATCH v3 2/5] KEYS: trusted: Open code tpm2_buf_append_auth() Jarkko Sakkinen
2026-11-16  0:56   ` sashiko-bot
2026-11-16  0:51 ` [PATCH v3 3/5] KEYS: trusted: Remove dead branch from tpm2_unseal_cmd Jarkko Sakkinen
2026-11-16  0:56   ` sashiko-bot
2026-11-16  0:51 ` [PATCH v3 4/5] tpm2-sessions: Re-orchestrate tpm2_read_public() use Jarkko Sakkinen
2026-11-16  0:58   ` sashiko-bot
2026-11-16  0:51 ` [PATCH v3 5/5] tpm-buf: Make tpm_buf_read*() fallible Jarkko Sakkinen
2026-11-16  1:09   ` sashiko-bot [this message]
2026-11-16  1:29     ` Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-215989@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=alec.r.brown@oracle.com \
    --cc=dhowells@redhat.com \
    --cc=dpsmith@apertussolutions.com \
    --cc=ebiggers@kernel.org \
    --cc=jarkko@kernel.org \
    --cc=jgg@ziepe.ca \
    --cc=jmorris@namei.org \
    --cc=keyrings@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=mjg59@srcf.ucam.org \
    --cc=noodles@earth.li \
    --cc=paul@paul-moore.com \
    --cc=peterhuewe@gmx.de \
    --cc=roberto.sassu@huawei.com \
    --cc=ross.philipson@gmail.com \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=serge@hallyn.com \
    --cc=zohar@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox