From: sashiko-bot@kernel.org
To: "Jarkko Sakkinen" <jarkko@kernel.org>
Cc: linux-mm@kvack.org, linux-security-module@vger.kernel.org,
"Alexander Mikhalitsyn" <alex@amutable.com>,
"Alexander Viro" <viro@zeniv.linux.org.uk>,
"Andy Lutomirski" <luto@amacapital.net>,
"Christian Brauner" <brauner@kernel.org>,
"David Howells" <dhowells@redhat.com>, "Jan Kara" <jack@suse.cz>,
"Jonathan Corbet" <corbet@lwn.net>,
"Josef Bacik" <josef@toxicpanda.com>,
"Kees Cook" <kees@kernel.org>, "Neal Gompa" <neal@gompa.dev>,
"Paul Moore" <paul@paul-moore.com>,
"Serge Hallyn" <sergeh@kernel.org>,
"Zygmunt Krynicki" <zygmunt.krynicki@canonical.com>
Subject: Re: [RFC PATCH v5 07/25] mount: Support MOVE_MOUNT_CLONE with MOVE_MOUNT_T_MNTNS
Date: Sun, 22 Nov 2026 00:10:56 +0000 [thread overview]
Message-ID: <sashiko-outbox-227542@kernel.org> (raw)
In-Reply-To: <20261121000844.1863324-8-jarkko@kernel.org>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] mount: missing SB_NOUSER check in do_move_mount() for
MOVE_MOUNT_CLONE
--
commit 0d056169d39e8a161d1951b83a6a28ab91fbc2ea
Author: Jarkko Sakkinen <jarkko@kernel.org>
mount: Support MOVE_MOUNT_CLONE with MOVE_MOUNT_T_MNTNS
This commit adds MOVE_MOUNT_CLONE for use with MOVE_MOUNT_T_MNTNS so
move_mount() can recursively loopback-clone a path from the caller's mount
namespace directly into a target mount namespace file descriptor.
> diff --git a/fs/namespace.c b/fs/namespace.c
> index b65f1fdd92811..1e7d776c09660 100644
> --- a/fs/namespace.c
> +++ b/fs/namespace.c
[ ... ]
> @@ -3835,6 +3833,35 @@ static int do_move_mount(const struct path *old_path,
> if (m == target_mnt_ns->root)
> return beneath ? -EINVAL : -EBUSY;
> }
> + if (flags & MNT_TREE_CLONE) {
> + unsigned int copy_flags;
> +
> + if (!check_mnt(old) || old->mnt_ns == target_mnt_ns)
> + return -EINVAL;
> + src_user_ns = old->mnt_ns->user_ns;
> + copy_flags = (target_mnt_ns->user_ns != src_user_ns) ?
> + (CL_SLAVE | CL_COPY_UNBINDABLE) :
> + CL_COPY_MNT_NS_FILE;
> + cloned = __do_loopback(old_path, true, copy_flags);
> + if (IS_ERR(cloned))
> + return PTR_ERR(cloned);
> + old = cloned;
> + if (d_is_symlink(old->mnt.mnt_root)) {
> + err = -EINVAL;
> + goto out_cloned;
> + }
[Severity: Medium]
Does this allow cloning and attaching an SB_NOUSER mount such as the
caller's base nullfs mount?
do_loopback() pairs __do_loopback() with graft_tree(), which rejects
SB_NOUSER mounts, and the non-cloning check_mnt(old) branch below rejects
!mnt_has_parent(old). Here __do_loopback() is followed directly by
attach_recursive_mnt(). If old_path resolves to a mount namespace's base
nullfs mount (for example via an O_PATH fd or a pre-init root) and is
cloned onto "/" of an empty target_mnt_ns, a second nullfs mount is
attached on top of target_mnt_ns->root, causing mnt_ns_get_root() to treat
it as a live root filesystem and permanently blocking subsequent rootfs
installation on target_mnt_ns with -EBUSY.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261121000844.1863324-1-jarkko@kernel.org?part=7
next prev parent reply other threads:[~2026-11-22 0:10 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-21 0:08 [RFC PATCH v5 00/25] rootns: fd-bound process closures Jarkko Sakkinen
2026-11-21 0:08 ` [RFC PATCH v5 01/25] userns: Factor out idmap validation and commit helpers Jarkko Sakkinen
2026-11-21 0:08 ` [RFC PATCH v5 02/25] userns: Add userns_set_idmap() system call Jarkko Sakkinen
2026-11-21 16:09 ` Jarkko Sakkinen
2026-11-21 16:49 ` Jarkko Sakkinen
2026-11-21 16:53 ` Jarkko Sakkinen
2026-11-22 0:10 ` sashiko-bot
2026-11-21 0:08 ` [RFC PATCH v5 03/25] arch: Wire up " Jarkko Sakkinen
2026-11-21 15:58 ` Jarkko Sakkinen
2026-11-21 18:12 ` Jarkko Sakkinen
2026-11-22 0:10 ` sashiko-bot
2026-11-21 0:08 ` [RFC PATCH v5 04/25] mount: Add mnt_ns_get_root() Jarkko Sakkinen
2026-11-21 0:08 ` [RFC PATCH v5 05/25] mount: Enforce mount_too_revealing() for foreign mntns Jarkko Sakkinen
2026-11-21 0:08 ` [RFC PATCH v5 06/25] mount: Support MOVE_MOUNT_T_MNTNS in move_mount() Jarkko Sakkinen
2026-11-22 0:10 ` sashiko-bot
2026-11-21 0:08 ` [RFC PATCH v5 07/25] mount: Support MOVE_MOUNT_CLONE with MOVE_MOUNT_T_MNTNS Jarkko Sakkinen
2026-11-22 0:10 ` sashiko-bot [this message]
2026-11-21 0:08 ` [RFC PATCH v5 08/25] userns: Factor out install_user_ns_cred() Jarkko Sakkinen
2026-11-21 0:08 ` [RFC PATCH v5 09/25] nsfs: Add nsproxy_open_namespace() Jarkko Sakkinen
2026-11-21 0:08 ` [RFC PATCH v5 10/25] nsproxy: Pass nsproxy to create_new_namespaces() Jarkko Sakkinen
2026-11-21 0:08 ` [RFC PATCH v5 11/25] rootns: Add core infrastructure for root namespaces Jarkko Sakkinen
2026-11-21 0:08 ` [RFC PATCH v5 12/25] rootns: Track init lifecycle via copy_process() and pid_namespace Jarkko Sakkinen
2026-11-21 1:32 ` Jarkko Sakkinen
2026-11-21 18:08 ` Jarkko Sakkinen
2026-11-21 0:08 ` [RFC PATCH v5 13/25] rootns: Add rootns() system call Jarkko Sakkinen
2026-11-21 19:10 ` Jarkko Sakkinen
2026-11-21 19:12 ` Jarkko Sakkinen
2026-11-21 19:54 ` Jarkko Sakkinen
2026-11-21 20:16 ` Jarkko Sakkinen
2026-11-21 0:08 ` [RFC PATCH v5 14/25] rootns: Add ROOTNS_WAIT ioctl Jarkko Sakkinen
2026-11-21 0:17 ` Jarkko Sakkinen
2026-11-21 0:18 ` Jarkko Sakkinen
2026-11-21 1:09 ` Jarkko Sakkinen
2026-11-21 0:08 ` [RFC PATCH v5 15/25] rootns: Add ROOTNS_KILL ioctl Jarkko Sakkinen
2026-11-21 1:19 ` Jarkko Sakkinen
2026-11-21 11:24 ` Jarkko Sakkinen
2026-11-21 0:08 ` [RFC PATCH v5 16/25] fork: Support CLONE_INTO_ROOTNS in clone3() Jarkko Sakkinen
2026-11-22 0:10 ` sashiko-bot
2026-11-21 0:08 ` [RFC PATCH v5 17/25] fs: Support FSCONFIG_SET_ROOTNS in fsconfig() Jarkko Sakkinen
2026-11-22 0:10 ` sashiko-bot
2026-11-21 0:08 ` [RFC PATCH v5 18/25] proc: Implement ->set_rootns() fs_context operation Jarkko Sakkinen
2026-11-21 0:08 ` [RFC PATCH v5 19/25] ipc/mqueue: " Jarkko Sakkinen
2026-11-21 0:08 ` [RFC PATCH v5 20/25] security: Add rootns LSM hooks Jarkko Sakkinen
2026-11-21 11:47 ` Jarkko Sakkinen
2026-11-21 0:08 ` [RFC PATCH v5 21/25] bpf: Register " Jarkko Sakkinen
2026-11-21 0:08 ` [RFC PATCH v5 22/25] arch: Wire up rootns() system call Jarkko Sakkinen
2026-11-22 0:11 ` sashiko-bot
2026-11-21 0:08 ` [RFC PATCH v5 23/25] docs: Document root namespace uAPI Jarkko Sakkinen
2026-11-21 0:08 ` [RFC PATCH v5 24/25] selftests/rootns: Add root namespace test suite Jarkko Sakkinen
2026-11-21 0:08 ` [RFC PATCH v5 25/25] MAINTAINERS: Add entry for ROOT NAMESPACE Jarkko Sakkinen
2026-11-21 17:21 ` Jarkko Sakkinen
2026-11-22 0:11 ` [RFC PATCH v5 00/25] rootns: fd-bound process closures sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-227542@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=alex@amutable.com \
--cc=brauner@kernel.org \
--cc=corbet@lwn.net \
--cc=dhowells@redhat.com \
--cc=jack@suse.cz \
--cc=jarkko@kernel.org \
--cc=josef@toxicpanda.com \
--cc=kees@kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-security-module@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=neal@gompa.dev \
--cc=paul@paul-moore.com \
--cc=sashiko-reviews@lists.linux.dev \
--cc=sergeh@kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=zygmunt.krynicki@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox