* [PATCH 07/15] serial: imx: remove unnecessary platform_set_drvdata()
@ 2013-05-07 8:02 Jingoo Han
2013-05-07 8:30 ` Shawn Guo
0 siblings, 1 reply; 2+ messages in thread
From: Jingoo Han @ 2013-05-07 8:02 UTC (permalink / raw)
To: 'Greg Kroah-Hartman'
Cc: 'Jiri Slaby', linux-serial, Jingoo Han, Shawn Guo
The driver core clears the driver data to NULL after device_release
or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
(device-core: Ensure drvdata = NULL when no driver is bound).
Thus, it is not needed to manually clear the device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/tty/serial/imx.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c
index 147c9e1..3d17f5b 100644
--- a/drivers/tty/serial/imx.c
+++ b/drivers/tty/serial/imx.c
@@ -1559,8 +1559,6 @@ static int serial_imx_remove(struct platform_device *pdev)
pdata = pdev->dev.platform_data;
- platform_set_drvdata(pdev, NULL);
-
uart_remove_one_port(&imx_reg, &sport->port);
clk_disable_unprepare(sport->clk_per);
--
1.7.2.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 07/15] serial: imx: remove unnecessary platform_set_drvdata()
2013-05-07 8:02 [PATCH 07/15] serial: imx: remove unnecessary platform_set_drvdata() Jingoo Han
@ 2013-05-07 8:30 ` Shawn Guo
0 siblings, 0 replies; 2+ messages in thread
From: Shawn Guo @ 2013-05-07 8:30 UTC (permalink / raw)
To: Jingoo Han
Cc: 'Greg Kroah-Hartman', 'Jiri Slaby', linux-serial
On Tue, May 07, 2013 at 05:02:50PM +0900, Jingoo Han wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
> (device-core: Ensure drvdata = NULL when no driver is bound).
> Thus, it is not needed to manually clear the device driver data to NULL.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Acked-by: Shawn Guo <shawn.guo@linaro.org>
> ---
> drivers/tty/serial/imx.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c
> index 147c9e1..3d17f5b 100644
> --- a/drivers/tty/serial/imx.c
> +++ b/drivers/tty/serial/imx.c
> @@ -1559,8 +1559,6 @@ static int serial_imx_remove(struct platform_device *pdev)
>
> pdata = pdev->dev.platform_data;
>
> - platform_set_drvdata(pdev, NULL);
> -
> uart_remove_one_port(&imx_reg, &sport->port);
>
> clk_disable_unprepare(sport->clk_per);
> --
> 1.7.2.5
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-05-07 8:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-07 8:02 [PATCH 07/15] serial: imx: remove unnecessary platform_set_drvdata() Jingoo Han
2013-05-07 8:30 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox