[PATCH] serial: samsung: Use %pa to print 'resource_size_t' type

[PATCH] serial: samsung: Use %pa to print 'resource_size_t' type

[Fabio Estevam]

From: Fabio Estevam <fabio.estevam@freescale.com>

When building multi_v7_defconfig with CONFIG_ARM_LPAE=y the following warning
is seen:

drivers/tty/serial/samsung.c: In function 's3c24xx_serial_init_port':
drivers/tty/serial/samsung.c:1229:2: warning: format '%x' expects argument of type 'unsigned int', but argument 2 has type 'resource_size_t' [-Wformat]

Use %pa to print 'resource_size_t' type to fix the warning.

Reported-by: Olof's autobuilder <build@lixom.net>
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 drivers/tty/serial/samsung.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/tty/serial/samsung.c b/drivers/tty/serial/samsung.c
index 3293377..b7b8185 100644
--- a/drivers/tty/serial/samsung.c
+++ b/drivers/tty/serial/samsung.c
@@ -1226,8 +1226,8 @@ static int s3c24xx_serial_init_port(struct s3c24xx_uart_port *ourport,
 		wr_regl(port, S3C64XX_UINTSP, 0xf);
 	}
 
-	dbg("port: map=%08x, mem=%p, irq=%d (%d,%d), clock=%u\n",
-	    port->mapbase, port->membase, port->irq,
+	dbg("port: map=%pa, mem=%p, irq=%d (%d,%d), clock=%u\n",
+	    &port->mapbase, port->membase, port->irq,
 	    ourport->rx_irq, ourport->tx_irq, port->uartclk);
 
 	/* reset the fifos (and setup the uart) */
-- 
1.8.3.2

Re: [PATCH] serial: samsung: Use %pa to print 'resource_size_t' type

[Jingoo Han]

On Thursday, June 05, 2014 8:07 AM, Fabio Estevam wrote:
> 
> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> When building multi_v7_defconfig with CONFIG_ARM_LPAE=y the following warning
> is seen:
> 
> drivers/tty/serial/samsung.c: In function 's3c24xx_serial_init_port':
> drivers/tty/serial/samsung.c:1229:2: warning: format '%x' expects argument of type 'unsigned int', but
> argument 2 has type 'resource_size_t' [-Wformat]
> 
> Use %pa to print 'resource_size_t' type to fix the warning.
> 
> Reported-by: Olof's autobuilder <build@lixom.net>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>

Reviewed-by: Jingoo Han <jg1.han@samsung.com>

Best regards,
Jingoo Han

> ---
>  drivers/tty/serial/samsung.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/tty/serial/samsung.c b/drivers/tty/serial/samsung.c
> index 3293377..b7b8185 100644
> --- a/drivers/tty/serial/samsung.c
> +++ b/drivers/tty/serial/samsung.c
> @@ -1226,8 +1226,8 @@ static int s3c24xx_serial_init_port(struct s3c24xx_uart_port *ourport,
>  		wr_regl(port, S3C64XX_UINTSP, 0xf);
>  	}
> 
> -	dbg("port: map=%08x, mem=%p, irq=%d (%d,%d), clock=%u\n",
> -	    port->mapbase, port->membase, port->irq,
> +	dbg("port: map=%pa, mem=%p, irq=%d (%d,%d), clock=%u\n",
> +	    &port->mapbase, port->membase, port->irq,
>  	    ourport->rx_irq, ourport->tx_irq, port->uartclk);
> 
>  	/* reset the fifos (and setup the uart) */
> --
> 1.8.3.2