Linux Serial subsystem development
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: ricardo.ribalda@gmail.com
Cc: sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-serial@vger.kernel.org
Subject: Re: [PATCH 3/3] sparc/uapi: Add definition of TIOC[SG]RS485
Date: Tue, 09 Sep 2014 11:26:40 -0700 (PDT)	[thread overview]
Message-ID: <20140909.112640.131028033967197328.davem@davemloft.net> (raw)
In-Reply-To: <1410286110-24956-1-git-send-email-ricardo.ribalda@gmail.com>

From: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Date: Tue,  9 Sep 2014 20:08:30 +0200

> diff --git a/arch/sparc/include/uapi/asm/ioctls.h b/arch/sparc/include/uapi/asm/ioctls.h
> index 897d172..4e1c5da 100644
> --- a/arch/sparc/include/uapi/asm/ioctls.h
> +++ b/arch/sparc/include/uapi/asm/ioctls.h
> @@ -24,6 +24,8 @@
>  #define TIOCGPKT	_IOR('T', 0x38, int) /* Get packet mode state */
>  #define TIOCGPTLCK	_IOR('T', 0x39, int) /* Get Pty lock state */
>  #define TIOCGEXCL	_IOR('T', 0x40, int) /* Get exclusive mode state */
> +#define TIOCGRS485	0x542E
> +#define TIOCSRS485	0x542F

Please follow the ioctl numbering scheme used by the particular
architecture UAPI file you are editing.

Since Sparc here is using incrementing _IO*() values, including the type
for the object passed in/out of the ioctl, you should do similarly for
TIOC{G,S}RS485.

  reply	other threads:[~2014-09-09 18:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-09 18:08 [PATCH 3/3] sparc/uapi: Add definition of TIOC[SG]RS485 Ricardo Ribalda Delgado
2014-09-09 18:26 ` David Miller [this message]
2014-09-09 18:39   ` Ricardo Ribalda Delgado

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140909.112640.131028033967197328.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=ricardo.ribalda@gmail.com \
    --cc=sparclinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox