* [PATCH 3/3] sparc/uapi: Add definition of TIOC[SG]RS485
@ 2014-09-09 18:08 Ricardo Ribalda Delgado
2014-09-09 18:26 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Ricardo Ribalda Delgado @ 2014-09-09 18:08 UTC (permalink / raw)
To: David S. Miller, sparclinux, linux-kernel, linux-serial
Cc: Ricardo Ribalda Delgado
Commit: e676253b19b2d269cccf67fdb1592120a0cd0676 (serial/8250: Add
support for RS485 IOCTLs), adds support for RS485 ioctls for 825_core on
all the archs. Unfortunaltely the definition of TIOCSRS485 and
TIOCGRS485 was missing on the ioctls.h file
Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
---
arch/sparc/include/uapi/asm/ioctls.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/sparc/include/uapi/asm/ioctls.h b/arch/sparc/include/uapi/asm/ioctls.h
index 897d172..4e1c5da 100644
--- a/arch/sparc/include/uapi/asm/ioctls.h
+++ b/arch/sparc/include/uapi/asm/ioctls.h
@@ -24,6 +24,8 @@
#define TIOCGPKT _IOR('T', 0x38, int) /* Get packet mode state */
#define TIOCGPTLCK _IOR('T', 0x39, int) /* Get Pty lock state */
#define TIOCGEXCL _IOR('T', 0x40, int) /* Get exclusive mode state */
+#define TIOCGRS485 0x542E
+#define TIOCSRS485 0x542F
/* Note that all the ioctls that are not available in Linux have a
* double underscore on the front to: a) avoid some programs to
--
2.1.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 3/3] sparc/uapi: Add definition of TIOC[SG]RS485
2014-09-09 18:08 [PATCH 3/3] sparc/uapi: Add definition of TIOC[SG]RS485 Ricardo Ribalda Delgado
@ 2014-09-09 18:26 ` David Miller
2014-09-09 18:39 ` Ricardo Ribalda Delgado
0 siblings, 1 reply; 3+ messages in thread
From: David Miller @ 2014-09-09 18:26 UTC (permalink / raw)
To: ricardo.ribalda; +Cc: sparclinux, linux-kernel, linux-serial
From: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Date: Tue, 9 Sep 2014 20:08:30 +0200
> diff --git a/arch/sparc/include/uapi/asm/ioctls.h b/arch/sparc/include/uapi/asm/ioctls.h
> index 897d172..4e1c5da 100644
> --- a/arch/sparc/include/uapi/asm/ioctls.h
> +++ b/arch/sparc/include/uapi/asm/ioctls.h
> @@ -24,6 +24,8 @@
> #define TIOCGPKT _IOR('T', 0x38, int) /* Get packet mode state */
> #define TIOCGPTLCK _IOR('T', 0x39, int) /* Get Pty lock state */
> #define TIOCGEXCL _IOR('T', 0x40, int) /* Get exclusive mode state */
> +#define TIOCGRS485 0x542E
> +#define TIOCSRS485 0x542F
Please follow the ioctl numbering scheme used by the particular
architecture UAPI file you are editing.
Since Sparc here is using incrementing _IO*() values, including the type
for the object passed in/out of the ioctl, you should do similarly for
TIOC{G,S}RS485.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 3/3] sparc/uapi: Add definition of TIOC[SG]RS485
2014-09-09 18:26 ` David Miller
@ 2014-09-09 18:39 ` Ricardo Ribalda Delgado
0 siblings, 0 replies; 3+ messages in thread
From: Ricardo Ribalda Delgado @ 2014-09-09 18:39 UTC (permalink / raw)
To: David Miller; +Cc: sparclinux, LKML, linux-serial
Hello David
Thanks for you comments, I thought it was a good idea that the same
ioctl had the same value on all the arch, sorry to make a mess on your
file :)
I have just resend a v2 of the patch.
Regards!
On Tue, Sep 9, 2014 at 8:26 PM, David Miller <davem@davemloft.net> wrote:
> From: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
> Date: Tue, 9 Sep 2014 20:08:30 +0200
>
>> diff --git a/arch/sparc/include/uapi/asm/ioctls.h b/arch/sparc/include/uapi/asm/ioctls.h
>> index 897d172..4e1c5da 100644
>> --- a/arch/sparc/include/uapi/asm/ioctls.h
>> +++ b/arch/sparc/include/uapi/asm/ioctls.h
>> @@ -24,6 +24,8 @@
>> #define TIOCGPKT _IOR('T', 0x38, int) /* Get packet mode state */
>> #define TIOCGPTLCK _IOR('T', 0x39, int) /* Get Pty lock state */
>> #define TIOCGEXCL _IOR('T', 0x40, int) /* Get exclusive mode state */
>> +#define TIOCGRS485 0x542E
>> +#define TIOCSRS485 0x542F
>
> Please follow the ioctl numbering scheme used by the particular
> architecture UAPI file you are editing.
>
> Since Sparc here is using incrementing _IO*() values, including the type
> for the object passed in/out of the ioctl, you should do similarly for
> TIOC{G,S}RS485.
--
Ricardo Ribalda
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-09-09 18:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-09 18:08 [PATCH 3/3] sparc/uapi: Add definition of TIOC[SG]RS485 Ricardo Ribalda Delgado
2014-09-09 18:26 ` David Miller
2014-09-09 18:39 ` Ricardo Ribalda Delgado
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox