* [PATCH] tty: serial: fsl_lpuart: Fix lpuart_flush_buffer()
2019-10-04 21:55 [PATCH] tty: serial: fsl_lpuart: Fix lpuart_flush_buffer() Andrey Smirnov
@ 2019-10-04 21:55 ` Andrey Smirnov
2019-10-04 22:06 ` Fabio Estevam
` (2 subsequent siblings)
3 siblings, 0 replies; 8+ messages in thread
From: Andrey Smirnov @ 2019-10-04 21:55 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Andrey Smirnov, Stefan Agner, Andrew Lunn, Vivien Didelot,
Chris Healy, Cory Tusar, Lucas Stach, Jiri Slaby, linux-imx,
linux-serial, linux-kernel
Fix incorrect read-modify-write sequence in lpuart_flush_buffer() that
was reading from UARTPFIFO and writing to UARTCFIFO instead of
operating solely on the latter.
Fixes: 9bc19af9dacb ("tty: serial: fsl_lpuart: Flush HW FIFOs in .flush_buffer")
Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: Stefan Agner <stefan@agner.ch>
Cc: Andrew Lunn <andrew@lunn.ch>
Cc: Vivien Didelot <vivien.didelot@gmail.com>
Cc: Chris Healy <cphealy@gmail.com>
Cc: Cory Tusar <cory.tusar@zii.aero>
Cc: Lucas Stach <l.stach@pengutronix.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jslaby@suse.com>
Cc: linux-imx@nxp.com
Cc: linux-serial@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
---
Greg:
This bug causes occasional boot hang on 5.4-rc1 on Vybrid, so it might
be good to push that for 5.4-rc2.
Thanks,
Andrey Sirnov
drivers/tty/serial/fsl_lpuart.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c
index 3e17bb8a0b16..537896c4d887 100644
--- a/drivers/tty/serial/fsl_lpuart.c
+++ b/drivers/tty/serial/fsl_lpuart.c
@@ -548,7 +548,7 @@ static void lpuart_flush_buffer(struct uart_port *port)
val |= UARTFIFO_TXFLUSH | UARTFIFO_RXFLUSH;
lpuart32_write(&sport->port, val, UARTFIFO);
} else {
- val = readb(sport->port.membase + UARTPFIFO);
+ val = readb(sport->port.membase + UARTCFIFO);
val |= UARTCFIFO_TXFLUSH | UARTCFIFO_RXFLUSH;
writeb(val, sport->port.membase + UARTCFIFO);
}
--
2.21.0
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH] tty: serial: fsl_lpuart: Fix lpuart_flush_buffer()
2019-10-04 21:55 [PATCH] tty: serial: fsl_lpuart: Fix lpuart_flush_buffer() Andrey Smirnov
2019-10-04 21:55 ` Andrey Smirnov
@ 2019-10-04 22:06 ` Fabio Estevam
2019-10-04 22:06 ` Fabio Estevam
2019-10-04 22:53 ` Andrew Lunn
2019-10-05 0:12 ` Vivien Didelot
3 siblings, 1 reply; 8+ messages in thread
From: Fabio Estevam @ 2019-10-04 22:06 UTC (permalink / raw)
To: Andrey Smirnov
Cc: Greg Kroah-Hartman, Stefan Agner, Andrew Lunn, Vivien Didelot,
Chris Healy, Cory Tusar, Lucas Stach, Jiri Slaby, NXP Linux Team,
linux-serial, linux-kernel
On Fri, Oct 4, 2019 at 6:59 PM Andrey Smirnov <andrew.smirnov@gmail.com> wrote:
>
> Fix incorrect read-modify-write sequence in lpuart_flush_buffer() that
> was reading from UARTPFIFO and writing to UARTCFIFO instead of
> operating solely on the latter.
>
> Fixes: 9bc19af9dacb ("tty: serial: fsl_lpuart: Flush HW FIFOs in .flush_buffer")
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
Reviewed-by: Fabio Estevam <festevam@gmail.com>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] tty: serial: fsl_lpuart: Fix lpuart_flush_buffer()
2019-10-04 22:06 ` Fabio Estevam
@ 2019-10-04 22:06 ` Fabio Estevam
0 siblings, 0 replies; 8+ messages in thread
From: Fabio Estevam @ 2019-10-04 22:06 UTC (permalink / raw)
To: Andrey Smirnov
Cc: Greg Kroah-Hartman, Stefan Agner, Andrew Lunn, Vivien Didelot,
Chris Healy, Cory Tusar, Lucas Stach, Jiri Slaby, NXP Linux Team,
linux-serial, linux-kernel
On Fri, Oct 4, 2019 at 6:59 PM Andrey Smirnov <andrew.smirnov@gmail.com> wrote:
>
> Fix incorrect read-modify-write sequence in lpuart_flush_buffer() that
> was reading from UARTPFIFO and writing to UARTCFIFO instead of
> operating solely on the latter.
>
> Fixes: 9bc19af9dacb ("tty: serial: fsl_lpuart: Flush HW FIFOs in .flush_buffer")
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
Reviewed-by: Fabio Estevam <festevam@gmail.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] tty: serial: fsl_lpuart: Fix lpuart_flush_buffer()
2019-10-04 21:55 [PATCH] tty: serial: fsl_lpuart: Fix lpuart_flush_buffer() Andrey Smirnov
2019-10-04 21:55 ` Andrey Smirnov
2019-10-04 22:06 ` Fabio Estevam
@ 2019-10-04 22:53 ` Andrew Lunn
2019-10-04 22:53 ` Andrew Lunn
2019-10-05 0:12 ` Vivien Didelot
3 siblings, 1 reply; 8+ messages in thread
From: Andrew Lunn @ 2019-10-04 22:53 UTC (permalink / raw)
To: Andrey Smirnov
Cc: Greg Kroah-Hartman, Stefan Agner, Vivien Didelot, Chris Healy,
Cory Tusar, Lucas Stach, Jiri Slaby, linux-imx, linux-serial,
linux-kernel
On Fri, Oct 04, 2019 at 02:55:37PM -0700, Andrey Smirnov wrote:
> Fix incorrect read-modify-write sequence in lpuart_flush_buffer() that
> was reading from UARTPFIFO and writing to UARTCFIFO instead of
> operating solely on the latter.
>
> Fixes: 9bc19af9dacb ("tty: serial: fsl_lpuart: Flush HW FIFOs in .flush_buffer")
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
Tested-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] tty: serial: fsl_lpuart: Fix lpuart_flush_buffer()
2019-10-04 22:53 ` Andrew Lunn
@ 2019-10-04 22:53 ` Andrew Lunn
0 siblings, 0 replies; 8+ messages in thread
From: Andrew Lunn @ 2019-10-04 22:53 UTC (permalink / raw)
To: Andrey Smirnov
Cc: Greg Kroah-Hartman, Stefan Agner, Vivien Didelot, Chris Healy,
Cory Tusar, Lucas Stach, Jiri Slaby, linux-imx, linux-serial,
linux-kernel
On Fri, Oct 04, 2019 at 02:55:37PM -0700, Andrey Smirnov wrote:
> Fix incorrect read-modify-write sequence in lpuart_flush_buffer() that
> was reading from UARTPFIFO and writing to UARTCFIFO instead of
> operating solely on the latter.
>
> Fixes: 9bc19af9dacb ("tty: serial: fsl_lpuart: Flush HW FIFOs in .flush_buffer")
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
Tested-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] tty: serial: fsl_lpuart: Fix lpuart_flush_buffer()
2019-10-04 21:55 [PATCH] tty: serial: fsl_lpuart: Fix lpuart_flush_buffer() Andrey Smirnov
` (2 preceding siblings ...)
2019-10-04 22:53 ` Andrew Lunn
@ 2019-10-05 0:12 ` Vivien Didelot
2019-10-05 0:12 ` Vivien Didelot
3 siblings, 1 reply; 8+ messages in thread
From: Vivien Didelot @ 2019-10-05 0:12 UTC (permalink / raw)
Cc: Greg Kroah-Hartman, Andrey Smirnov, Stefan Agner, Andrew Lunn,
Chris Healy, Cory Tusar, Lucas Stach, Jiri Slaby, linux-imx,
linux-serial, linux-kernel
Hi Andrey,
On Fri, 4 Oct 2019 14:55:37 -0700, Andrey Smirnov <andrew.smirnov@gmail.com> wrote:
> Fix incorrect read-modify-write sequence in lpuart_flush_buffer() that
> was reading from UARTPFIFO and writing to UARTCFIFO instead of
> operating solely on the latter.
>
> Fixes: 9bc19af9dacb ("tty: serial: fsl_lpuart: Flush HW FIFOs in .flush_buffer")
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
This fixes the TTY on my ZII Devel Boards Rev B and C:
Reported-by: Vivien Didelot <vivien.didelot@gmail.com>
Tested-by: Vivien Didelot <vivien.didelot@gmail.com>
Thank you!
Vivien
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] tty: serial: fsl_lpuart: Fix lpuart_flush_buffer()
2019-10-05 0:12 ` Vivien Didelot
@ 2019-10-05 0:12 ` Vivien Didelot
0 siblings, 0 replies; 8+ messages in thread
From: Vivien Didelot @ 2019-10-05 0:12 UTC (permalink / raw)
To: Andrey Smirnov
Cc: Greg Kroah-Hartman, Andrey Smirnov, Stefan Agner, Andrew Lunn,
Chris Healy, Cory Tusar, Lucas Stach, Jiri Slaby, linux-imx,
linux-serial, linux-kernel
Hi Andrey,
On Fri, 4 Oct 2019 14:55:37 -0700, Andrey Smirnov <andrew.smirnov@gmail.com> wrote:
> Fix incorrect read-modify-write sequence in lpuart_flush_buffer() that
> was reading from UARTPFIFO and writing to UARTCFIFO instead of
> operating solely on the latter.
>
> Fixes: 9bc19af9dacb ("tty: serial: fsl_lpuart: Flush HW FIFOs in .flush_buffer")
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
This fixes the TTY on my ZII Devel Boards Rev B and C:
Reported-by: Vivien Didelot <vivien.didelot@gmail.com>
Tested-by: Vivien Didelot <vivien.didelot@gmail.com>
Thank you!
Vivien
^ permalink raw reply [flat|nested] 8+ messages in thread