Linux Serial subsystem development
 help / color / mirror / Atom feed
From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: linux-serial@vger.kernel.org,
	"Greg KH" <gregkh@linuxfoundation.org>,
	"Jiri Slaby" <jirislaby@kernel.org>,
	"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Subject: [PATCH v3 0/6] LSR flag preservation improvements
Date: Tue,  7 Jun 2022 11:29:28 +0300	[thread overview]
Message-ID: <20220607082934.7242-1-ilpo.jarvinen@linux.intel.com> (raw)

Improve LSR flag preservation. Not all devices preserve all LSR flags
on read. Therefore, the non-permanent flags must be stored until
consumed. 8250_port has handled this for some of the reads (but not
all). Drivers not so much but it's unclear to me which of the devices
actually clear flags on read so this series only does per driver fixes
for DW.

I've just put Uwe as Co-dev-by and SoB according to Andy's suggestion
in order to allow forward progress (Uwe indicated he's OK with any
sensible combination of tags anyway). I agree with Uwe's position
though that it would be nice to be able to record Acked-by in some
(probably quite rare) cases even if the person is already SoB but I
don't want to keep dragging this issue on and on over a single line
patch :-).

v2:
- Added more patches

v3:
- Fix Uwe's email and convert it to Co-developed-by


Ilpo Järvinen (6):
  serial: 8250: Store to lsr_save_flags after lsr read
  serial: 8250: Create serial_lsr_in()
  serial: 8250: Get preserved flags using serial_lsr_in()
  serial: 8250: Adjust misleading LSR related comment
  serial: 8250_dw: Use serial_lsr_in() in dw8250_handle_irq()
  serial: 8250_dw: Store LSR into lsr_saved_flags in
    dw8250_tx_wait_empty()

 drivers/tty/serial/8250/8250.h      | 20 ++++++++++++++++++++
 drivers/tty/serial/8250/8250_core.c |  3 +--
 drivers/tty/serial/8250/8250_dw.c   |  7 +++++--
 drivers/tty/serial/8250/8250_port.c | 24 +++++++++++-------------
 4 files changed, 37 insertions(+), 17 deletions(-)

-- 
2.30.2


             reply	other threads:[~2022-06-07  8:29 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-07  8:29 Ilpo Järvinen [this message]
2022-06-07  8:29 ` [PATCH v3 1/6] serial: 8250: Store to lsr_save_flags after lsr read Ilpo Järvinen
2022-06-07  8:29 ` [PATCH v3 2/6] serial: 8250: Create serial_lsr_in() Ilpo Järvinen
2022-06-07  8:29 ` [PATCH v3 3/6] serial: 8250: Get preserved flags using serial_lsr_in() Ilpo Järvinen
2022-06-07  8:29 ` [PATCH v3 4/6] serial: 8250: Adjust misleading LSR related comment Ilpo Järvinen
2022-06-07 10:22   ` Andy Shevchenko
2022-06-07 12:11     ` Ilpo Järvinen
2022-06-07 14:46       ` Andy Shevchenko
2022-06-07  8:29 ` [PATCH v3 5/6] serial: 8250_dw: Use serial_lsr_in() in dw8250_handle_irq() Ilpo Järvinen
2022-06-07  8:29 ` [PATCH v3 6/6] serial: 8250_dw: Store LSR into lsr_saved_flags in dw8250_tx_wait_empty() Ilpo Järvinen
2022-06-07 14:44 ` [PATCH v3 0/6] LSR flag preservation improvements Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220607082934.7242-1-ilpo.jarvinen@linux.intel.com \
    --to=ilpo.jarvinen@linux.intel.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jirislaby@kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox