Linux Serial subsystem development
 help / color / mirror / Atom feed
From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>,
	"Greg KH" <gregkh@linuxfoundation.org>,
	"Jiri Slaby" <jirislaby@kernel.org>,
	"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 4/6] serial: 8250: Adjust misleading LSR related comment
Date: Tue, 7 Jun 2022 15:11:32 +0300 (EEST)	[thread overview]
Message-ID: <e22db21a-cfc3-b7e4-3fd9-6cee9e189213@linux.intel.com> (raw)
In-Reply-To: <CAHp75VfK4v15HrBwwD9b7q6EYdcp3VnP5RGKVuPeSWk4TSyq+w@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1443 bytes --]

On Tue, 7 Jun 2022, Andy Shevchenko wrote:

> On Tue, Jun 7, 2022 at 11:16 AM Ilpo Järvinen
> <ilpo.jarvinen@linux.intel.com> wrote:
> 
> > only flags which were not handled). Adjust the comment to match
> > behavior and warn about which flags can be depended on.
> >
> > While I'd have moved LSR read before LSR read and used serial_lsr_in()
> > also here but I came across this old discussion about the topic:
> 
> >   https://www.spinics.net/lists/linux-serial/msg20555.html
> 
> Can it be transformed to lore.kernel.org link?

Unfortunately no, AFAICT. I tried searching but I couldn't find one 
from there (In fact, I tried even before submitting them because you 
previously told me I should use lore links instead).

More importantly though, it seems that the link was not the one I was 
supposed to use (I probably copy pasted the url from a wrong window while 
investigating all turns of it). This is the correct link:

  https://www.spinics.net/lists/linux-serial/msg16220.html

> and maybe even moved as BugLink tag?

What's BugLink? Our documentation isn't particularly helpful:

$ git grep BugLink
scripts/checkpatch.pl:              $line !~ /^\s*(?:Link|Patchwork|http|https|BugLink|base-commit):/i &&
$

...It seems mostly about bug trackers such as bugzilla, etc. based on git 
log so that tag seems not relevant.

I put the correct URL now into Link tag.

I'll resend tomorrow to give the dust some time to settle.

-- 
 i.

  reply	other threads:[~2022-06-07 12:11 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-07  8:29 [PATCH v3 0/6] LSR flag preservation improvements Ilpo Järvinen
2022-06-07  8:29 ` [PATCH v3 1/6] serial: 8250: Store to lsr_save_flags after lsr read Ilpo Järvinen
2022-06-07  8:29 ` [PATCH v3 2/6] serial: 8250: Create serial_lsr_in() Ilpo Järvinen
2022-06-07  8:29 ` [PATCH v3 3/6] serial: 8250: Get preserved flags using serial_lsr_in() Ilpo Järvinen
2022-06-07  8:29 ` [PATCH v3 4/6] serial: 8250: Adjust misleading LSR related comment Ilpo Järvinen
2022-06-07 10:22   ` Andy Shevchenko
2022-06-07 12:11     ` Ilpo Järvinen [this message]
2022-06-07 14:46       ` Andy Shevchenko
2022-06-07  8:29 ` [PATCH v3 5/6] serial: 8250_dw: Use serial_lsr_in() in dw8250_handle_irq() Ilpo Järvinen
2022-06-07  8:29 ` [PATCH v3 6/6] serial: 8250_dw: Store LSR into lsr_saved_flags in dw8250_tx_wait_empty() Ilpo Järvinen
2022-06-07 14:44 ` [PATCH v3 0/6] LSR flag preservation improvements Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e22db21a-cfc3-b7e4-3fd9-6cee9e189213@linux.intel.com \
    --to=ilpo.jarvinen@linux.intel.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jirislaby@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox