From: Lino Sanfilippo <l.sanfilippo@kunbus.com>
To: gregkh@linuxfoundation.org, jirislaby@kernel.org,
ilpo.jarvinen@linux.intel.com
Cc: u.kleine-koenig@pengutronix.de, shawnguo@kernel.org,
s.hauer@pengutronix.de, mcoquelin.stm32@gmail.com,
alexandre.torgue@foss.st.com, cniedermaier@dh-electronics.com,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
LinoSanfilippo@gmx.de, lukas@wunner.de, p.rosenberger@kunbus.com,
Lino Sanfilippo <l.sanfilippo@kunbus.com>,
stable@vger.kernel.org
Subject: [PATCH v4 7/7] serial: 8250_exar: Set missing rs485_supported flag
Date: Wed, 18 Oct 2023 19:48:40 +0200 [thread overview]
Message-ID: <20231018174840.28977-8-l.sanfilippo@kunbus.com> (raw)
In-Reply-To: <20231018174840.28977-1-l.sanfilippo@kunbus.com>
The UART supports an auto-RTS mode in which the RTS pin is automatically
activated during transmission. So mark this mode as being supported even
if RTS is not controlled by the driver but the UART.
Also the serial core expects now at least one of both modes rts-on-send or
rts-after-send to be supported. This is since during sanitization
unsupported flags are deleted from a RS485 configuration set by userspace.
However if the configuration ends up with both flags unset, the core prints
a warning since it considers such a configuration invalid (see
uart_sanitize_serial_rs485()).
Cc: stable@vger.kernel.org
Signed-off-by: Lino Sanfilippo <l.sanfilippo@kunbus.com>
---
drivers/tty/serial/8250/8250_exar.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
This patch is only required if "serial: core: fix sanitizing check for RTS
settings" is applied, which is also part of this series.
Therefore it lacks a "Fixes:" tag.
diff --git a/drivers/tty/serial/8250/8250_exar.c b/drivers/tty/serial/8250/8250_exar.c
index 077c3ba3539e..8385be846840 100644
--- a/drivers/tty/serial/8250/8250_exar.c
+++ b/drivers/tty/serial/8250/8250_exar.c
@@ -446,7 +446,7 @@ static int generic_rs485_config(struct uart_port *port, struct ktermios *termios
}
static const struct serial_rs485 generic_rs485_supported = {
- .flags = SER_RS485_ENABLED,
+ .flags = SER_RS485_ENABLED | SER_RS485_RTS_ON_SEND,
};
static const struct exar8250_platform exar8250_default_platform = {
@@ -490,7 +490,8 @@ static int iot2040_rs485_config(struct uart_port *port, struct ktermios *termios
}
static const struct serial_rs485 iot2040_rs485_supported = {
- .flags = SER_RS485_ENABLED | SER_RS485_RX_DURING_TX | SER_RS485_TERMINATE_BUS,
+ .flags = SER_RS485_ENABLED | SER_RS485_RTS_ON_SEND |
+ SER_RS485_RX_DURING_TX | SER_RS485_TERMINATE_BUS,
};
static const struct property_entry iot2040_gpio_properties[] = {
--
2.40.1
next prev parent reply other threads:[~2023-10-18 17:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-18 17:48 [PATCH v4 0/7] Fixes and improvements for RS485 Lino Sanfilippo
2023-10-18 17:48 ` [PATCH v4 1/7] serial: Do not hold the port lock when setting rx-during-tx GPIO Lino Sanfilippo
2023-10-18 17:48 ` [PATCH v4 2/7] serial: core: set missing supported flag for RX during TX GPIO Lino Sanfilippo
2023-10-18 17:48 ` [PATCH v4 3/7] serial: core: fix sanitizing check for RTS settings Lino Sanfilippo
2023-10-18 17:48 ` [PATCH v4 4/7] serial: core: make sure RS485 cannot be enabled when it is not supported Lino Sanfilippo
2023-10-18 17:48 ` [PATCH v4 5/7] serial: core, imx: do not set RS485 enabled if " Lino Sanfilippo
2023-10-18 17:48 ` [PATCH v4 6/7] serial: omap: do not override settings for RS485 support Lino Sanfilippo
2023-10-18 17:48 ` Lino Sanfilippo [this message]
2023-10-27 11:03 ` [PATCH v4 0/7] Fixes and improvements for RS485 Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231018174840.28977-8-l.sanfilippo@kunbus.com \
--to=l.sanfilippo@kunbus.com \
--cc=LinoSanfilippo@gmx.de \
--cc=alexandre.torgue@foss.st.com \
--cc=cniedermaier@dh-electronics.com \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=mcoquelin.stm32@gmail.com \
--cc=p.rosenberger@kunbus.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=stable@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox